Re: [PATCH V2 0/4] target/microblaze: Add GDB XML and correct SReg reporting

["Edgar E. Iglesias" <edgar.iglesias@xilinx.com>]

On Wed, May 13, 2020 at 11:08:49AM -0700, Joe Komlodi wrote:
> Hi all,
> 
> This series adds dynamic GDB XML support for Micraoblaze CPUs, and 
> fixes an issue when reporting Microblaze SRegs through GDB.
> 
> The SRegs used to be printed out by iterating over the SReg array, but 
> the SReg array isn't laid out in memory in the same order that GDB expects them.
> 
> When reporting register to GDB, note that even though 32-bit 
> Microblaze supports having certain registers wider than 32-bits, we're 
> repoting all of them as being 32-bits wide right now to maintain compatibility with GDB.

Hi Joe,

I've taken patches #2 - 4 into my queue.
Patch #1 needs some more work.

Thanks,
Edgar



> 
> Thanks!
> Joe
> 
> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> 
> Changelog:
> v1 -> v2
>  - 1/4: Added missing core XML file
> 
> 
> Joe Komlodi (4):
>   target/microblaze: gdb: Add dynamic GDB XML register support
>   target/microblaze: gdb: Extend the number of registers presented to
>     GDB
>   target/microblaze: gdb: Fix incorrect SReg reporting
>   target/microblaze: monitor: Increase the number of registers reported
> 
>  configure                     |   1 +
>  gdb-xml/microblaze-core.xml   |  64 +++++++++++++
>  target/microblaze/cpu.c       |   6 +-
>  target/microblaze/cpu.h       |   9 ++
>  target/microblaze/gdbstub.c   | 214 +++++++++++++++++++++++++++++++++++++++++-
>  target/microblaze/translate.c |  16 +++-
>  6 files changed, 304 insertions(+), 6 deletions(-)
>  create mode 100644 gdb-xml/microblaze-core.xml
> 
> -- 
> 2.7.4
>