From: Dan Carpenter <dan.carpenter@oracle.com>
To: linux-sparse@vger.kernel.org
Subject: complain about re-declared functions with different modifiers
Date: Thu, 14 May 2020 17:04:51 +0300 [thread overview]
Message-ID: <20200514140451.GD2078@kadam> (raw)
I recently spent some time tracking down why Smatch wasn't parsing
nvme_put_ctrl() correctly. It turned out the problem is that it's
declared as both inline and not inline so Smatch never parses it.
drivers/nvme/host/nvme.h
472 static inline void nvme_get_ctrl(struct nvme_ctrl *ctrl)
473 {
474 get_device(ctrl->device);
475 }
476
477 static inline void nvme_put_ctrl(struct nvme_ctrl *ctrl)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
It's an inline here.
478 {
479 put_device(ctrl->device);
480 }
481
482 static inline bool nvme_is_aen_req(u16 qid, __u16 command_id)
483 {
484 return !qid && command_id >= NVME_AQ_BLK_MQ_DEPTH;
485 }
486
487 void nvme_complete_rq(struct request *req);
488 bool nvme_cancel_request(struct request *req, void *data, bool reserved);
489 bool nvme_change_ctrl_state(struct nvme_ctrl *ctrl,
490 enum nvme_ctrl_state new_state);
491 bool nvme_wait_reset(struct nvme_ctrl *ctrl);
492 int nvme_disable_ctrl(struct nvme_ctrl *ctrl);
493 int nvme_enable_ctrl(struct nvme_ctrl *ctrl);
494 int nvme_shutdown_ctrl(struct nvme_ctrl *ctrl);
495 int nvme_init_ctrl(struct nvme_ctrl *ctrl, struct device *dev,
496 const struct nvme_ctrl_ops *ops, unsigned long quirks);
497 void nvme_uninit_ctrl(struct nvme_ctrl *ctrl);
498 void nvme_start_ctrl(struct nvme_ctrl *ctrl);
499 void nvme_stop_ctrl(struct nvme_ctrl *ctrl);
500 void nvme_put_ctrl(struct nvme_ctrl *ctrl);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
But then it's re-declared as not inline.
501 int nvme_init_identify(struct nvme_ctrl *ctrl);
Could Sparse print a warning for that?
regards,
dan carpenter
next reply other threads:[~2020-05-14 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 14:04 Dan Carpenter [this message]
2020-05-14 18:18 ` complain about re-declared functions with different modifiers Linus Torvalds
2020-05-14 20:56 ` Luc Van Oostenryck
2020-05-14 22:32 ` Linus Torvalds
2020-05-15 16:18 ` Luc Van Oostenryck
2020-05-15 17:03 ` Derek M Jones
2020-05-15 13:36 ` Dan Carpenter
2020-05-15 16:11 ` Luc Van Oostenryck
2020-05-17 4:56 ` Luc Van Oostenryck
2020-05-18 14:42 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514140451.GD2078@kadam \
--to=dan.carpenter@oracle.com \
--cc=linux-sparse@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.