From: Mike Snitzer <snitzer@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Damien LeMoal <damien.lemoal@wdc.com>, dm-devel@redhat.com
Subject: Re: [PATCH 1/2] device-mapper: use dynamic debug instead of compile-time config option
Date: Thu, 14 May 2020 13:15:33 -0400 [thread overview]
Message-ID: <20200514171533.GD31400@redhat.com> (raw)
In-Reply-To: <20200514060929.85469-2-hare@suse.de>
On Thu, May 14 2020 at 2:09am -0400,
Hannes Reinecke <hare@suse.de> wrote:
> Switch to use dynamic debug to avoid having recompile the kernel
> just to enable debugging messages.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
FYI, I decided to always use pr_debug* rather than preserve using printk
if CONFIG_DM_DEBUG is enabled. More consistent and less surprising for
a developer (to have to reason through how to enable debugging).
May cause initial surprise if debugging messages disappear despite
CONFIG_DM_DEBUG being enabled... but pretty sure DM developers can cope
(and/or help non-developers) as needed.
Patches were staged for 5.8, I also added an additional related cleanup:
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-5.8
Thanks,
Mike
next prev parent reply other threads:[~2020-05-14 17:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 6:09 [PATCHv2 0/2] device-mapper: use dynamic debug Hannes Reinecke
2020-05-14 6:09 ` [PATCH 1/2] device-mapper: use dynamic debug instead of compile-time config option Hannes Reinecke
2020-05-14 7:53 ` Damien Le Moal
2020-05-14 16:26 ` Mike Snitzer
2020-05-14 17:15 ` Mike Snitzer [this message]
2020-05-14 6:09 ` [PATCH 2/2] dm-zoned: remove spurious newlines from debugging messages Hannes Reinecke
2020-05-14 7:53 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514171533.GD31400@redhat.com \
--to=snitzer@redhat.com \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.