From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 111A9C433E0 for ; Fri, 15 May 2020 00:40:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E164920727 for ; Fri, 15 May 2020 00:40:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ncWP6c8T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726100AbgEOAkD (ORCPT ); Thu, 14 May 2020 20:40:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727995AbgEOAkA (ORCPT ); Thu, 14 May 2020 20:40:00 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6638C05BD43 for ; Thu, 14 May 2020 17:39:59 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id p21so156076pgm.13 for ; Thu, 14 May 2020 17:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MxFx2v3CXXJI2uqpzJc0nTIbU803tm+QFkEcg6RoGME=; b=ncWP6c8T/qeB5mTi8dmQ/2f++LBk5CizP09+SlPJnyCzgNs/XM3OV3LABFolMAuaaE UYHUIc3yE2lEXImqHTT1olFACAUL2RuRf0qtmuTLimsMw3ZEFjzxm4slAwvUIDb2cFT/ wcJNyV8sDtE3sXgsivVXiTYvixU3wl/p0/67k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MxFx2v3CXXJI2uqpzJc0nTIbU803tm+QFkEcg6RoGME=; b=Ei2sfLQohrjJhIJPTj7ovDmNMKH91sN1zRqDmePqBsSbpo/pli6PykQN/yNYa6d5HI nv0JwynT/CT3/SaQruTQxWkb1gBy/qTGxpyWqhxt8LCaI0rhPdvzHXgBDbY492NRUxHA N9HoqcsI/TnycCmfQfK2oO/LzCUcL2WTuFfQGLLFz8EfOANgWDt2p67l4yeGT4o/ZQ9P yClFyP6EPFGK7oVLaA7/nuADUu7aaKach+xpZKjxtNZLfSi4QAJ+BvaaITiTJ+bowZL2 5C3Eg0cJW8u5OBZrocjLe2vPBGx0wKWN/AMu4fDD8iwWJLCDxm0o4HxqV6x+mB/bNYwc Fd9Q== X-Gm-Message-State: AOAM530Ysn/gzUqCajpeOthbiwtANiUaKBAWBvEyK4870Yo4yIpwJU0b SGJDMeymink9bS9jfHyWrQnDDYrAJ68= X-Google-Smtp-Source: ABdhPJyyWhg/HZloV77tc/5SwAYHguc5UciRxuk4OrFHLyBPk1weM70XMcLYipySphGQrca0OnCZSQ== X-Received: by 2002:a62:3343:: with SMTP id z64mr1187982pfz.55.1589503199243; Thu, 14 May 2020 17:39:59 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id 138sm334556pfz.31.2020.05.14.17.39.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 May 2020 17:39:58 -0700 (PDT) Date: Thu, 14 May 2020 17:39:57 -0700 From: Matthias Kaehlcke To: Sharat Masetty Cc: freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, dri-devel@freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, jcrouse@codeaurora.org, georgi.djakov@linaro.org Subject: Re: [PATCH 4/6] drm: msm: a6xx: send opp instead of a frequency Message-ID: <20200515003957.GV4525@google.com> References: <1589453659-27581-1-git-send-email-smasetty@codeaurora.org> <1589453659-27581-5-git-send-email-smasetty@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1589453659-27581-5-git-send-email-smasetty@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, May 14, 2020 at 04:24:17PM +0530, Sharat Masetty wrote: > This patch changes the plumbing to send the devfreq recommended opp rather > than the frequency. Also consolidate and rearrange the code in a6xx to set > the GPU frequency and the icc vote in preparation for the upcoming > changes for GPU->DDR scaling votes. Could this be relatively easily split in two patches, one passing the OPP instead of the frequency, and another doing the consolidation? It typically makes reviewing easier when logically unrelated changes are done in separate patches. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BD64C433E2 for ; Fri, 15 May 2020 00:40:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A73E20709 for ; Fri, 15 May 2020 00:40:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ncWP6c8T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A73E20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 17F6D6E3C4; Fri, 15 May 2020 00:40:01 +0000 (UTC) Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id D524E6E3C4 for ; Fri, 15 May 2020 00:39:59 +0000 (UTC) Received: by mail-pg1-x544.google.com with SMTP id u5so172035pgn.5 for ; Thu, 14 May 2020 17:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MxFx2v3CXXJI2uqpzJc0nTIbU803tm+QFkEcg6RoGME=; b=ncWP6c8T/qeB5mTi8dmQ/2f++LBk5CizP09+SlPJnyCzgNs/XM3OV3LABFolMAuaaE UYHUIc3yE2lEXImqHTT1olFACAUL2RuRf0qtmuTLimsMw3ZEFjzxm4slAwvUIDb2cFT/ wcJNyV8sDtE3sXgsivVXiTYvixU3wl/p0/67k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MxFx2v3CXXJI2uqpzJc0nTIbU803tm+QFkEcg6RoGME=; b=OLAwqBNXhUxgiCKxR8nEQf4OmXF7RneSaDwjMh2mdU5eT5tDZ2z3/gFKrkJJ3IpFRO 2BsnAvvkUXI0nQg+rmt9hydESZMbLBszUSD/iO/yZHSlY7wNPycloue6p5boCoc5nC9z QXDsa7rCC2pTTVNdsq54sI039/DJF6SmkQGWfme9hUoimKZuK9SibRo2oEGg/moo7qZL 0axX618WCqZhYHNbq4q4TmH6fFnDbtKk9hSIweI+1B8goEbOnG9ca+pA35hhLjLnHP7R jhOs0/lS2JZbG9qvskTthxB5Do4qhihM3MlpmkT3jkA2b7+wtSbHqp3R0HC6z9CAEury wJeg== X-Gm-Message-State: AOAM531DfAWJWgozJyOpsujj2wA7fKz4Galc5a9pra6/Ax71CTo3Vevb ed0hGRhpK39q5ltxD2BB/ABDlA== X-Google-Smtp-Source: ABdhPJyyWhg/HZloV77tc/5SwAYHguc5UciRxuk4OrFHLyBPk1weM70XMcLYipySphGQrca0OnCZSQ== X-Received: by 2002:a62:3343:: with SMTP id z64mr1187982pfz.55.1589503199243; Thu, 14 May 2020 17:39:59 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id 138sm334556pfz.31.2020.05.14.17.39.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 May 2020 17:39:58 -0700 (PDT) Date: Thu, 14 May 2020 17:39:57 -0700 From: Matthias Kaehlcke To: Sharat Masetty Subject: Re: [PATCH 4/6] drm: msm: a6xx: send opp instead of a frequency Message-ID: <20200515003957.GV4525@google.com> References: <1589453659-27581-1-git-send-email-smasetty@codeaurora.org> <1589453659-27581-5-git-send-email-smasetty@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1589453659-27581-5-git-send-email-smasetty@codeaurora.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@freedesktop.org, freedreno@lists.freedesktop.org, georgi.djakov@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, May 14, 2020 at 04:24:17PM +0530, Sharat Masetty wrote: > This patch changes the plumbing to send the devfreq recommended opp rather > than the frequency. Also consolidate and rearrange the code in a6xx to set > the GPU frequency and the icc vote in preparation for the upcoming > changes for GPU->DDR scaling votes. Could this be relatively easily split in two patches, one passing the OPP instead of the frequency, and another doing the consolidation? It typically makes reviewing easier when logically unrelated changes are done in separate patches. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel