All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/ide/ahci: Log lost IRQs
Date: Fri, 15 May 2020 12:05:20 +0200	[thread overview]
Message-ID: <20200515100520.GF93011@linux.fritz.box> (raw)
In-Reply-To: <6139ac24-dc2a-d4e0-7f88-eeb72a05490d@redhat.com>

Am 14.05.2020 um 22:20 hat John Snow geschrieben:
> 
> 
> On 5/4/20 5:48 AM, Philippe Mathieu-Daudé wrote:
> > One might find interesting to look at AHCI IRQs.
> > 
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >  hw/ide/ahci.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> > index 13d91e109a..fc82cbd5f1 100644
> > --- a/hw/ide/ahci.c
> > +++ b/hw/ide/ahci.c
> > @@ -1509,6 +1509,7 @@ static void ahci_cmd_done(IDEDMA *dma)
> >  
> >  static void ahci_irq_set(void *opaque, int n, int level)
> >  {
> > +    qemu_log_mask(LOG_UNIMP, "ahci: IRQ#%d level:%d\n", n, level);
> >  }
> >  
> >  static const IDEDMAOps ahci_dma_ops = {
> > 
> 
> Reviewed-by: John Snow <jsnow@redhat.com>
> 
> Sorry, just drowning in backlog. Thanks for the ping on IRC.
> 
> Acked-by: John Snow <jsnow@redhat.com>
> 
> ^ Feel free to take through trivial tree.

I'll take it through the block tree then.

Kevin



      reply	other threads:[~2020-05-15 10:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04  9:48 [PATCH] hw/ide/ahci: Log lost IRQs Philippe Mathieu-Daudé
2020-05-12  6:53 ` Philippe Mathieu-Daudé
2020-05-14 20:20 ` John Snow
2020-05-15 10:05   ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200515100520.GF93011@linux.fritz.box \
    --to=kwolf@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.