From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C6D1C433E3 for ; Fri, 15 May 2020 10:28:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54EEF20758 for ; Fri, 15 May 2020 10:28:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CXEYEEqc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728139AbgEOK24 (ORCPT ); Fri, 15 May 2020 06:28:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728190AbgEOK2y (ORCPT ); Fri, 15 May 2020 06:28:54 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 317EFC05BD0D for ; Fri, 15 May 2020 03:28:53 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id i15so2876777wrx.10 for ; Fri, 15 May 2020 03:28:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=xpA4uoROidais1iNpnkNzF9vq5C6X235V0wZ35uHdEI=; b=CXEYEEqcvkty6QbjHU8IC9+4m00nYkEX+SNv9RcxVR5/SFF+YXke+BvJ6oVoOabQdZ zNfD971SDDWzHM8i6tMy7Ide1qyTwoimukooCDQG010KoMF5GvG2qiwCDrJzTOJ/ST1J prbm8Ynnzt8vqseddRKMMZbinTDqtdohbq4rUwGgpc6TUwZFSsD+mzok7VbjTnaA+NPE 7SxmiCj38OP6B2dbzDqJc0ZqywE58/rTxvAnd+HOSQ/e7PuK5vIet7N3V1P5fBuJTFqx 810hQ3AwpINxJ1EOF2q5K54I50ZckVeqd/fsfxWyzTJVbsxau3rGuKWQxQF/tGuS+Hp3 egGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=xpA4uoROidais1iNpnkNzF9vq5C6X235V0wZ35uHdEI=; b=p5Re8W1TOOzUdKu61BgDxyOLdXE2rVZ2Zc/QY3CQ0seVhdrBx9SpZmW0e+bYdBpqM8 NZqOvND3wFQ05SH1+JFQzLobTkAE14O0h89+HgS0ODh5+h+dXUXOrfheYaBnGDyTSKwd 21VC2aRGt74By5zon3cFj1KR5T3UJfYBbh9pTf0f4VJAj3bBQl/y8oSkA7ufq/LUdtYt Rkj1inkjy1BTUMdjXoIzAlYYLZJ9HlK+vWRbbBLxr/Y4InU7XKz6a1f8GHQpGLHywDvA TESvRMgb7ygLShd0Kk0z/Aq7z5midhJFBQcOLo/GkWyRVJiyvOtA9z6PlkPR0HvvozY/ wpng== X-Gm-Message-State: AOAM532TOqKIGvc9yRkA9y3Gk8DH/+MKth+Pg37ojmPTi3Sm/NNpyos4 YH0op//HWjT0+CzqQz/yPe0IAp1f7jM= X-Google-Smtp-Source: ABdhPJxTv+9YnkgoMuYBGuW3wQDNEiVk0bNzw09WJsjwgIV7JP0J+YUnU47dJL1yqsEb92xCMVOBXw== X-Received: by 2002:adf:a1d7:: with SMTP id v23mr3514719wrv.155.1589538531500; Fri, 15 May 2020 03:28:51 -0700 (PDT) Received: from dell ([2.31.163.63]) by smtp.gmail.com with ESMTPSA id j16sm2878629wru.13.2020.05.15.03.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 03:28:50 -0700 (PDT) Date: Fri, 15 May 2020 11:28:48 +0100 From: Lee Jones To: Michael Walle Cc: Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 03/16] mfd: mfd-core: match device tree node against reg property Message-ID: <20200515102848.GH271301@dell> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-4-michael@walle.cc> <67e90dafd67c285158c2c6f67f92edb7@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <67e90dafd67c285158c2c6f67f92edb7@walle.cc> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, 30 Apr 2020, Michael Walle wrote: > Hi Lee, > > Am 2020-04-23 19:45, schrieb Michael Walle: > > There might be multiple children with the device tree compatible, for > > example if a MFD has multiple instances of the same function. In this > > case only the first is matched and the other children get a wrong > > of_node reference. > > Add a new option to match also against the unit address of the child > > node. Additonally, a new helper OF_MFD_CELL_REG is added. > > > Do you think this is feasible? I guess this is the biggest uncertainty > for me at the moment in this patch series. I think it sounds fine in principle. So long as it doesn't change the existing behaviour when of_reg isn't set. > > Signed-off-by: Michael Walle > > --- > > drivers/mfd/mfd-core.c | 29 ++++++++++++++++++++--------- > > include/linux/mfd/core.h | 26 ++++++++++++++++++++------ > > 2 files changed, 40 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c > > index e735565969b3..4ecb376338f7 100644 > > --- a/drivers/mfd/mfd-core.c > > +++ b/drivers/mfd/mfd-core.c > > @@ -117,6 +117,7 @@ static int mfd_add_device(struct device *parent, int > > id, > > struct device_node *np = NULL; > > int ret = -ENOMEM; > > int platform_id; > > + u32 of_reg; > > int r; > > > > if (id == PLATFORM_DEVID_AUTO) > > @@ -151,16 +152,26 @@ static int mfd_add_device(struct device *parent, > > int id, > > > > if (parent->of_node && cell->of_compatible) { > > for_each_child_of_node(parent->of_node, np) { > > - if (of_device_is_compatible(np, cell->of_compatible)) { > > - if (!of_device_is_available(np)) { > > - /* Ignore disabled devices error free */ > > - ret = 0; > > - goto fail_alias; > > - } > > - pdev->dev.of_node = np; > > - pdev->dev.fwnode = &np->fwnode; > > - break; > > + if (!of_device_is_compatible(np, cell->of_compatible)) > > + continue; > > + > > + /* also match the unit address if set */ Please use correct grammar in comments (leaving off the full-stop). > > + if (cell->of_reg & MFD_OF_REG_VALID) { > > + if (of_property_read_u32(np, "reg", &of_reg)) > > + continue; > > + if ((cell->of_reg & MFD_OF_REG_MASK) != of_reg) > > + continue; > > } > > + > > + if (!of_device_is_available(np)) { > > + /* Ignore disabled devices error free */ > > + ret = 0; > > + goto fail_alias; > > + } > > + > > + pdev->dev.of_node = np; > > + pdev->dev.fwnode = &np->fwnode; > > + break; > > } > > } > > > > diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h > > index d01d1299e49d..c2c0ad6b14f3 100644 > > --- a/include/linux/mfd/core.h > > +++ b/include/linux/mfd/core.h > > @@ -13,8 +13,11 @@ > > #include > > > > #define MFD_RES_SIZE(arr) (sizeof(arr) / sizeof(struct resource)) > > +#define MFD_OF_REG_VALID BIT(31) What about 64bit platforms? > > +#define MFD_OF_REG_MASK GENMASK(30, 0) > > > > -#define MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, _compat, > > _match)\ > > +#define MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, _compat, \ > > + _of_reg, _match) \ > > { \ > > .name = (_name), \ > > .resources = (_res), \ > > @@ -22,24 +25,32 @@ > > .platform_data = (_pdata), \ > > .pdata_size = (_pdsize), \ > > .of_compatible = (_compat), \ > > + .of_reg = (_of_reg), \ > > .acpi_match = (_match), \ > > .id = (_id), \ > > } > > > > +#define OF_MFD_CELL_REG(_name, _res, _pdata, _pdsize, _id, _compat, \ > > + _of_reg) \ > > + MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, _compat, \ > > + ((_of_reg) | MFD_OF_REG_VALID), NULL) \ > > + > > #define OF_MFD_CELL(_name, _res, _pdata, _pdsize,_id, _compat) \ > > - MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, _compat, NULL) \ > > + MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, _compat, \ > > + 0, NULL) \ > > > > #define ACPI_MFD_CELL(_name, _res, _pdata, _pdsize, _id, _match) \ > > - MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, _match) \ > > + MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, 0, \ > > + _match) \ > > > > #define MFD_CELL_BASIC(_name, _res, _pdata, _pdsize, _id) \ > > - MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, NULL) \ > > + MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, 0, NULL) \ > > > > #define MFD_CELL_RES(_name, _res) \ > > - MFD_CELL_ALL(_name, _res, NULL, 0, 0, NULL, NULL) \ > > + MFD_CELL_ALL(_name, _res, NULL, 0, 0, NULL, 0, NULL) \ > > > > #define MFD_CELL_NAME(_name) \ > > - MFD_CELL_ALL(_name, NULL, NULL, 0, 0, NULL, NULL) \ > > + MFD_CELL_ALL(_name, NULL, NULL, 0, 0, NULL, 0, NULL) \ > > > > struct irq_domain; > > struct property_entry; > > @@ -78,6 +89,9 @@ struct mfd_cell { > > */ > > const char *of_compatible; > > > > + /* matching the reg property if set */ Proper grammar please. "OF unit address for device matching" > > + unsigned int of_reg; > > + > > /* Matches ACPI */ > > const struct mfd_cell_acpi_match *acpi_match; -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 03/16] mfd: mfd-core: match device tree node against reg property Date: Fri, 15 May 2020 11:28:48 +0100 Message-ID: <20200515102848.GH271301@dell> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-4-michael@walle.cc> <67e90dafd67c285158c2c6f67f92edb7@walle.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <67e90dafd67c285158c2c6f67f92edb7-QKn5cuLxLXY@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michael Walle Cc: Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-hwmon-u79uwXL29TaqPxH82wqD4g@public.gmane.org List-Id: linux-pwm@vger.kernel.org On Thu, 30 Apr 2020, Michael Walle wrote: > Hi Lee, > > Am 2020-04-23 19:45, schrieb Michael Walle: > > There might be multiple children with the device tree compatible, for > > example if a MFD has multiple instances of the same function. In this > > case only the first is matched and the other children get a wrong > > of_node reference. > > Add a new option to match also against the unit address of the child > > node. Additonally, a new helper OF_MFD_CELL_REG is added. > > > Do you think this is feasible? I guess this is the biggest uncertainty > for me at the moment in this patch series. I think it sounds fine in principle. So long as it doesn't change the existing behaviour when of_reg isn't set. > > Signed-off-by: Michael Walle > > --- > > drivers/mfd/mfd-core.c | 29 ++++++++++++++++++++--------- > > include/linux/mfd/core.h | 26 ++++++++++++++++++++------ > > 2 files changed, 40 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c > > index e735565969b3..4ecb376338f7 100644 > > --- a/drivers/mfd/mfd-core.c > > +++ b/drivers/mfd/mfd-core.c > > @@ -117,6 +117,7 @@ static int mfd_add_device(struct device *parent, int > > id, > > struct device_node *np = NULL; > > int ret = -ENOMEM; > > int platform_id; > > + u32 of_reg; > > int r; > > > > if (id == PLATFORM_DEVID_AUTO) > > @@ -151,16 +152,26 @@ static int mfd_add_device(struct device *parent, > > int id, > > > > if (parent->of_node && cell->of_compatible) { > > for_each_child_of_node(parent->of_node, np) { > > - if (of_device_is_compatible(np, cell->of_compatible)) { > > - if (!of_device_is_available(np)) { > > - /* Ignore disabled devices error free */ > > - ret = 0; > > - goto fail_alias; > > - } > > - pdev->dev.of_node = np; > > - pdev->dev.fwnode = &np->fwnode; > > - break; > > + if (!of_device_is_compatible(np, cell->of_compatible)) > > + continue; > > + > > + /* also match the unit address if set */ Please use correct grammar in comments (leaving off the full-stop). > > + if (cell->of_reg & MFD_OF_REG_VALID) { > > + if (of_property_read_u32(np, "reg", &of_reg)) > > + continue; > > + if ((cell->of_reg & MFD_OF_REG_MASK) != of_reg) > > + continue; > > } > > + > > + if (!of_device_is_available(np)) { > > + /* Ignore disabled devices error free */ > > + ret = 0; > > + goto fail_alias; > > + } > > + > > + pdev->dev.of_node = np; > > + pdev->dev.fwnode = &np->fwnode; > > + break; > > } > > } > > > > diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h > > index d01d1299e49d..c2c0ad6b14f3 100644 > > --- a/include/linux/mfd/core.h > > +++ b/include/linux/mfd/core.h > > @@ -13,8 +13,11 @@ > > #include > > > > #define MFD_RES_SIZE(arr) (sizeof(arr) / sizeof(struct resource)) > > +#define MFD_OF_REG_VALID BIT(31) What about 64bit platforms? > > +#define MFD_OF_REG_MASK GENMASK(30, 0) > > > > -#define MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, _compat, > > _match)\ > > +#define MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, _compat, \ > > + _of_reg, _match) \ > > { \ > > .name = (_name), \ > > .resources = (_res), \ > > @@ -22,24 +25,32 @@ > > .platform_data = (_pdata), \ > > .pdata_size = (_pdsize), \ > > .of_compatible = (_compat), \ > > + .of_reg = (_of_reg), \ > > .acpi_match = (_match), \ > > .id = (_id), \ > > } > > > > +#define OF_MFD_CELL_REG(_name, _res, _pdata, _pdsize, _id, _compat, \ > > + _of_reg) \ > > + MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, _compat, \ > > + ((_of_reg) | MFD_OF_REG_VALID), NULL) \ > > + > > #define OF_MFD_CELL(_name, _res, _pdata, _pdsize,_id, _compat) \ > > - MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, _compat, NULL) \ > > + MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, _compat, \ > > + 0, NULL) \ > > > > #define ACPI_MFD_CELL(_name, _res, _pdata, _pdsize, _id, _match) \ > > - MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, _match) \ > > + MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, 0, \ > > + _match) \ > > > > #define MFD_CELL_BASIC(_name, _res, _pdata, _pdsize, _id) \ > > - MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, NULL) \ > > + MFD_CELL_ALL(_name, _res, _pdata, _pdsize, _id, NULL, 0, NULL) \ > > > > #define MFD_CELL_RES(_name, _res) \ > > - MFD_CELL_ALL(_name, _res, NULL, 0, 0, NULL, NULL) \ > > + MFD_CELL_ALL(_name, _res, NULL, 0, 0, NULL, 0, NULL) \ > > > > #define MFD_CELL_NAME(_name) \ > > - MFD_CELL_ALL(_name, NULL, NULL, 0, 0, NULL, NULL) \ > > + MFD_CELL_ALL(_name, NULL, NULL, 0, 0, NULL, 0, NULL) \ > > > > struct irq_domain; > > struct property_entry; > > @@ -78,6 +89,9 @@ struct mfd_cell { > > */ > > const char *of_compatible; > > > > + /* matching the reg property if set */ Proper grammar please. "OF unit address for device matching" > > + unsigned int of_reg; > > + > > /* Matches ACPI */ > > const struct mfd_cell_acpi_match *acpi_match; -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB0BC433E0 for ; Fri, 15 May 2020 10:29:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC17A206B6 for ; Fri, 15 May 2020 10:29:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VOjhhH5k"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CXEYEEqc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC17A206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8f2udnvdRnKeWn1IhUsUIYhdxCylvAYR022XKlstvB8=; b=VOjhhH5k0Y2xno ddXJ7OONiq5F8Ch9bDcUU7E4/XUdTxv0Z6EzSqiCet/luJKa3uKA2n79B8dQktjMB7rKNw2qKe4ug XVUknKdN7AKGKINbOx3REHtZU0p90L+ww9aGk2KdCELUW6oVTCC/mqcMLRYw8zM2OFvlokhVHZkL+ Yb43GcDTUgpop5+kN1d+S5vPsH6hI0Sg1qB9TduwjrttaYT/znjlryos1qpO3uI8mAGDdFfR9/KS4 xV+ASMyz+DA1yh+t3FV/MTSI77oe78u/bci1M4LKspFFitQmqy7qe2TrrZ++KhsyASwKM6GV7pxPU lKKcmZftuiavod5yo6pA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZXaQ-00035D-S9; Fri, 15 May 2020 10:29:02 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZXaH-00032u-Tl for linux-arm-kernel@lists.infradead.org; Fri, 15 May 2020 10:29:01 +0000 Received: by mail-wr1-x441.google.com with SMTP id j5so2949996wrq.2 for ; Fri, 15 May 2020 03:28:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=xpA4uoROidais1iNpnkNzF9vq5C6X235V0wZ35uHdEI=; b=CXEYEEqcvkty6QbjHU8IC9+4m00nYkEX+SNv9RcxVR5/SFF+YXke+BvJ6oVoOabQdZ zNfD971SDDWzHM8i6tMy7Ide1qyTwoimukooCDQG010KoMF5GvG2qiwCDrJzTOJ/ST1J prbm8Ynnzt8vqseddRKMMZbinTDqtdohbq4rUwGgpc6TUwZFSsD+mzok7VbjTnaA+NPE 7SxmiCj38OP6B2dbzDqJc0ZqywE58/rTxvAnd+HOSQ/e7PuK5vIet7N3V1P5fBuJTFqx 810hQ3AwpINxJ1EOF2q5K54I50ZckVeqd/fsfxWyzTJVbsxau3rGuKWQxQF/tGuS+Hp3 egGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=xpA4uoROidais1iNpnkNzF9vq5C6X235V0wZ35uHdEI=; b=PGM5ajjzTSlZpMwx78wHffzcz1xrXJf/HZ21BFyU1w5LWwepq3Q+ou5yVKn80ZePwQ qQkkezpPNl+wrqbJL9kfsF5qmuGimK8lqG+rjiFgE6lVQ1LEB8nktSUXegTdTXyrbi2f MAHY65Xio4cXtNVkrX0KLv5dOq6J5mb902eQK1DyJ9MYi2D9RAkNpuejKD53Bsxj0y/X sHQXgNHCbuCjgtWOcmcnczCchqiEoPzt/AELzDObN7lh7guxHDctZkBt5QFcMLyp8ije BCOPOrUR8FDA22ctzGICHpDeT4pj/SFUfPxUVFyGKBdqflz7PVXu95QFB2T4h7NZgaK+ MWyQ== X-Gm-Message-State: AOAM531HsWrwn62+3OX4FYlRnFRmFLk9PP/mwmVAEF+RvBRtflewRmSU 4f0VhQHNL8BZAA+fwnOtcmo+kg== X-Google-Smtp-Source: ABdhPJxTv+9YnkgoMuYBGuW3wQDNEiVk0bNzw09WJsjwgIV7JP0J+YUnU47dJL1yqsEb92xCMVOBXw== X-Received: by 2002:adf:a1d7:: with SMTP id v23mr3514719wrv.155.1589538531500; Fri, 15 May 2020 03:28:51 -0700 (PDT) Received: from dell ([2.31.163.63]) by smtp.gmail.com with ESMTPSA id j16sm2878629wru.13.2020.05.15.03.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2020 03:28:50 -0700 (PDT) Date: Fri, 15 May 2020 11:28:48 +0100 From: Lee Jones To: Michael Walle Subject: Re: [PATCH v3 03/16] mfd: mfd-core: match device tree node against reg property Message-ID: <20200515102848.GH271301@dell> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-4-michael@walle.cc> <67e90dafd67c285158c2c6f67f92edb7@walle.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <67e90dafd67c285158c2c6f67f92edb7@walle.cc> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200515_032854_029912_E871F45F X-CRM114-Status: GOOD ( 25.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Linus Walleij , Thierry Reding , linux-watchdog@vger.kernel.org, Andy Shevchenko , Marc Zyngier , Bartosz Golaszewski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Guenter Roeck , devicetree@vger.kernel.org, Jean Delvare , Jason Cooper , linux-gpio@vger.kernel.org, Rob Herring , Thomas Gleixner , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Li Yang , Mark Brown , Shawn Guo Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAzMCBBcHIgMjAyMCwgTWljaGFlbCBXYWxsZSB3cm90ZToKCj4gSGkgTGVlLAo+IAo+ IEFtIDIwMjAtMDQtMjMgMTk6NDUsIHNjaHJpZWIgTWljaGFlbCBXYWxsZToKPiA+IFRoZXJlIG1p Z2h0IGJlIG11bHRpcGxlIGNoaWxkcmVuIHdpdGggdGhlIGRldmljZSB0cmVlIGNvbXBhdGlibGUs IGZvcgo+ID4gZXhhbXBsZSBpZiBhIE1GRCBoYXMgbXVsdGlwbGUgaW5zdGFuY2VzIG9mIHRoZSBz YW1lIGZ1bmN0aW9uLiBJbiB0aGlzCj4gPiBjYXNlIG9ubHkgdGhlIGZpcnN0IGlzIG1hdGNoZWQg YW5kIHRoZSBvdGhlciBjaGlsZHJlbiBnZXQgYSB3cm9uZwo+ID4gb2Zfbm9kZSByZWZlcmVuY2Uu Cj4gPiBBZGQgYSBuZXcgb3B0aW9uIHRvIG1hdGNoIGFsc28gYWdhaW5zdCB0aGUgdW5pdCBhZGRy ZXNzIG9mIHRoZSBjaGlsZAo+ID4gbm9kZS4gQWRkaXRvbmFsbHksIGEgbmV3IGhlbHBlciBPRl9N RkRfQ0VMTF9SRUcgaXMgYWRkZWQuCj4gCj4gCj4gRG8geW91IHRoaW5rIHRoaXMgaXMgZmVhc2li bGU/IEkgZ3Vlc3MgdGhpcyBpcyB0aGUgYmlnZ2VzdCB1bmNlcnRhaW50eQo+IGZvciBtZSBhdCB0 aGUgbW9tZW50IGluIHRoaXMgcGF0Y2ggc2VyaWVzLgoKSSB0aGluayBpdCBzb3VuZHMgZmluZSBp biBwcmluY2lwbGUuICBTbyBsb25nIGFzIGl0IGRvZXNuJ3QgY2hhbmdlIHRoZQpleGlzdGluZyBi ZWhhdmlvdXIgd2hlbiBvZl9yZWcgaXNuJ3Qgc2V0LgoKPiA+IFNpZ25lZC1vZmYtYnk6IE1pY2hh ZWwgV2FsbGUgPG1pY2hhZWxAd2FsbGUuY2M+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL21mZC9tZmQt Y29yZS5jICAgfCAyOSArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLQo+ID4gIGluY2x1ZGUv bGludXgvbWZkL2NvcmUuaCB8IDI2ICsrKysrKysrKysrKysrKysrKysrLS0tLS0tCj4gPiAgMiBm aWxlcyBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKPiA+IAo+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL21mZC1jb3JlLmMgYi9kcml2ZXJzL21mZC9tZmQtY29y ZS5jCj4gPiBpbmRleCBlNzM1NTY1OTY5YjMuLjRlY2IzNzYzMzhmNyAxMDA2NDQKPiA+IC0tLSBh L2RyaXZlcnMvbWZkL21mZC1jb3JlLmMKPiA+ICsrKyBiL2RyaXZlcnMvbWZkL21mZC1jb3JlLmMK PiA+IEBAIC0xMTcsNiArMTE3LDcgQEAgc3RhdGljIGludCBtZmRfYWRkX2RldmljZShzdHJ1Y3Qg ZGV2aWNlICpwYXJlbnQsIGludAo+ID4gaWQsCj4gPiAgCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbnAg PSBOVUxMOwo+ID4gIAlpbnQgcmV0ID0gLUVOT01FTTsKPiA+ICAJaW50IHBsYXRmb3JtX2lkOwo+ ID4gKwl1MzIgb2ZfcmVnOwo+ID4gIAlpbnQgcjsKPiA+IAo+ID4gIAlpZiAoaWQgPT0gUExBVEZP Uk1fREVWSURfQVVUTykKPiA+IEBAIC0xNTEsMTYgKzE1MiwyNiBAQCBzdGF0aWMgaW50IG1mZF9h ZGRfZGV2aWNlKHN0cnVjdCBkZXZpY2UgKnBhcmVudCwKPiA+IGludCBpZCwKPiA+IAo+ID4gIAlp ZiAocGFyZW50LT5vZl9ub2RlICYmIGNlbGwtPm9mX2NvbXBhdGlibGUpIHsKPiA+ICAJCWZvcl9l YWNoX2NoaWxkX29mX25vZGUocGFyZW50LT5vZl9ub2RlLCBucCkgewo+ID4gLQkJCWlmIChvZl9k ZXZpY2VfaXNfY29tcGF0aWJsZShucCwgY2VsbC0+b2ZfY29tcGF0aWJsZSkpIHsKPiA+IC0JCQkJ aWYgKCFvZl9kZXZpY2VfaXNfYXZhaWxhYmxlKG5wKSkgewo+ID4gLQkJCQkJLyogSWdub3JlIGRp c2FibGVkIGRldmljZXMgZXJyb3IgZnJlZSAqLwo+ID4gLQkJCQkJcmV0ID0gMDsKPiA+IC0JCQkJ CWdvdG8gZmFpbF9hbGlhczsKPiA+IC0JCQkJfQo+ID4gLQkJCQlwZGV2LT5kZXYub2Zfbm9kZSA9 IG5wOwo+ID4gLQkJCQlwZGV2LT5kZXYuZndub2RlID0gJm5wLT5md25vZGU7Cj4gPiAtCQkJCWJy ZWFrOwo+ID4gKwkJCWlmICghb2ZfZGV2aWNlX2lzX2NvbXBhdGlibGUobnAsIGNlbGwtPm9mX2Nv bXBhdGlibGUpKQo+ID4gKwkJCQljb250aW51ZTsKPiA+ICsKPiA+ICsJCQkvKiBhbHNvIG1hdGNo IHRoZSB1bml0IGFkZHJlc3MgaWYgc2V0ICovCgpQbGVhc2UgdXNlIGNvcnJlY3QgZ3JhbW1hciBp biBjb21tZW50cyAobGVhdmluZyBvZmYgdGhlIGZ1bGwtc3RvcCkuCgo+ID4gKwkJCWlmIChjZWxs LT5vZl9yZWcgJiBNRkRfT0ZfUkVHX1ZBTElEKSB7Cj4gPiArCQkJCWlmIChvZl9wcm9wZXJ0eV9y ZWFkX3UzMihucCwgInJlZyIsICZvZl9yZWcpKQo+ID4gKwkJCQkJY29udGludWU7Cj4gPiArCQkJ CWlmICgoY2VsbC0+b2ZfcmVnICYgTUZEX09GX1JFR19NQVNLKSAhPSBvZl9yZWcpCj4gPiArCQkJ CQljb250aW51ZTsKPiA+ICAJCQl9Cj4gPiArCj4gPiArCQkJaWYgKCFvZl9kZXZpY2VfaXNfYXZh aWxhYmxlKG5wKSkgewo+ID4gKwkJCQkvKiBJZ25vcmUgZGlzYWJsZWQgZGV2aWNlcyBlcnJvciBm cmVlICovCj4gPiArCQkJCXJldCA9IDA7Cj4gPiArCQkJCWdvdG8gZmFpbF9hbGlhczsKPiA+ICsJ CQl9Cj4gPiArCj4gPiArCQkJcGRldi0+ZGV2Lm9mX25vZGUgPSBucDsKPiA+ICsJCQlwZGV2LT5k ZXYuZndub2RlID0gJm5wLT5md25vZGU7Cj4gPiArCQkJYnJlYWs7Cj4gPiAgCQl9Cj4gPiAgCX0K PiA+IAo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvbWZkL2NvcmUuaCBiL2luY2x1ZGUv bGludXgvbWZkL2NvcmUuaAo+ID4gaW5kZXggZDAxZDEyOTllNDlkLi5jMmMwYWQ2YjE0ZjMgMTAw NjQ0Cj4gPiAtLS0gYS9pbmNsdWRlL2xpbnV4L21mZC9jb3JlLmgKPiA+ICsrKyBiL2luY2x1ZGUv bGludXgvbWZkL2NvcmUuaAo+ID4gQEAgLTEzLDggKzEzLDExIEBACj4gPiAgI2luY2x1ZGUgPGxp bnV4L3BsYXRmb3JtX2RldmljZS5oPgo+ID4gCj4gPiAgI2RlZmluZSBNRkRfUkVTX1NJWkUoYXJy KSAoc2l6ZW9mKGFycikgLyBzaXplb2Yoc3RydWN0IHJlc291cmNlKSkKPiA+ICsjZGVmaW5lIE1G RF9PRl9SRUdfVkFMSUQJQklUKDMxKQoKV2hhdCBhYm91dCA2NGJpdCBwbGF0Zm9ybXM/Cgo+ID4g KyNkZWZpbmUgTUZEX09GX1JFR19NQVNLCQlHRU5NQVNLKDMwLCAwKQo+ID4gCj4gPiAtI2RlZmlu ZSBNRkRfQ0VMTF9BTEwoX25hbWUsIF9yZXMsIF9wZGF0YSwgX3Bkc2l6ZSwgX2lkLCBfY29tcGF0 LAo+ID4gX21hdGNoKVwKPiA+ICsjZGVmaW5lIE1GRF9DRUxMX0FMTChfbmFtZSwgX3JlcywgX3Bk YXRhLCBfcGRzaXplLCBfaWQsIF9jb21wYXQsCVwKPiA+ICsJCSAgICAgX29mX3JlZywgX21hdGNo KQkJCQkJXAo+ID4gIAl7CQkJCQkJCQlcCj4gPiAgCQkubmFtZSA9IChfbmFtZSksCQkJCQlcCj4g PiAgCQkucmVzb3VyY2VzID0gKF9yZXMpLAkJCQkJXAo+ID4gQEAgLTIyLDI0ICsyNSwzMiBAQAo+ ID4gIAkJLnBsYXRmb3JtX2RhdGEgPSAoX3BkYXRhKSwJCQkJXAo+ID4gIAkJLnBkYXRhX3NpemUg PSAoX3Bkc2l6ZSksCQkJCVwKPiA+ICAJCS5vZl9jb21wYXRpYmxlID0gKF9jb21wYXQpLAkJCQlc Cj4gPiArCQkub2ZfcmVnID0gKF9vZl9yZWcpLAkJCQkJXAo+ID4gIAkJLmFjcGlfbWF0Y2ggPSAo X21hdGNoKSwJCQkJCVwKPiA+ICAJCS5pZCA9IChfaWQpLAkJCQkJCVwKPiA+ICAJfQo+ID4gCj4g PiArI2RlZmluZSBPRl9NRkRfQ0VMTF9SRUcoX25hbWUsIF9yZXMsIF9wZGF0YSwgX3Bkc2l6ZSwg X2lkLCBfY29tcGF0LAlcCj4gPiArCQkJX29mX3JlZykJCQkJCVwKPiA+ICsJTUZEX0NFTExfQUxM KF9uYW1lLCBfcmVzLCBfcGRhdGEsIF9wZHNpemUsIF9pZCwgX2NvbXBhdCwJXAo+ID4gKwkJICAg ICAoKF9vZl9yZWcpIHwgTUZEX09GX1JFR19WQUxJRCksIE5VTEwpCQlcCj4gPiArCj4gPiAgI2Rl ZmluZSBPRl9NRkRfQ0VMTChfbmFtZSwgX3JlcywgX3BkYXRhLCBfcGRzaXplLF9pZCwgX2NvbXBh dCkJCVwKPiA+IC0JTUZEX0NFTExfQUxMKF9uYW1lLCBfcmVzLCBfcGRhdGEsIF9wZHNpemUsIF9p ZCwgX2NvbXBhdCwgTlVMTCkJXAo+ID4gKwlNRkRfQ0VMTF9BTEwoX25hbWUsIF9yZXMsIF9wZGF0 YSwgX3Bkc2l6ZSwgX2lkLCBfY29tcGF0LAlcCj4gPiArCQkgICAgIDAsIE5VTEwpCQkJCQkJXAo+ ID4gCj4gPiAgI2RlZmluZSBBQ1BJX01GRF9DRUxMKF9uYW1lLCBfcmVzLCBfcGRhdGEsIF9wZHNp emUsIF9pZCwgX21hdGNoKQlcCj4gPiAtCU1GRF9DRUxMX0FMTChfbmFtZSwgX3JlcywgX3BkYXRh LCBfcGRzaXplLCBfaWQsIE5VTEwsIF9tYXRjaCkJXAo+ID4gKwlNRkRfQ0VMTF9BTEwoX25hbWUs IF9yZXMsIF9wZGF0YSwgX3Bkc2l6ZSwgX2lkLCBOVUxMLCAwLAlcCj4gPiArCQkgICAgIF9tYXRj aCkJCQkJCQlcCj4gPiAKPiA+ICAjZGVmaW5lIE1GRF9DRUxMX0JBU0lDKF9uYW1lLCBfcmVzLCBf cGRhdGEsIF9wZHNpemUsIF9pZCkJCVwKPiA+IC0JTUZEX0NFTExfQUxMKF9uYW1lLCBfcmVzLCBf cGRhdGEsIF9wZHNpemUsIF9pZCwgTlVMTCwgTlVMTCkJXAo+ID4gKwlNRkRfQ0VMTF9BTEwoX25h bWUsIF9yZXMsIF9wZGF0YSwgX3Bkc2l6ZSwgX2lkLCBOVUxMLCAwLCBOVUxMKSBcCj4gPiAKPiA+ ICAjZGVmaW5lIE1GRF9DRUxMX1JFUyhfbmFtZSwgX3JlcykJCQkJCVwKPiA+IC0JTUZEX0NFTExf QUxMKF9uYW1lLCBfcmVzLCBOVUxMLCAwLCAwLCBOVUxMLCBOVUxMKQkJXAo+ID4gKwlNRkRfQ0VM TF9BTEwoX25hbWUsIF9yZXMsIE5VTEwsIDAsIDAsIE5VTEwsIDAsIE5VTEwpCQlcCj4gPiAKPiA+ ICAjZGVmaW5lIE1GRF9DRUxMX05BTUUoX25hbWUpCQkJCQkJXAo+ID4gLQlNRkRfQ0VMTF9BTEwo X25hbWUsIE5VTEwsIE5VTEwsIDAsIDAsIE5VTEwsIE5VTEwpCQlcCj4gPiArCU1GRF9DRUxMX0FM TChfbmFtZSwgTlVMTCwgTlVMTCwgMCwgMCwgTlVMTCwgMCwgTlVMTCkJCVwKPiA+IAo+ID4gIHN0 cnVjdCBpcnFfZG9tYWluOwo+ID4gIHN0cnVjdCBwcm9wZXJ0eV9lbnRyeTsKPiA+IEBAIC03OCw2 ICs4OSw5IEBAIHN0cnVjdCBtZmRfY2VsbCB7Cj4gPiAgCSAqLwo+ID4gIAljb25zdCBjaGFyCQkq b2ZfY29tcGF0aWJsZTsKPiA+IAo+ID4gKwkvKiBtYXRjaGluZyB0aGUgcmVnIHByb3BlcnR5IGlm IHNldCAqLwoKUHJvcGVyIGdyYW1tYXIgcGxlYXNlLgoKIk9GIHVuaXQgYWRkcmVzcyBmb3IgZGV2 aWNlIG1hdGNoaW5nIgoKPiA+ICsJdW5zaWduZWQgaW50CQlvZl9yZWc7Cj4gPiArCj4gPiAgCS8q IE1hdGNoZXMgQUNQSSAqLwo+ID4gIAljb25zdCBzdHJ1Y3QgbWZkX2NlbGxfYWNwaV9tYXRjaAkq YWNwaV9tYXRjaDsKCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KTGluYXJvIFNlcnZpY2VzIFRl Y2huaWNhbCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0g U29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==