[PATCH] fscache: fix bugon.cocci warnings

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1640 bytes --]

CC: kbuild-all(a)lists.01.org
TO: David Howells <dhowells@redhat.com>
CC: linux-cachefs(a)redhat.com
CC: linux-kernel(a)vger.kernel.org

From: kbuild test robot <lkp@intel.com>

fs/fscache/read_helper.c:82:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG.
Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)

 Use BUG_ON instead of a if condition followed by BUG.

Semantic patch information:
 This makes an effort to find cases where BUG() follows an if
 condition on an expression and replaces the if condition and BUG()
 with a BUG_ON having the conditional expression of the if statement
 as argument.

Generated by: scripts/coccinelle/misc/bugon.cocci

Fixes: 6c92415d2d3a ("fscache: Add read helper")
Signed-off-by: kbuild test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git fscache-iter
head:   59f33c90ef6c1a75d4af75e5f60d98c0d965b6a2
commit: 6c92415d2d3a9828ec57bd41203f248822ab0b22 [37/61] fscache: Add read helper
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago

Please take the patch only if it's a positive warning. Thanks!

 read_helper.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/fs/fscache/read_helper.c
+++ b/fs/fscache/read_helper.c
@@ -78,8 +78,7 @@ static void fscache_read_copy_to_cache(s
 
 	BUG_ON(work_pending(&req->work));
 	INIT_WORK(&req->work, fscache_do_read_copy_to_cache);
-	if (!queue_work(fscache_op_wq, &req->work))
-		BUG();
+	BUG_ON(!queue_work(fscache_op_wq, &req->work));
 }
 
 /*