From: Christoph Hellwig <hch@lst.de>
To: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Cc: Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>,
axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH] blk-mq: remove the bio argument to ->prepare_request
Date: Sat, 16 May 2020 18:43:30 +0200 [thread overview]
Message-ID: <20200516164330.GA18772@lst.de> (raw)
In-Reply-To: <7d9889de-8078-0ea8-574a-586edf2c4e6b@cloud.ionos.com>
On Sat, May 16, 2020 at 06:36:34PM +0200, Guoqing Jiang wrote:
> Hi Christoph,
>
> On 5/16/20 6:13 PM, Christoph Hellwig wrote:
>> On Sat, May 16, 2020 at 09:12:10AM -0700, Bart Van Assche wrote:
>>> On 2020-05-16 08:40, Christoph Hellwig wrote:
>>>> None of the I/O schedulers actually needs it.
>>> Is the next step perhaps to remove the bio argument from
>>> blk_mq_get_request()? Anyway:
>> Yes, but that is a bigger surgery :)
>
> I had local changes for it which was compiled test, and seems no new caller
> of blk_mq_get_request.
Well, my plan was to sort out the calling conventions for real:
http://git.infradead.org/users/hch/block.git/commitdiff/bce839ff0799e398975c5a5c5a5123402ead6cc8
prev parent reply other threads:[~2020-05-16 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 15:40 [PATCH] blk-mq: remove the bio argument to ->prepare_request Christoph Hellwig
2020-05-16 16:12 ` Bart Van Assche
2020-05-16 16:13 ` Christoph Hellwig
2020-05-16 16:36 ` Guoqing Jiang
2020-05-16 16:43 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200516164330.GA18772@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.