From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3260C433E0 for ; Sat, 16 May 2020 18:17:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C34C5206F4 for ; Sat, 16 May 2020 18:17:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726379AbgEPSRB (ORCPT ); Sat, 16 May 2020 14:17:01 -0400 Received: from verein.lst.de ([213.95.11.211]:33065 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726341AbgEPSRB (ORCPT ); Sat, 16 May 2020 14:17:01 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 2643268B05; Sat, 16 May 2020 20:16:59 +0200 (CEST) Date: Sat, 16 May 2020 20:16:58 +0200 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , linux-xfs@vger.kernel.org Subject: Re: [PATCH 5/6] xfs: move the fork format fields into struct xfs_ifork Message-ID: <20200516181658.GA22612@lst.de> References: <20200510072404.986627-1-hch@lst.de> <20200510072404.986627-6-hch@lst.de> <20200514212541.GL6714@magnolia> <20200516135807.GA14540@lst.de> <20200516170143.GO1984748@magnolia> <20200516180150.GC6714@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200516180150.GC6714@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Sat, May 16, 2020 at 11:01:50AM -0700, Darrick J. Wong wrote: > > In my case it was the xfs_scrub run after generic/001 that did it. > > > > I think we're covered against null *ifp in most cases because they're > > guarded by an if(XFS_IFORK_Q()); it's jut here where I went around > > shortcutting. Maybe I should just fix this function for you... :) > > Hmm, that sounded meaner than I intended it to be. :/ > > Also, it turns out that it's pretty easy to fix this as part of fixing > the contorted logic in patch 1 (aka xchk_bmap_check_rmaps) so I'll do > that there. How about you send a patch to just fix up that function for now, and I'll rebase on top of that?