From: Kees Cook <keescook@chromium.org>
To: Xiaoming Ni <nixiaoming@huawei.com>
Cc: mcgrof@kernel.org, yzaikin@google.com, adobriyan@gmail.com,
peterz@infradead.org, mingo@kernel.org, patrick.bellasi@arm.com,
gregkh@linuxfoundation.org, tglx@linutronix.de,
Jisheng.Zhang@synaptics.com, bigeasy@linutronix.de,
pmladek@suse.com, ebiederm@xmission.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
wangle6@huawei.com
Subject: Re: [PATCH v2 3/4] hung_task: Move hung_task sysctl interface to hung_task.c
Date: Sat, 16 May 2020 19:43:15 -0700 [thread overview]
Message-ID: <202005161942.682497BF@keescook> (raw)
In-Reply-To: <1589619315-65827-4-git-send-email-nixiaoming@huawei.com>
On Sat, May 16, 2020 at 04:55:14PM +0800, Xiaoming Ni wrote:
> +/*
> + * This is needed for proc_doulongvec_minmax of sysctl_hung_task_timeout_secs
> + * and hung_task_check_interval_secs
> + */
> +static unsigned long hung_task_timeout_max = (LONG_MAX / HZ);
Please make this const. With that done, yes, looks great!
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2020-05-17 2:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 8:55 [PATCH v2 0/4] cleaning up the sysctls table (hung_task watchdog) Xiaoming Ni
2020-05-16 8:55 ` [PATCH v2 1/4] sysctl: Add register_sysctl_init() interface Xiaoming Ni
2020-05-17 2:44 ` Kees Cook
2020-05-16 8:55 ` [PATCH v2 2/4] sysctl: Move some boundary constants form sysctl.c to sysctl_vals Xiaoming Ni
2020-05-17 2:40 ` Kees Cook
2020-05-16 8:55 ` [PATCH v2 3/4] hung_task: Move hung_task sysctl interface to hung_task.c Xiaoming Ni
2020-05-17 2:43 ` Kees Cook [this message]
2020-05-17 3:01 ` Xiaoming Ni
2020-05-16 8:55 ` [PATCH v2 4/4] watchdog: move watchdog sysctl interface to watchdog.c Xiaoming Ni
2020-05-17 2:44 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202005161942.682497BF@keescook \
--to=keescook@chromium.org \
--cc=Jisheng.Zhang@synaptics.com \
--cc=adobriyan@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@kernel.org \
--cc=nixiaoming@huawei.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=tglx@linutronix.de \
--cc=wangle6@huawei.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.