From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: handle ext4_mark_inode_dirty errors
Date: Sun, 17 May 2020 21:56:30 -0400 [thread overview]
Message-ID: <20200518015630.GA2339693@mit.edu> (raw)
In-Reply-To: <20200427013438.219117-1-harshadshirwadkar@gmail.com>
On Sun, Apr 26, 2020 at 06:34:37PM -0700, Harshad Shirwadkar wrote:
> ext4_mark_inode_dirty() can fail for real reasons. Ignoring its return
> value may lead ext4 to ignore real failures that would result in
> corruption / crashes. Harden ext4_mark_inode_dirty error paths to fail
> as soon as possible and return errors to the caller whenever
> appropriate.
>
> One of the possible scnearios when this bug could affected is that
> while creating a new inode, its directory entry gets added
> successfully but while writing the inode itself mark_inode_dirty
> returns error which is ignored. This would result in inconsistency
> that the directory entry points to a non-existent inode.
>
> Ran gce-xfstests smoke tests and verified that there were no
> regressions.
>
> Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2020-05-18 1:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 1:34 [PATCH] ext4: handle ext4_mark_inode_dirty errors Harshad Shirwadkar
2020-04-27 1:34 ` [PATCH v3] ext4: don't ignore return values from ext4_ext_dirty() Harshad Shirwadkar
2020-05-19 19:31 ` Theodore Y. Ts'o
2020-05-18 1:56 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518015630.GA2339693@mit.edu \
--to=tytso@mit.edu \
--cc=harshadshirwadkar@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.