From: Christoph Hellwig <hch@lst.de>
To: Hillf Danton <hdanton@sina.com>
Cc: Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Ian Kent <raven@themaw.net>, David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 09/14] fs: don't change the address limit for ->write_iter in __kernel_write
Date: Mon, 18 May 2020 08:42:46 +0200 [thread overview]
Message-ID: <20200518064246.GA19296@lst.de> (raw)
In-Reply-To: <20200516030436.19448-1-hdanton@sina.com>
On Sat, May 16, 2020 at 11:04:36AM +0800, Hillf Danton wrote:
> > + if (file->f_op->write_iter) {
> > + struct kvec iov = { .iov_base = (void *)buf, .iov_len = count };
> > + struct kiocb kiocb;
> > + struct iov_iter iter;
> > +
> > + init_sync_kiocb(&kiocb, file);
> > + kiocb.ki_pos = *pos;
> > + iov_iter_kvec(&iter, WRITE, &iov, 1, count);
> > + ret = file->f_op->write_iter(&kiocb, &iter);
> > + if (ret > 0)
> > + *pos = kiocb.ki_pos;
> > + } else if (file->f_op->write) {
> > + mm_segment_t old_fs = get_fs();
> > +
> > + set_fs(KERNEL_DS);
>
> Would you please shed light on who need it if a workqueue worker does
> not, given the access to buf?
Can you rephrase the question, I unfortunately do not understand it at
all as-is.
next prev parent reply other threads:[~2020-05-18 6:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 6:56 clean up kernel_{read,write} & friends v2 Christoph Hellwig
2020-05-13 6:56 ` [PATCH 01/14] cachefiles: switch to kernel_write Christoph Hellwig
2020-05-15 15:21 ` David Howells
2020-05-13 6:56 ` [PATCH 02/14] autofs: " Christoph Hellwig
2020-05-14 8:25 ` Ian Kent
2020-05-13 6:56 ` [PATCH 03/14] bpfilter: " Christoph Hellwig
2020-05-13 6:56 ` [PATCH 04/14] fs: unexport __kernel_write Christoph Hellwig
2020-05-13 6:56 ` [PATCH 05/14] fs: check FMODE_WRITE in __kernel_write Christoph Hellwig
2020-05-13 6:56 ` [PATCH 06/14] fs: remove the call_{read,write}_iter functions Christoph Hellwig
2020-05-13 6:56 ` [PATCH 07/14] fs: implement kernel_write using __kernel_write Christoph Hellwig
2020-05-13 6:56 ` [PATCH 08/14] fs: remove __vfs_write Christoph Hellwig
2020-05-13 6:56 ` [PATCH 09/14] fs: don't change the address limit for ->write_iter in __kernel_write Christoph Hellwig
2020-05-13 6:56 ` [PATCH 10/14] fs: add a __kernel_read helper Christoph Hellwig
2020-05-13 6:56 ` [PATCH 11/14] integrity/ima: switch to using __kernel_read Christoph Hellwig
2020-05-13 6:56 ` [PATCH 12/14] fs: implement kernel_read " Christoph Hellwig
2020-05-13 6:56 ` [PATCH 13/14] fs: remove __vfs_read Christoph Hellwig
2020-05-13 6:56 ` [PATCH 14/14] fs: don't change the address limit for ->read_iter in __kernel_read Christoph Hellwig
[not found] ` <20200516030436.19448-1-hdanton@sina.com>
2020-05-18 6:42 ` Christoph Hellwig [this message]
2020-05-20 15:59 ` clean up kernel_{read,write} & friends v2 Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2020-05-28 5:40 Christoph Hellwig
2020-05-28 5:40 ` [PATCH 09/14] fs: don't change the address limit for ->write_iter in __kernel_write Christoph Hellwig
2020-05-28 18:43 ` Linus Torvalds
2020-05-29 12:32 ` Christoph Hellwig
2020-05-28 19:00 ` Al Viro
2020-05-29 5:57 ` Christoph Hellwig
2020-05-29 13:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518064246.GA19296@lst.de \
--to=hch@lst.de \
--cc=dhowells@redhat.com \
--cc=hdanton@sina.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.