From: Cristian Klein <cristian.klein@elastisys.com>
To: jikos@kernel.org, benjamin.tissoires@redhat.com
Cc: linux-input@vger.kernel.org,
Cristian Klein <cristian.klein@elastisys.com>
Subject: [PATCH] Allow building hid.ko as an "external" module
Date: Mon, 18 May 2020 13:37:42 +0200 [thread overview]
Message-ID: <20200518113742.21718-1-cristian.klein@elastisys.com> (raw)
For quickly testing USB HID quirks with a larger community, it is useful
to be able to build hid.ko as an external module, e.g., against the
source code of the running kernel.
Before this patch this failed as follows:
```
$ make -C /lib/modules/$(uname -r)/build M=$PWD/drivers/hid
make: Entering directory '/usr/src/linux-headers-5.3.0-51-generic'
CC [M] /home/cklein/linux/drivers/hid/i2c-hid/i2c-hid-core.o
CC [M] /home/cklein/linux/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.o
LD [M] /home/cklein/linux/drivers/hid/i2c-hid/i2c-hid.o
CC [M] /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/init.o
CC [M] /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/hbm.o
CC [M] /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/client.o
CC [M] /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/bus.o
CC [M] /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/dma-if.o
CC [M] /home/cklein/linux/drivers/hid/intel-ish-hid/ishtp/client-buffers.o
LD [M] /home/cklein/linux/drivers/hid/intel-ish-hid/intel-ishtp.o
CC [M] /home/cklein/linux/drivers/hid/intel-ish-hid/ipc/ipc.o
/home/cklein/linux/drivers/hid/intel-ish-hid/ipc/ipc.c:12:10: fatal error: client.h: No such file or directory
12 | #include "client.h"
| ^~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.build:290: /home/cklein/linux/drivers/hid/intel-ish-hid/ipc/ipc.o] Error 1
make[1]: *** [scripts/Makefile.build:519: /home/cklein/linux/drivers/hid/intel-ish-hid] Error 2
make: *** [Makefile:1656: _module_/home/cklein/linux/drivers/hid] Error 2
make: Leaving directory '/usr/src/linux-headers-5.3.0-51-generic'
```
---
drivers/hid/intel-ish-hid/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/intel-ish-hid/Makefile b/drivers/hid/intel-ish-hid/Makefile
index f0a82b1c7..db4974c43 100644
--- a/drivers/hid/intel-ish-hid/Makefile
+++ b/drivers/hid/intel-ish-hid/Makefile
@@ -23,4 +23,4 @@ intel-ishtp-hid-objs += ishtp-hid-client.o
obj-$(CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER) += intel-ishtp-loader.o
intel-ishtp-loader-objs += ishtp-fw-loader.o
-ccflags-y += -I $(srctree)/$(src)/ishtp
+ccflags-y += -I $(src)/ishtp
--
2.20.1
next reply other threads:[~2020-05-18 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 11:37 Cristian Klein [this message]
2020-06-19 7:14 ` [PATCH] Allow building hid.ko as an "external" module Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2020-06-22 7:59 linux-next: Signed-off-by missing for commit in the hid tree Cristian Klein
2020-06-23 11:46 ` [PATCH] Allow building hid.ko as an "external" module kernel test robot
2020-06-23 11:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518113742.21718-1-cristian.klein@elastisys.com \
--to=cristian.klein@elastisys.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.