From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A36C433E0 for ; Tue, 19 May 2020 00:03:30 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA9ED2072C for ; Tue, 19 May 2020 00:03:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vXG4Ea4q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA9ED2072C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1japib-0006v3-24; Tue, 19 May 2020 00:02:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1japiZ-0006uy-4K for xen-devel@lists.xenproject.org; Tue, 19 May 2020 00:02:47 +0000 X-Inumbo-ID: 11daf2d2-9964-11ea-b9cf-bc764e2007e4 Received: from mail-ot1-x342.google.com (unknown [2607:f8b0:4864:20::342]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 11daf2d2-9964-11ea-b9cf-bc764e2007e4; Tue, 19 May 2020 00:02:46 +0000 (UTC) Received: by mail-ot1-x342.google.com with SMTP id c3so9700423otr.12 for ; Mon, 18 May 2020 17:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iYjOqrFGOmpbtD9yt96lQwWe0nWJADjGyH8dgI2UBJs=; b=vXG4Ea4qYNxaFsDjBV0PwUYxg/DGm6x2IWVvNPEMF9gSc9b36/aRdgohW8Pe1eq/M4 N645SKh7DUAwIragn3CGxNF7txZZ8D3Mam4XhwDYkZ0NkqicUgpA7TzIRB7Cm65e3/G8 xvEST1V/i/9C1Y2UOoPfveaguN1K6nL5C61iQlxJq/Bmz95VPphOWqnuqb4VmT2sRn/k bFBE0eRq9VGPjorXtiRHErquV5Zn874cLSkzDN+xICXLewjfKbe68/8W8JCZzvlTbNdG T5tC/lvGfkRb4HCBGtNDJpwL06Sba+qneRNPy4oWq39j7BBMMndd3hsahurPEBbuBg/6 Nlpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to :user-agent; bh=iYjOqrFGOmpbtD9yt96lQwWe0nWJADjGyH8dgI2UBJs=; b=npi8czN11/EClf+08/G2KFCEDkEbyfkrC49sSBT9/AdF9FuU85tD0GK3qfbD48kcla rK4K9ZKMydGcxO6jvS4wWbpQtuMDvGgrlrjbI+0L1OdOYEtvTKrklQO40Y9PozLtGOWm I8MokzKE1uuImRfooMfPKcvty66eoMc9Evmb4FdybLIHP1hROA4GydG4ZKbpzpo40A9b R6vQVDxMOQM26Nl6vSW8f4ETb/rqKnsT7qrE3hQuG4ZIQDj0ouJHczzSzv1NkZaovY3G AVYbkQ74V7WQPExSv2ZH1rsfdOAf0tVoh2wqA8TMn+2TXrY+kXumzC+5/pnC7NqBra2l UF9A== X-Gm-Message-State: AOAM530t+8tEZYmvRG+TihMXKTvCfyiuOmqb+bhirBAD9aDWqvuuHWJ+ ZCo5pYN5WEWsggrHENezvA== X-Google-Smtp-Source: ABdhPJxj1gl61nfGlDjfEwABJRLHTww6pg7TG615C4W2TfrFeaxVYUBIwfoo+vmi4hqoBWECYKUp+Q== X-Received: by 2002:a9d:1a7:: with SMTP id e36mr13383074ote.215.1589846565860; Mon, 18 May 2020 17:02:45 -0700 (PDT) Received: from serve.minyard.net ([47.184.146.204]) by smtp.gmail.com with ESMTPSA id y89sm712062ota.16.2020.05.18.17.02.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 17:02:44 -0700 (PDT) Received: from minyard.net (unknown [192.168.27.193]) by serve.minyard.net (Postfix) with ESMTPSA id B2B83180042; Tue, 19 May 2020 00:02:43 +0000 (UTC) Date: Mon, 18 May 2020 19:02:42 -0500 From: Corey Minyard To: Volodymyr Babchuk Subject: Re: [PATCH for-4.14 3/3] xen/arm: plat: Allocate as much as possible memory below 1GB for dom0 for RPI Message-ID: <20200519000242.GA3948@minyard.net> References: <20200518113008.15422-1-julien@xen.org> <20200518113008.15422-4-julien@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: "sstabellini@kernel.org" , "julien@xen.org" , "jgrall@amazon.com" , "roman@zededa.com" , "jeff.kubascik@dornerworks.com" , "xen-devel@lists.xenproject.org" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Mon, May 18, 2020 at 08:36:08PM +0000, Volodymyr Babchuk wrote: > Hi Julien, > > On Mon, 2020-05-18 at 12:30 +0100, Julien Grall wrote: > > From: Julien Grall > > > > The raspberry PI 4 has devices that can only DMA into the first GB of > > the RAM. Therefore we want allocate as much as possible memory below 1GB > > for dom0. > > > > Use the recently introduced dma_bitsize field to specify the DMA width > > supported. > > > > Signed-off-by: Julien Grall > > Reported-by: Corey Minyard > > --- > > xen/arch/arm/platforms/brcm-raspberry-pi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/xen/arch/arm/platforms/brcm-raspberry-pi.c b/xen/arch/arm/platforms/brcm-raspberry-pi.c > > index b697fa2c6c0e..ad5483437b31 100644 > > --- a/xen/arch/arm/platforms/brcm-raspberry-pi.c > > +++ b/xen/arch/arm/platforms/brcm-raspberry-pi.c > > @@ -43,6 +43,7 @@ static const struct dt_device_match rpi4_blacklist_dev[] __initconst = > > PLATFORM_START(rpi4, "Raspberry Pi 4") > > .compatible = rpi4_dt_compat, > > .blacklist_dev = rpi4_blacklist_dev, > > + .dma_bitsize = 10, > > I'm confused. Should it be 30? Indeed it should. I just tested this series, and Linux fails to boot with this set to 10. With it set to 30 it works. With this set to 30, you can have a: Tested-by: Corey Minyard for all three patches. -corey > > > PLATFORM_END > > > > /*