Re: [RHEL 8.3 BZ 1768622 PATCH 3/3] KVM: x86: use raw clock values consistently

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, May 19, 2020 at 10:58:52AM +0200, Frantisek Hrbata wrote:
> Hi Marcelo,
> 
> I'm marking this as superseded by pwid 303977
> 
> http://patchwork.lab.bos.redhat.com/patch/303977/
> 
> which was included in kernel-4.18.0-196.el8
> 
>     commit 9751522d92195bc64883c71e2bee8ed0fcbc5007
>     Author: Vitaly Kuznetsov <vkuznets@redhat.com>
>     Date:   Mon Apr 20 15:20:04 2020 -0400
> 
>     [x86] kvm: x86: use raw clock values consistently
> 
>     Message-id: <20200420152004.933168-1-vkuznets@redhat.com>
>     Patchwork-id: 303977
>     Patchwork-instance: patchwork
>     O-Subject: [RHEL8.3 virt PATCH v2 312/614] KVM: x86: use raw clock values consistently
>     Bugzilla: 1813987
>     RH-Acked-by: Andrew Jones <drjones@redhat.com>
>     RH-Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>     RH-Acked-by: Tony Camuso <tcamuso@redhat.com>
> 
> Note there is a difference between yours and Vitaly's patch in the
> following hunk
> 
> +@@ -1656,6 +1656,18 @@ static void update_pvclock_gtod(struct timekeeper *tk)
> 
>         write_seqcount_end(&vdata->seq);
>   }
> @@ -14,12 +16,12 @@
>  +static s64 get_kvmclock_base_ns(void)
>  +{
>  +      /* Master clock not used, so we can just use CLOCK_BOOTTIME.  */
> -+      return ktime_get_boottime_ns();
> ++      return ktime_get_boot_ns();
>  +}
>   #endif
> 
> 
> This is in !CONFIG_X86_64 path, so I'm not sure how much we care about
> this. Anyway Vitaly's patch corrects this, because
> rhel does not have upstream commit 9285ec4c8b61d4930a575081abeba2cd4f449a74

Gotta love private git repo discussions on a public mailing list :)

greg k-h