From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/5] syscalls: Don't use tst_syscall() unnecessarily
Date: Tue, 19 May 2020 14:23:47 +0200 [thread overview]
Message-ID: <20200519122347.GC16008@yuki.lan> (raw)
In-Reply-To: <3f3b7d669d47ae701385b43deb8280a353dd231e.1589877853.git.viresh.kumar@linaro.org>
Hi!
> These syscall are old enough and must have support in libc for everyone.
> Don't use tst_syscall() for them unnecessarily.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> lib/parse_opts.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/parse_opts.c b/lib/parse_opts.c
> index a9d50589a3f9..b3ab69c0a539 100644
> --- a/lib/parse_opts.c
> +++ b/lib/parse_opts.c
> @@ -45,7 +45,6 @@
> #include "test.h"
> #include "ltp_priv.h"
> #include "usctest.h"
> -#include "tst_clocks.h"
>
> #ifndef UNIT_TEST
> #define UNIT_TEST 0
> @@ -472,7 +471,7 @@ static uint64_t get_current_time(void)
> {
> struct timespec ts;
>
> - tst_clock_gettime(CLOCK_MONOTONIC, &ts);
> + clock_gettime(CLOCK_MONOTONIC, &ts);
I guess that this will reintroduce LTP compilation failures on older
glibc, which was the primary reason we used the tst_clock_gettime()
instead of clock_gettime().
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2020-05-19 12:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 8:51 [LTP] [PATCH 0/5] syscalls: Remove incorrect usage of libc structures Viresh Kumar
2020-05-19 8:51 ` [LTP] [PATCH 1/5] tst_safe_clocks: Remove safe_clock_adjtime() Viresh Kumar
2020-05-19 8:51 ` [LTP] [PATCH 2/5] syscalls: settimeofday: Use gettimeofday() Viresh Kumar
2020-05-19 9:20 ` Arnd Bergmann
2020-05-19 9:25 ` Viresh Kumar
2020-05-19 10:24 ` Arnd Bergmann
2020-05-19 12:16 ` Cyril Hrubis
2020-05-19 12:47 ` Arnd Bergmann
2020-05-20 7:16 ` Viresh Kumar
2020-05-21 13:16 ` Cyril Hrubis
2020-05-19 8:51 ` [LTP] [PATCH 3/5] syscalls: Don't use tst_syscall() unnecessarily Viresh Kumar
2020-05-19 9:22 ` Arnd Bergmann
2020-05-19 9:28 ` Viresh Kumar
2020-05-19 12:23 ` Cyril Hrubis [this message]
2020-05-19 12:41 ` Arnd Bergmann
2020-05-19 12:56 ` Petr Vorel
2020-05-19 13:45 ` Cyril Hrubis
2020-05-20 7:19 ` Viresh Kumar
2020-05-21 14:20 ` Cyril Hrubis
2020-05-21 15:10 ` Arnd Bergmann
2020-05-19 8:51 ` [LTP] [PATCH 4/5] syscalls: Don't pass struct timespec to tst_syscall() Viresh Kumar
2020-05-19 12:21 ` Cyril Hrubis
2020-05-20 7:31 ` Viresh Kumar
2020-05-20 8:47 ` Arnd Bergmann
2020-05-20 9:05 ` Viresh Kumar
2020-05-20 9:35 ` Arnd Bergmann
2020-05-20 9:39 ` Viresh Kumar
2020-05-20 9:52 ` Arnd Bergmann
2020-05-19 8:51 ` [LTP] [PATCH 5/5] syscalls: Don't pass struct timeval " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519122347.GC16008@yuki.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.