diff for duplicates of <20200519172709.GA1150171@kroah.com> diff --git a/a/1.txt b/N1/1.txt index 50f3112..8c0c24b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -48,7 +48,7 @@ On Tue, May 19, 2020 at 12:32:31PM -0400, Sasha Levin wrote: > + } > + dxgglobal->devt_initialized = true; > + dxgglobal->device_class = class_create(THIS_MODULE, "dxgkdrv"); -> + if (dxgglobal->device_class = NULL) { +> + if (dxgglobal->device_class == NULL) { > + pr_err("class_create failed\n"); > + ret = -ENODEV; > + goto error; @@ -56,7 +56,7 @@ On Tue, May 19, 2020 at 12:32:31PM -0400, Sasha Levin wrote: > + dxgglobal->device_class->devnode = dxg_devnode; > + dxgglobal->device = device_create(dxgglobal->device_class, NULL, > + dxgglobal->device_devt, NULL, "dxg"); -> + if (dxgglobal->device = NULL) { +> + if (dxgglobal->device == NULL) { > + pr_err("device_create failed\n"); > + ret = -ENODEV; > + goto error; diff --git a/a/content_digest b/N1/content_digest index 3f7cd43..876587d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,22 +2,23 @@ "ref\020200519163234.226513-2-sashal@kernel.org\0" "From\0Greg KH <gregkh@linuxfoundation.org>\0" "Subject\0Re: [RFC PATCH 1/4] gpu: dxgkrnl: core code\0" - "Date\0Tue, 19 May 2020 17:27:09 +0000\0" + "Date\0Tue, 19 May 2020 19:27:09 +0200\0" "To\0Sasha Levin <sashal@kernel.org>\0" - "Cc\0linux-hyperv@vger.kernel.org" - sthemmin@microsoft.com + "Cc\0alexander.deucher@amd.com" + chris@chris-wilson.co.uk + ville.syrjala@linux.intel.com + Hawking.Zhang@amd.com tvrtko.ursulin@intel.com - haiyangz@microsoft.com - spronovo@microsoft.com linux-kernel@vger.kernel.org - dri-devel@lists.freedesktop.org - chris@chris-wilson.co.uk + linux-hyperv@vger.kernel.org + kys@microsoft.com + haiyangz@microsoft.com + sthemmin@microsoft.com wei.liu@kernel.org - linux-fbdev@vger.kernel.org + spronovo@microsoft.com iourit@microsoft.com - alexander.deucher@amd.com - kys@microsoft.com - " Hawking.Zhang@amd.com\0" + dri-devel@lists.freedesktop.org + " linux-fbdev@vger.kernel.org\0" "\00:1\0" "b\0" "On Tue, May 19, 2020 at 12:32:31PM -0400, Sasha Levin wrote:\n" @@ -70,7 +71,7 @@ "> +\t}\n" "> +\tdxgglobal->devt_initialized = true;\n" "> +\tdxgglobal->device_class = class_create(THIS_MODULE, \"dxgkdrv\");\n" - "> +\tif (dxgglobal->device_class = NULL) {\n" + "> +\tif (dxgglobal->device_class == NULL) {\n" "> +\t\tpr_err(\"class_create failed\\n\");\n" "> +\t\tret = -ENODEV;\n" "> +\t\tgoto error;\n" @@ -78,7 +79,7 @@ "> +\tdxgglobal->device_class->devnode = dxg_devnode;\n" "> +\tdxgglobal->device = device_create(dxgglobal->device_class, NULL,\n" "> +\t\t\t\t\t dxgglobal->device_devt, NULL, \"dxg\");\n" - "> +\tif (dxgglobal->device = NULL) {\n" + "> +\tif (dxgglobal->device == NULL) {\n" "> +\t\tpr_err(\"device_create failed\\n\");\n" "> +\t\tret = -ENODEV;\n" "> +\t\tgoto error;\n" @@ -105,4 +106,4 @@ "\n" greg k-h -17df31d57afddd3535bc850c2f1a6e938963430f283a2579cca9b357a8daa180 +9c5f866c93d6f25b4b86ae5a73936e709dda58187f19c45c98a797cd76b0c7d6
diff --git a/a/1.txt b/N2/1.txt index 50f3112..c7f5242 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -48,7 +48,7 @@ On Tue, May 19, 2020 at 12:32:31PM -0400, Sasha Levin wrote: > + } > + dxgglobal->devt_initialized = true; > + dxgglobal->device_class = class_create(THIS_MODULE, "dxgkdrv"); -> + if (dxgglobal->device_class = NULL) { +> + if (dxgglobal->device_class == NULL) { > + pr_err("class_create failed\n"); > + ret = -ENODEV; > + goto error; @@ -56,7 +56,7 @@ On Tue, May 19, 2020 at 12:32:31PM -0400, Sasha Levin wrote: > + dxgglobal->device_class->devnode = dxg_devnode; > + dxgglobal->device = device_create(dxgglobal->device_class, NULL, > + dxgglobal->device_devt, NULL, "dxg"); -> + if (dxgglobal->device = NULL) { +> + if (dxgglobal->device == NULL) { > + pr_err("device_create failed\n"); > + ret = -ENODEV; > + goto error; @@ -82,3 +82,7 @@ of the above logic correct. thanks, greg k-h +_______________________________________________ +dri-devel mailing list +dri-devel@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/a/content_digest b/N2/content_digest index 3f7cd43..50751a1 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,7 +2,7 @@ "ref\020200519163234.226513-2-sashal@kernel.org\0" "From\0Greg KH <gregkh@linuxfoundation.org>\0" "Subject\0Re: [RFC PATCH 1/4] gpu: dxgkrnl: core code\0" - "Date\0Tue, 19 May 2020 17:27:09 +0000\0" + "Date\0Tue, 19 May 2020 19:27:09 +0200\0" "To\0Sasha Levin <sashal@kernel.org>\0" "Cc\0linux-hyperv@vger.kernel.org" sthemmin@microsoft.com @@ -70,7 +70,7 @@ "> +\t}\n" "> +\tdxgglobal->devt_initialized = true;\n" "> +\tdxgglobal->device_class = class_create(THIS_MODULE, \"dxgkdrv\");\n" - "> +\tif (dxgglobal->device_class = NULL) {\n" + "> +\tif (dxgglobal->device_class == NULL) {\n" "> +\t\tpr_err(\"class_create failed\\n\");\n" "> +\t\tret = -ENODEV;\n" "> +\t\tgoto error;\n" @@ -78,7 +78,7 @@ "> +\tdxgglobal->device_class->devnode = dxg_devnode;\n" "> +\tdxgglobal->device = device_create(dxgglobal->device_class, NULL,\n" "> +\t\t\t\t\t dxgglobal->device_devt, NULL, \"dxg\");\n" - "> +\tif (dxgglobal->device = NULL) {\n" + "> +\tif (dxgglobal->device == NULL) {\n" "> +\t\tpr_err(\"device_create failed\\n\");\n" "> +\t\tret = -ENODEV;\n" "> +\t\tgoto error;\n" @@ -103,6 +103,10 @@ "\n" "thanks,\n" "\n" - greg k-h + "greg k-h\n" + "_______________________________________________\n" + "dri-devel mailing list\n" + "dri-devel@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/dri-devel -17df31d57afddd3535bc850c2f1a6e938963430f283a2579cca9b357a8daa180 +a7c942ee3f029f161154202e383d705f81161947134d6e5aff03b764aca58691
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.