From: Domenico Andreoli <domenico.andreoli@linux.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Pavel Machek <pavel@ucw.cz>, Christoph Hellwig <hch@lst.de>,
Al Viro <viro@zeniv.linux.org.uk>, Ted Ts'o <tytso@mit.edu>,
Len Brown <len.brown@intel.com>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] hibernate: restrict writes to the snapshot device
Date: Tue, 19 May 2020 20:17:13 +0200 [thread overview]
Message-ID: <20200519181713.GB1963@dumbo> (raw)
In-Reply-To: <CAJZ5v0jnfeAQ4JDz+BTZp8P98h6emTizGWLYNL_QtbQ=3Nw03Q@mail.gmail.com>
On Tue, May 19, 2020 at 05:59:15PM +0200, Rafael J. Wysocki wrote:
> It would be better to paste the patch instead of attaching it.
Done with v2.
> Anyway, note that the snapshot special device is not the target block
> device for saving the image, so it would be good to avoid that
> confusion in the naming.
I realize that it was a bit hazy in my head as well. It should be fixed
in v2.
>
> I.e. I would rename is_hibernate_snapshot_dev() to something like
> is_hibernate_image_dev() or is_hibernate_resume_dev() (for consistency
> with the resume= kernel command line parameter name).
Done as well.
> Thanks!
Thank you!
Dom
--
rsa4096: 3B10 0CA1 8674 ACBA B4FE FCD2 CE5B CF17 9960 DE13
ed25519: FFB4 0CC3 7F2E 091D F7DA 356E CC79 2832 ED38 CB05
prev parent reply other threads:[~2020-05-19 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 8:04 [PATCH 0/1] hibernate: restrict writes to the snapshot device Domenico Andreoli
2020-05-07 8:04 ` [PATCH 1/1] " Domenico Andreoli
2020-05-19 15:59 ` Rafael J. Wysocki
2020-05-19 18:17 ` Domenico Andreoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519181713.GB1963@dumbo \
--to=domenico.andreoli@linux.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=len.brown@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.