From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6EAEC433E1 for ; Tue, 19 May 2020 19:00:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A901620823 for ; Tue, 19 May 2020 19:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726502AbgESTAp (ORCPT ); Tue, 19 May 2020 15:00:45 -0400 Received: from mga06.intel.com ([134.134.136.31]:62691 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726352AbgESTAp (ORCPT ); Tue, 19 May 2020 15:00:45 -0400 IronPort-SDR: vwky50IiyfCMFHsyjHNDpyQF6ffQBzJJo3cGzp8HGLJAQqSg8h/cNVvxzd85wObH2EjGclJMeB Y/XGOHHkqB+g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 12:00:44 -0700 IronPort-SDR: DPcoO8JWQyzvNdTE+i+NjsSRehFDDEuS8LYC9YUWq1IQeAtof4lmJM2bG07+MnU58PZIh1qInD p/nEVByMNVFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,410,1583222400"; d="scan'208";a="264407484" Received: from joelin3-mobl.gar.corp.intel.com (HELO localhost) ([10.249.42.57]) by orsmga003.jf.intel.com with ESMTP; 19 May 2020 12:00:40 -0700 Date: Tue, 19 May 2020 22:00:36 +0300 From: Jarkko Sakkinen To: Nikita Sobolev Cc: Shuah Khan , linux-kselftest@vger.kernel.org, Tadeusz Struk , Joey Pabalinas , Petr Vorel , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, Jason Gunthorpe , Peter Huewe , Alexey Brodkin , Eugeniy Paltsev , linux-snps-arc@lists.infradead.org Subject: Re: [PATCH v2] Kernel selftests: Add check if tpm devices are supported Message-ID: <20200519190023.GA22852@linux.intel.com> References: <20200519120743.41358-1-Nikita.Sobolev@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200519120743.41358-1-Nikita.Sobolev@synopsys.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Tue, May 19, 2020 at 03:07:43PM +0300, Nikita Sobolev wrote: > tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they > are available. In case, when these devices are not available test > fails, but expected behaviour is skipped test. > > Signed-off-by: Nikita Sobolev See https://lore.kernel.org/linux-kselftest/20200519134838.GA17129@linux.intel.com/T/#mf762512a67f0b23db5663d6d67746cb94b812931 The comments about the fixes tag and acronym spelling were not addressed. The code change looks great tho now, thanks. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 161C6C433DF for ; Tue, 19 May 2020 19:00:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4F75207E8 for ; Tue, 19 May 2020 19:00:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UJWuwLBt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4F75207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k3U2h3fTZcr6nXMqh+rxzur3QFxv3vb7w/wu056fAMU=; b=UJWuwLBtPKg4h9 DLvC2bH3xYPPS9H60UsJBh8gyd/0zX4GIJFmzPNc4nMAqSHaWPtJFweWG+u7uqwgUvcNS4FjN1NGE XL6F+yLZpNmhQjD6EJ7wb7AJZERl3DYYjSocd3zhoB/SwyDXHs+H4yUamZIQcGJ73aaE34YX5um2Q k8ZsemPuInWItxh4yGxfJHI5zI6+S6uX2c+Ru3ujWCuqvEXqXGyItBU33nnBNGPc98cG+v+QUiYyF SUeCGx3rCV5hUesIQ0mKY11Ghm19pw8lIW/mTktULXZ+BMi2zpt0Hak0cSZQoFR7OLM/PO3N86Pw2 NrEs8XgPuwWYwdhYodow==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb7Tx-0006u9-RN; Tue, 19 May 2020 19:00:53 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb7Tq-0006nX-7X for linux-snps-arc@lists.infradead.org; Tue, 19 May 2020 19:00:51 +0000 IronPort-SDR: 4DuJR/A+WMqC+wXeWw3t4p3/1MAaMJddXSBFyFCpFnPWnxO7odyULcR/UWWdgFSHr5o8SR1BVq fwAC5yNqVJVw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2020 12:00:45 -0700 IronPort-SDR: DPcoO8JWQyzvNdTE+i+NjsSRehFDDEuS8LYC9YUWq1IQeAtof4lmJM2bG07+MnU58PZIh1qInD p/nEVByMNVFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,410,1583222400"; d="scan'208";a="264407484" Received: from joelin3-mobl.gar.corp.intel.com (HELO localhost) ([10.249.42.57]) by orsmga003.jf.intel.com with ESMTP; 19 May 2020 12:00:40 -0700 Date: Tue, 19 May 2020 22:00:36 +0300 From: Jarkko Sakkinen To: Nikita Sobolev Subject: Re: [PATCH v2] Kernel selftests: Add check if tpm devices are supported Message-ID: <20200519190023.GA22852@linux.intel.com> References: <20200519120743.41358-1-Nikita.Sobolev@synopsys.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200519120743.41358-1-Nikita.Sobolev@synopsys.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200519_120046_348236_EEC02006 X-CRM114-Status: UNSURE ( 7.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kselftest@vger.kernel.org, Tadeusz Struk , Eugeniy Paltsev , Alexey Brodkin , linux-kernel@vger.kernel.org, Jason Gunthorpe , Joey Pabalinas , Petr Vorel , linux-integrity@vger.kernel.org, linux-snps-arc@lists.infradead.org, Shuah Khan , Peter Huewe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Tue, May 19, 2020 at 03:07:43PM +0300, Nikita Sobolev wrote: > tpm2 tests set uses /dev/tpm0 and /dev/tpmrm0 without check if they > are available. In case, when these devices are not available test > fails, but expected behaviour is skipped test. > > Signed-off-by: Nikita Sobolev See https://lore.kernel.org/linux-kselftest/20200519134838.GA17129@linux.intel.com/T/#mf762512a67f0b23db5663d6d67746cb94b812931 The comments about the fixes tag and acronym spelling were not addressed. The code change looks great tho now, thanks. /Jarkko _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc