From: Andrew Lunn <andrew@lunn.ch>
To: Dan Murphy <dmurphy@ti.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps
Date: Tue, 19 May 2020 21:03:16 +0200 [thread overview]
Message-ID: <20200519190316.GA652285@lunn.ch> (raw)
In-Reply-To: <5d6d799f-f7b6-566a-5038-5901590f2e7b@ti.com>
On Tue, May 19, 2020 at 01:59:16PM -0500, Dan Murphy wrote:
> Jakub
>
> On 5/19/20 1:48 PM, Jakub Kicinski wrote:
> > On Tue, 19 May 2020 13:41:40 -0500 Dan Murphy wrote:
> > > > Is this now a standard GCC warning? Or have you turned on extra
> > > > checking?
> > > I still was not able to reproduce this warning with gcc-9.2. I would
> > > like to know the same
> > W=1 + gcc-10 here, also curious to know which one of the two makes
> > the difference :)
>
> W=1 made the difference I got the warning with gcc-9.2
I wonder if we should turn on this specific warning by default in
drivers/net/phy? I keep making the same mistake, and it would be nice
if GCC actually told me.
Andrew
next prev parent reply other threads:[~2020-05-19 19:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 14:18 [PATCH net-next 0/4] DP83869 Enhancements Dan Murphy
2020-05-19 14:18 ` [PATCH net-next 1/4] net: phy: dp83869: Update port-mirroring to read straps Dan Murphy
2020-05-19 20:03 ` Florian Fainelli
2020-05-19 14:18 ` [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps Dan Murphy
2020-05-19 16:58 ` Jakub Kicinski
2020-05-19 17:40 ` Dan Murphy
2020-05-19 17:56 ` Dan Murphy
2020-05-19 18:29 ` Andrew Lunn
2020-05-19 18:41 ` Dan Murphy
2020-05-19 18:48 ` Jakub Kicinski
2020-05-19 18:59 ` Dan Murphy
2020-05-19 19:03 ` Andrew Lunn [this message]
2020-05-19 17:19 ` kbuild test robot
2020-05-19 17:19 ` kbuild test robot
2020-05-19 17:40 ` Dan Murphy
2020-05-19 17:40 ` Dan Murphy
2020-05-19 23:54 ` Philip Li
2020-05-19 23:54 ` [kbuild-all] " Philip Li
2020-05-19 19:16 ` kbuild test robot
2020-05-19 19:16 ` kbuild test robot
2020-05-19 14:18 ` [PATCH net-next 3/4] dt-bindings: net: Add RGMII internal delay for DP83869 Dan Murphy
2020-05-19 14:18 ` [PATCH net-next 4/4] net: dp83869: Add RGMII internal delay configuration Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519190316.GA652285@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.