Re: [RFC PATCH] clk: rework clk_register to use the clk_hw API

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2599 bytes --]

Hi Jerome,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on clk/clk-next]
[also build test WARNING on v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jerome-Brunet/clk-rework-clk_register-to-use-the-clk_hw-API/20200520-011000
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: x86_64-defconfig (attached as .config)

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/clk/clk.c: In function 'clk_register':
drivers/clk/clk.c:3868:8: error: implicit declaration of function 'clk_hw_get_clk'; did you mean '__clk_hw_set_clk'? [-Werror=implicit-function-declaration]
clk = clk_hw_get_clk(hw);
^~~~~~~~~~~~~~
__clk_hw_set_clk
>> drivers/clk/clk.c:3868:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
clk = clk_hw_get_clk(hw);
^
cc1: some warnings being treated as errors

vim +3868 drivers/clk/clk.c

  3846	
  3847	/**
  3848	 * clk_register - allocate a new clock, register it and return an opaque cookie
  3849	 * @dev: device that is registering this clock
  3850	 * @hw: link to hardware-specific clock data
  3851	 *
  3852	 * clk_register is the *deprecated* interface for populating the clock tree with
  3853	 * new clock nodes. Use clk_hw_register() instead.
  3854	 *
  3855	 * Returns: a pointer to the newly allocated struct clk which
  3856	 * cannot be dereferenced by driver code but may be used in conjunction with the
  3857	 * rest of the clock API.  In the event of an error clk_register will return an
  3858	 * error code; drivers must test for an error code after calling clk_register.
  3859	 */
  3860	struct clk *clk_register(struct device *dev, struct clk_hw *hw)
  3861	{
  3862		struct clk *clk;
  3863		int ret = clk_hw_register(dev, hw);
  3864	
  3865		if (ret < 0)
  3866			return ERR_PTR(ret);
  3867	
> 3868		clk = clk_hw_get_clk(hw);
  3869		if (IS_ERR_OR_NULL(clk))
  3870			clk_hw_unregister(hw);
  3871	
  3872		return clk;
  3873	}
  3874	EXPORT_SYMBOL_GPL(clk_register);
  3875	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29095 bytes --]