All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Leyi Rong <leyi.rong@intel.com>
Cc: jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured
Date: Wed, 20 May 2020 15:10:41 +0800	[thread overview]
Message-ID: <20200520071041.GA99392@intel.com> (raw)
In-Reply-To: <20200520063950.50315-1-leyi.rong@intel.com>

On 05/20, Leyi Rong wrote:
>FDIR ID parsing will not be handled correctly after queue reconfigured,
>enable FDIR ID parsing per Q regardless of fdir_ref_cnt to fix it.
>
>Fixes: f71dbf852d46 ("net/iavf: add flow director enabled switch value")
>
>Signed-off-by: Leyi Rong <leyi.rong@intel.com>
>---
> drivers/net/iavf/iavf_rxtx.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h
>index 73968847f..59625a979 100644
>--- a/drivers/net/iavf/iavf_rxtx.h
>+++ b/drivers/net/iavf/iavf_rxtx.h
>@@ -509,8 +509,8 @@ void iavf_fdir_rx_proc_enable(struct iavf_adapter *ad, bool on)
> {
> 	if (on) {
> 		/* enable flow director processing */
>-		if (ad->fdir_ref_cnt++ == 0)
>-			FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
>+		FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
>+		ad->fdir_ref_cnt++;
> 	} else {
> 		if (ad->fdir_ref_cnt >= 1) {
> 			ad->fdir_ref_cnt--;
>-- 
>2.17.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.

  reply	other threads:[~2020-05-20  7:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20  6:39 [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured Leyi Rong
2020-05-20  7:10 ` Ye Xiaolong [this message]
2020-05-20  7:56 ` Peng, Yuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200520071041.GA99392@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=leyi.rong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.