From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CCF8C433DF for ; Wed, 20 May 2020 07:15:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00758206C3 for ; Wed, 20 May 2020 07:15:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="maHFuP4p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00758206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gcUcQlViVVPAXnoGIr61t8adnk3nbrh+HaiFZYWVNao=; b=maHFuP4pFnBoTB 6lxnw3efOvFrzK5CdLBfFjM5c1lVqhGVQ6k8ayU10/1zUmsIh2BwqIfjExeDeTTjxVEkQN24zYlHk SGijt7jlMln+DdOG24raIW2rNLtJaEB/Rta9EDa1jMPry1vz5NYWCgEEnO4ZeAPjc2zPj+wuxTGjU ZfhIDOswDOY1+odmsORA+WrRIKK82Q+hpP9dwPGmaSUsJc5FH0/i0MFJN/5MBUPcQBxCiv8bVLEgm 6QAV3P71W2E0gwrqnDwYu7ROSEn8yYbDRELBGmG5Z/PC5pUPI5CUL+FQJDxoq9NXaZjt9eecuNGnH Ycju2fu17M7o9BAlFPRw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbIwq-0000i7-8c; Wed, 20 May 2020 07:15:28 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbIwo-0000hI-Ha; Wed, 20 May 2020 07:15:26 +0000 Date: Wed, 20 May 2020 00:15:26 -0700 From: Christoph Hellwig To: Sagi Grimberg Subject: Re: [PATCH v2 2/2] nvmet: avoid memleak by freeing any remaining aens in nvmet_async_events_free Message-ID: <20200520071526.GA7008@infradead.org> References: <1589828396-144513-1-git-send-email-dmilburn@redhat.com> <1589828396-144513-3-git-send-email-dmilburn@redhat.com> <388242d3-5ccc-d694-c7a0-ac489f63f26a@grimberg.me> <20200520061613.GA18308@infradead.org> <0018af56-e3f9-8730-3c57-c4f19e478014@grimberg.me> <20200520070330.GA26871@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christoph Hellwig , David Milburn , chaitanya.kulkarni@wdc.com, dwagner@suse.de, linux-nvme@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, May 20, 2020 at 12:08:54AM -0700, Sagi Grimberg wrote: > :) I guess the pandemic got to me... > > Things make a lot more sense now. But don't we need to move the aens > free to after we remove the controller from the subsys->ctrls? Yes. I also think we can clean up a few things here. How about I apply the series from David now and send a few additional fixups on top? _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme