Re: [PATCH 1/2] MAINTAINERS: Add entry for ROHM power management ICs

[Lee Jones <lee.jones@linaro.org>]

On Wed, 20 May 2020, Vaittinen, Matti wrote:

> Morning Lee,
> 
> On Wed, 2020-05-20 at 07:35 +0100, Lee Jones wrote:
> > On Wed, 20 May 2020, Matti Vaittinen wrote:
> > 
> > > Add entry for maintaining power management IC drivers for ROHM
> > > BD71837, BD71847, BD71850, BD71828, BD71878, BD70528 and BD99954.
> > > 
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > > ---
> > >  MAINTAINERS | 30 ++++++++++++++++++++++++++++++
> > >  1 file changed, 30 insertions(+)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index ecc0749810b0..63a2ca70540e 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -14490,6 +14490,12 @@ L:	linux-serial@vger.kernel.org
> > >  S:	Odd Fixes
> > >  F:	drivers/tty/serial/rp2.*
> > >  
> > > +ROHM BD99954 CHARGER IC
> > > +R:	Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > > +S:	Supported
> > > +F:	drivers/power/supply/bd99954-charger.c
> > > +F:	drivers/power/supply/bd99954-charger.h
> > > +
> > >  ROHM BH1750 AMBIENT LIGHT SENSOR DRIVER
> > >  M:	Tomasz Duszynski <tduszyns@gmail.com>
> > >  S:	Maintained
> > > @@ -14507,6 +14513,30 @@ F:	drivers/mfd/bd9571mwv.c
> > >  F:	drivers/regulator/bd9571mwv-regulator.c
> > >  F:	include/linux/mfd/bd9571mwv.h
> > >  
> > > +ROHM POWER MANAGEMENT IC DEVICE DRIVERS
> > > +R:	Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > > +S:	Supported
> > > +F:	Documentation/devicetree/bindings/mfd/rohm,bd70528-pmic.txt
> > > +F:	Documentation/devicetree/bindings/regulator/rohm,bd70528-
> > > regulator.txt
> > > +F:	drivers/clk/clk-bd718x7.c
> > > +F:	drivers/gpio/gpio-bd70528.c
> > > +F:	drivers/gpio/gpio-bd71828.c
> > > +F:	drivers/mfd/rohm-bd70528.c
> > > +F:	drivers/mfd/rohm-bd71828.c
> > > +F:	drivers/mfd/rohm-bd718x7.c
> > > +F:	drivers/power/supply/bd70528-charger.c
> > > +F:	drivers/regulator/bd70528-regulator.c
> > > +F:	drivers/regulator/bd71828-regulator.c
> > > +F:	drivers/regulator/bd718x7-regulator.c
> > > +F:	drivers/regulator/rohm-regulator.c
> > > +F:	drivers/rtc/rtc-bd70528.c
> > > +F:	drivers/watchdog/bd70528_wdt.c
> > > +F:	include/linux/mfd/rohm-shared.h
> > > +F:	include/linux/mfd/rohm-bd71828.h
> > > +F:	include/linux/mfd/rohm-bd70528.h
> > > +F:	include/linux/mfd/rohm-generic.h
> > > +F:	include/linux/mfd/rohm-bd718x7.h
> > 
> > How small can you get this list using wildcards?
> I was considering this but wildcards are somewhat error prone. I can't
> guarantee they don't match to drivers which I am not working with :(
> The BDxxxxx is common for pretty much all ROHM ICs (well, theres few
> other like BUxxxxx and BHxxxxx) - and there is huge amount of ICs.
> Hence I think it is likely the wildcards (will) match to drivers
> maintained by others.
> 
> One already existing example is:
> ROHM MULTIFUNCTION BD9571MWV-M PMIC DEVICE DRIVERS
> M:      Marek Vasut <marek.vasut+renesas@gmail.com>
> L:      linux-kernel@vger.kernel.org
> L:      linux-renesas-soc@vger.kernel.org
> S:      Supported          
> F:      Documentation/devicetree/bindings/mfd/bd9571mwv.txt          
> F:      drivers/gpio/gpio-bd9571mwv.c
> F:      drivers/mfd/bd9571mwv.c          
> F:      drivers/regulator/bd9571mwv-regulator.c
> F:      include/linux/mfd/bd9571mwv.h
> 
> also LEDs have some ROHM IC drivers which I am not familiar with.
> 
> > +F:	drivers/clk/clk-bd718x7.c
> > +F:	drivers/gpio/gpio-bd7*
> > +F:	drivers/mfd/rohm-bd7*
> > +F:	drivers/power/supply/bd7*
> > +F:	drivers/regulator/bd7*
> > +F:	drivers/regulator/rohm-regulator.c
> > +F:	drivers/rtc/rtc-bd7*
> > +F:	drivers/watchdog/bd7*
> > +F:	include/linux/mfd/rohm-*
> > 
> > Or
> > 
> > +F:	drivers/*/bd7*
> > +F:	drivers/*/*-bd7*
> > +F:	drivers/*/rohm-*
> > +F:	drivers/*/*rohm-*
> > +F:	include/linux/*/rohm-*
> > +F:	include/linux/*/*rohm-*
> > 
> > Not checked either of these.  They are just an example.
> 
> So, I am sure I can find a working match pattern for a few of the files
> - but if using wildcards is not compulsory I'd rather not do that as I
> have a feeling this will cause wrong matches...

That's fine.  So long as you've thought about it.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog