From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Edward Cree <ecree@solarflare.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, jiri@resnulli.us,
kuba@kernel.org
Subject: Re: [PATCH v3 net-next] net: flow_offload: simplify hw stats check handling
Date: Wed, 20 May 2020 19:32:16 +0200 [thread overview]
Message-ID: <20200520173216.GA28641@salvia> (raw)
In-Reply-To: <f2586a0e-fce1-cee9-e2dc-f3dc73500515@solarflare.com>
On Wed, May 20, 2020 at 06:31:05PM +0100, Edward Cree wrote:
> On 20/05/2020 18:21, Edward Cree wrote:
> > @@ -582,7 +590,7 @@ nf_flow_offload_rule_alloc(struct net *net,
> > const struct flow_offload_tuple *tuple;
> > struct nf_flow_rule *flow_rule;
> > struct dst_entry *other_dst;
> > - int err = -ENOMEM;
> > + int err = -ENOMEM, i;
> >
> > flow_rule = kzalloc(sizeof(*flow_rule), GFP_KERNEL);
> > if (!flow_rule)
> Whoops, this changebar isn't meant to be there. Somehow I missed
> the unused var warning when I built it, too.
> Drop this, I'll spin v4.
The nf_tables_offload.c update is missing, please include this in v4.
next prev parent reply other threads:[~2020-05-20 17:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 17:21 [PATCH v3 net-next] net: flow_offload: simplify hw stats check handling Edward Cree
2020-05-20 17:31 ` Edward Cree
2020-05-20 17:32 ` Pablo Neira Ayuso [this message]
2020-05-20 17:52 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520173216.GA28641@salvia \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.