From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Wed, 20 May 2020 17:37:52 +0000 Subject: Re: [PATCH resend] scsi: lpfc: Fix a use after free in lpfc_nvme_unsol_ls_handler() Message-Id: <20200520173752.GA13546@infradead.org> List-Id: References: <20200515101903.GJ3041@kadam> <20200520165557.GA9700@infradead.org> <20200520172433.GD30374@kadam> <20200520172844.GA21006@infradead.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Martin K. Petersen" Cc: Jens Axboe , Dick Kennedy , linux-scsi@vger.kernel.org, "James E.J. Bottomley" , kernel-janitors@vger.kernel.org, James Smart , linux-nvme@lists.infradead.org, Christoph Hellwig , Paul Ely , Hannes Reinecke , Dan Carpenter On Wed, May 20, 2020 at 01:33:12PM -0400, Martin K. Petersen wrote: > > Christoph, > > > On Wed, May 20, 2020 at 08:24:33PM +0300, Dan Carpenter wrote: > >> On Wed, May 20, 2020 at 09:55:57AM -0700, Christoph Hellwig wrote: > >> > James, can you review this patch? > >> > >> He already reviewed it in a different thread. I copied his R-b tag. > > > > James, should this go into the nvme or scsi tree? > > The offending patch is in the nvme tree so I think you should take > it. Otherwise I'll pick it up in 5.8/scsi-fixes. I'll pick it up. Can you give me an ACK for it to show Jens you are ok with that? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43306C433DF for ; Wed, 20 May 2020 17:37:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 161D020709 for ; Wed, 20 May 2020 17:37:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f9SCJBma" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 161D020709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BTuD3AuQmh/6g4jsr2isA+1fK5tU+jZNHmAkzy/vh0w=; b=f9SCJBmaORe/pN wZt/Ym3iq1N5Py8DqKxKo6IYRWZjo9uPR2KYT56xrv/rtzoHftQlde0sP2LKzQowRPWEQGf6voTVy IbGn2dYQZmMiOi7c0ACPG6G/lOh4iSGKDzh0afSmrXU1x28jEC5t48dKfRGavG4msI1dGEBeJ5LzL tIvr2KfGhwKo4UObR04lwtkg4oHzYQ8GYUtzOPGcNMg2eKU18SDH+F9BvNsllCMONSq9cvK0BSb1k LU9P3vqCCyGRDSwu1CQGMU0odQ5VvKfYKpsCLzUUYNdMKjD6zdMXWxFB+QntXTJOr77N08qvtZE+4 GWsgT4VpcZxSPXlsJcaw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbSfC-0003op-8V; Wed, 20 May 2020 17:37:54 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbSfA-0003oD-Pe; Wed, 20 May 2020 17:37:52 +0000 Date: Wed, 20 May 2020 10:37:52 -0700 From: Christoph Hellwig To: "Martin K. Petersen" Subject: Re: [PATCH resend] scsi: lpfc: Fix a use after free in lpfc_nvme_unsol_ls_handler() Message-ID: <20200520173752.GA13546@infradead.org> References: <20200515101903.GJ3041@kadam> <20200520165557.GA9700@infradead.org> <20200520172433.GD30374@kadam> <20200520172844.GA21006@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Dick Kennedy , linux-scsi@vger.kernel.org, "James E.J. Bottomley" , kernel-janitors@vger.kernel.org, James Smart , linux-nvme@lists.infradead.org, Christoph Hellwig , Paul Ely , Hannes Reinecke , Dan Carpenter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, May 20, 2020 at 01:33:12PM -0400, Martin K. Petersen wrote: > > Christoph, > > > On Wed, May 20, 2020 at 08:24:33PM +0300, Dan Carpenter wrote: > >> On Wed, May 20, 2020 at 09:55:57AM -0700, Christoph Hellwig wrote: > >> > James, can you review this patch? > >> > >> He already reviewed it in a different thread. I copied his R-b tag. > > > > James, should this go into the nvme or scsi tree? > > The offending patch is in the nvme tree so I think you should take > it. Otherwise I'll pick it up in 5.8/scsi-fixes. I'll pick it up. Can you give me an ACK for it to show Jens you are ok with that? _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB356C433DF for ; Wed, 20 May 2020 17:37:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9289207D3 for ; Wed, 20 May 2020 17:37:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="SutOa2KO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726790AbgETRhy (ORCPT ); Wed, 20 May 2020 13:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726619AbgETRhy (ORCPT ); Wed, 20 May 2020 13:37:54 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90528C061A0E; Wed, 20 May 2020 10:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BeLPmgjsAaqg+lCrRO3FyRGdfLRcs8x/aSEyt/Sy+OE=; b=SutOa2KORAOtNwbKH25hVrUAWw /pqCTvQRMEhl/ycW+gJ6IubyOETsdTWvChPu5pS7YLODEeCS4CMiCScnEOg0xsZnlzqh4l2jdgCwu j09L/l7TIy2JWVq4FiWFuqqbWG7zpqT59R919kZzARr50daJHSHymUY2T6iWyBYK9nbNBHVmihifQ wBeVjM7eFimChQW5015F1vsu9MqABDxj/ClgoAdFkC8wLPKpcvkbD6QeHBOot8xsGkye5lwpjezP5 mlybmtWDo0Zfgn6/uS3KSWkv3JtLmQOawHZby3dCKJEQqASDHOcz7LAU3+b+/aMPlFWRjfQZJ+eEt M/t2x6og==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbSfA-0003oD-Pe; Wed, 20 May 2020 17:37:52 +0000 Date: Wed, 20 May 2020 10:37:52 -0700 From: Christoph Hellwig To: "Martin K. Petersen" Cc: Christoph Hellwig , Dan Carpenter , James Smart , linux-nvme@lists.infradead.org, Jens Axboe , Dick Kennedy , linux-scsi@vger.kernel.org, "James E.J. Bottomley" , kernel-janitors@vger.kernel.org, Paul Ely , Hannes Reinecke Subject: Re: [PATCH resend] scsi: lpfc: Fix a use after free in lpfc_nvme_unsol_ls_handler() Message-ID: <20200520173752.GA13546@infradead.org> References: <20200515101903.GJ3041@kadam> <20200520165557.GA9700@infradead.org> <20200520172433.GD30374@kadam> <20200520172844.GA21006@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Wed, May 20, 2020 at 01:33:12PM -0400, Martin K. Petersen wrote: > > Christoph, > > > On Wed, May 20, 2020 at 08:24:33PM +0300, Dan Carpenter wrote: > >> On Wed, May 20, 2020 at 09:55:57AM -0700, Christoph Hellwig wrote: > >> > James, can you review this patch? > >> > >> He already reviewed it in a different thread. I copied his R-b tag. > > > > James, should this go into the nvme or scsi tree? > > The offending patch is in the nvme tree so I think you should take > it. Otherwise I'll pick it up in 5.8/scsi-fixes. I'll pick it up. Can you give me an ACK for it to show Jens you are ok with that?