From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Down Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Date: Wed, 20 May 2020 20:09:06 +0100 Message-ID: <20200520190906.GA558281@chrisdown.name> References: <20200501135806.4eebf0b92f84ab60bba3e1e7@linux-foundation.org> <20200519075213.GF32497@dhcp22.suse.cz> <20200519084535.GG32497@dhcp22.suse.cz> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tl5hNSaq9jwtAfQ3H4b6ZmG+ScLEKqnmbeQTtX38GBs=; b=ejWrZ/jfJqN1W3XBa5rEh8Lk4R2pGtjUsAfERal12GI7QfCZfWLDd9UtMrTSYE1/tI FovDCSwIGfbaaHj8cZJ1IKJDULyXaqYHAyGtIE65kUKbthWtIjz/KQGrx+y85v2kRRQb 81QOjyfbBp6VHvsSe4y3k88jU+q/CRx/ohQyM= Content-Disposition: inline In-Reply-To: Sender: linux-block-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" Content-Transfer-Encoding: 7bit To: Naresh Kamboju Cc: Yafang Shao , Michal Hocko , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@l Hi Naresh, Naresh Kamboju writes: >As a part of investigation on this issue LKFT teammate Anders Roxell >git bisected the problem and found bad commit(s) which caused this problem. > >The following two patches have been reverted on next-20200519 and retested the >reproducible steps and confirmed the test case mkfs -t ext4 got PASS. >( invoked oom-killer is gone now) > >Revert "mm, memcg: avoid stale protection values when cgroup is above >protection" > This reverts commit 23a53e1c02006120f89383270d46cbd040a70bc6. > >Revert "mm, memcg: decouple e{low,min} state mutations from protection >checks" > This reverts commit 7b88906ab7399b58bb088c28befe50bcce076d82. Thanks Anders and Naresh for tracking this down and reverting. I'll take a look tomorrow. I don't see anything immediately obviously wrong in either of those commits from a (very) cursory glance, but they should only be taking effect if protections are set. Since you have i386 hardware available, and I don't, could you please apply only "avoid stale protection" again and check if it only happens with that commit, or requires both? That would help narrow down the suspects. Do you use any memcg protections in these tests? Thank you! Chris From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D060CC433DF for ; Wed, 20 May 2020 19:09:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8B43207D4 for ; Wed, 20 May 2020 19:09:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="ejWrZ/jf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726697AbgETTJM (ORCPT ); Wed, 20 May 2020 15:09:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726790AbgETTJK (ORCPT ); Wed, 20 May 2020 15:09:10 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38C21C08C5C0 for ; Wed, 20 May 2020 12:09:10 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id f13so3741249edr.13 for ; Wed, 20 May 2020 12:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tl5hNSaq9jwtAfQ3H4b6ZmG+ScLEKqnmbeQTtX38GBs=; b=ejWrZ/jfJqN1W3XBa5rEh8Lk4R2pGtjUsAfERal12GI7QfCZfWLDd9UtMrTSYE1/tI FovDCSwIGfbaaHj8cZJ1IKJDULyXaqYHAyGtIE65kUKbthWtIjz/KQGrx+y85v2kRRQb 81QOjyfbBp6VHvsSe4y3k88jU+q/CRx/ohQyM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tl5hNSaq9jwtAfQ3H4b6ZmG+ScLEKqnmbeQTtX38GBs=; b=kdT4RvOlbtX+Ux4qNOIQ53CIfNoxLoPJXbZezcBu3bhiuWDa9GVhKoXbHGcqyHWF7m wwITBK6oBL7TtTKX76eIaPERYOgIK0fFWlyLSgDVsdYvLXjSIkdjkx4fwtZVCJZj8Yfl oOe7A5DnvEo6/tIIaXD/lUhta5u9qdfsDfQLeyfUA6wc3VsyJO2bdMCUktzEZPvFPh9b RbrekK3Udxy5HUb/Y5OT2moRO39tCkn60F4sG0LMn1LDK3jxFa0K4zPdpbtpfd37aAAf CpxHWwP5qLyZNqsrYKJXJn5i9/dux6nUMMpx3ruPsuOYCrF4oIrHVgLTD0fF575T3b09 mg3A== X-Gm-Message-State: AOAM531Bh6H7jPGneinQR4a1FfDuqHkD/O8Uge5K+zc26zYJoCqgg+zi zVnQrSiutulwtKJLjrOz7LMENA== X-Google-Smtp-Source: ABdhPJweTP3W62AzAZrqweXxsUYkSWvtaZ1Wr8JxuA7F/wzgya+W3/hBf6pFGJ7YDBt9fmp3P99NeQ== X-Received: by 2002:a50:9312:: with SMTP id m18mr4674386eda.252.1590001748698; Wed, 20 May 2020 12:09:08 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:758d]) by smtp.gmail.com with ESMTPSA id g21sm2514869edw.9.2020.05.20.12.09.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 12:09:08 -0700 (PDT) Date: Wed, 20 May 2020 20:09:06 +0100 From: Chris Down To: Naresh Kamboju Cc: Yafang Shao , Michal Hocko , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , cgroups@vger.kernel.org Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Message-ID: <20200520190906.GA558281@chrisdown.name> References: <20200501135806.4eebf0b92f84ab60bba3e1e7@linux-foundation.org> <20200519075213.GF32497@dhcp22.suse.cz> <20200519084535.GG32497@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Hi Naresh, Naresh Kamboju writes: >As a part of investigation on this issue LKFT teammate Anders Roxell >git bisected the problem and found bad commit(s) which caused this problem. > >The following two patches have been reverted on next-20200519 and retested the >reproducible steps and confirmed the test case mkfs -t ext4 got PASS. >( invoked oom-killer is gone now) > >Revert "mm, memcg: avoid stale protection values when cgroup is above >protection" > This reverts commit 23a53e1c02006120f89383270d46cbd040a70bc6. > >Revert "mm, memcg: decouple e{low,min} state mutations from protection >checks" > This reverts commit 7b88906ab7399b58bb088c28befe50bcce076d82. Thanks Anders and Naresh for tracking this down and reverting. I'll take a look tomorrow. I don't see anything immediately obviously wrong in either of those commits from a (very) cursory glance, but they should only be taking effect if protections are set. Since you have i386 hardware available, and I don't, could you please apply only "avoid stale protection" again and check if it only happens with that commit, or requires both? That would help narrow down the suspects. Do you use any memcg protections in these tests? Thank you! Chris From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F56C433DF for ; Wed, 20 May 2020 20:06:21 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60F9420748 for ; Wed, 20 May 2020 20:06:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="AgFSRAZ+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="Mi9oXbXm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="ejWrZ/jf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60F9420748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jbUyq-0003PO-58; Wed, 20 May 2020 20:06:20 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbUyo-0003PH-Mb for linux-f2fs-devel@lists.sourceforge.net; Wed, 20 May 2020 20:06:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tl5hNSaq9jwtAfQ3H4b6ZmG+ScLEKqnmbeQTtX38GBs=; b=AgFSRAZ+5XmNBYYgJScgZcS8Kb nXvMRX/t4R3EQOf2mo4ZwkQoE7P9w61mq7n+J+j6DRtfIJidJGLpQS6zEJEJecFoma2VV03hgMdCF kWk8J5ioSrmx+SKjJPrv12mITTQUCuX+N0M6KJgAFUgpsp6Wc5N7lCmdW5L9gzj2f+EA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tl5hNSaq9jwtAfQ3H4b6ZmG+ScLEKqnmbeQTtX38GBs=; b=Mi9oXbXmTLsqSQJiFAeVIUjr1P Sqp26ZNN5fr49LQW2v5hzH7MSai7UukHptZyN3Wk2qywZsQgy4aBqjZ76HdWsi25UeEmmVVhAqscz fS9ZcuozRUb/+p8G22FYLmGBbjapuBq8bqvXETq1mFfczIbeAyygKtbH7ZIsjAH/TG5o=; Received: from mail-ed1-f68.google.com ([209.85.208.68]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1jbUyl-002TJz-2t for linux-f2fs-devel@lists.sourceforge.net; Wed, 20 May 2020 20:06:18 +0000 Received: by mail-ed1-f68.google.com with SMTP id i16so4560439edv.1 for ; Wed, 20 May 2020 13:06:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tl5hNSaq9jwtAfQ3H4b6ZmG+ScLEKqnmbeQTtX38GBs=; b=ejWrZ/jfJqN1W3XBa5rEh8Lk4R2pGtjUsAfERal12GI7QfCZfWLDd9UtMrTSYE1/tI FovDCSwIGfbaaHj8cZJ1IKJDULyXaqYHAyGtIE65kUKbthWtIjz/KQGrx+y85v2kRRQb 81QOjyfbBp6VHvsSe4y3k88jU+q/CRx/ohQyM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tl5hNSaq9jwtAfQ3H4b6ZmG+ScLEKqnmbeQTtX38GBs=; b=B0PB3B2PktFkTgJy8scqdoAmsIARkpDGp4HnzYfW5pm//0z8oRNvLTVHaTtH6FEXiE 0OIACfBColRe8Nc6g2qznx2ukX8hgBLZpuXPhLB98aFvrLpnB820AUaDC+v40C6LuK2l Ux3lQAZag50j7kxJcDXeqIYf6tm/riF/B5tN4dKyasY0jtMbeEhTzN7rKcwYdDZ0WULT FHqlkcDq0e0dOpmXtb4k7qB7JZEyw6Vj9dUFqTkG/pjaRl2/tn1g+JO0CJM7TTO8UF3o LgD0SRNNy1HoIsDw+7nFrbv9d2nFtFkJzzh7UcjfdLGDhz1nAbBqHCW8olCDJbJI0ryZ iBWQ== X-Gm-Message-State: AOAM53162qv4xeqngNCS4xuEKs0QWQNrBMpMQMgSQgE+qRZgTpX6l/jD 71MEbfg7nYp6Jel2DJkx5TlNDarH1uipF5is X-Google-Smtp-Source: ABdhPJweTP3W62AzAZrqweXxsUYkSWvtaZ1Wr8JxuA7F/wzgya+W3/hBf6pFGJ7YDBt9fmp3P99NeQ== X-Received: by 2002:a50:9312:: with SMTP id m18mr4674386eda.252.1590001748698; Wed, 20 May 2020 12:09:08 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:758d]) by smtp.gmail.com with ESMTPSA id g21sm2514869edw.9.2020.05.20.12.09.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 12:09:08 -0700 (PDT) Date: Wed, 20 May 2020 20:09:06 +0100 From: Chris Down To: Naresh Kamboju Message-ID: <20200520190906.GA558281@chrisdown.name> References: <20200501135806.4eebf0b92f84ab60bba3e1e7@linux-foundation.org> <20200519075213.GF32497@dhcp22.suse.cz> <20200519084535.GG32497@dhcp22.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1jbUyl-002TJz-2t Subject: Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lkft-triage@lists.linaro.org, Michal Hocko , linux-mm , Yafang Shao , Andreas Dilger , cgroups@vger.kernel.org, Andrea Arcangeli , Anders Roxell , Hugh Dickins , Matthew Wilcox , Linux-Next Mailing List , linux-ext4 , Arnd Bergmann , linux-block , Jaegeuk Kim , Theodore Ts'o , open list , "Linux F2FS DEV, Mailing List" , Johannes Weiner , Andrew Morton , Roman Gushchin Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hi Naresh, Naresh Kamboju writes: >As a part of investigation on this issue LKFT teammate Anders Roxell >git bisected the problem and found bad commit(s) which caused this problem. > >The following two patches have been reverted on next-20200519 and retested the >reproducible steps and confirmed the test case mkfs -t ext4 got PASS. >( invoked oom-killer is gone now) > >Revert "mm, memcg: avoid stale protection values when cgroup is above >protection" > This reverts commit 23a53e1c02006120f89383270d46cbd040a70bc6. > >Revert "mm, memcg: decouple e{low,min} state mutations from protection >checks" > This reverts commit 7b88906ab7399b58bb088c28befe50bcce076d82. Thanks Anders and Naresh for tracking this down and reverting. I'll take a look tomorrow. I don't see anything immediately obviously wrong in either of those commits from a (very) cursory glance, but they should only be taking effect if protections are set. Since you have i386 hardware available, and I don't, could you please apply only "avoid stale protection" again and check if it only happens with that commit, or requires both? That would help narrow down the suspects. Do you use any memcg protections in these tests? Thank you! Chris _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel