From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [linux-next:master 10267/10701] drivers/clocksource/timer-ti-dm-systimer.c:517:6: warning: variable 'pa' set but not used
Date: Wed, 20 May 2020 19:36:52 +0800 [thread overview]
Message-ID: <202005201949.5koOb5uB%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4472 bytes --]
Hi Tony,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: fb57b1fabcb28f358901b2df90abd2b48abc1ca8
commit: aba1ad05da088944a62eb87fb0cd8391152e8985 [10267/10701] clocksource/drivers/timer-ti-dm: Add clockevent and clocksource support
config: arm-randconfig-r013-20200519 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout aba1ad05da088944a62eb87fb0cd8391152e8985
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/clocksource/timer-ti-dm-systimer.c: In function 'dmtimer_clockevent_init':
>> drivers/clocksource/timer-ti-dm-systimer.c:517:6: warning: variable 'pa' set but not used [-Wunused-but-set-variable]
517 | u32 pa;
| ^~
drivers/clocksource/timer-ti-dm-systimer.c: In function 'dmtimer_clocksource_init':
drivers/clocksource/timer-ti-dm-systimer.c:640:6: warning: variable 'pa' set but not used [-Wunused-but-set-variable]
640 | u32 pa;
| ^~
vim +/pa +517 drivers/clocksource/timer-ti-dm-systimer.c
510
511 static int __init dmtimer_clockevent_init(struct device_node *np)
512 {
513 struct dmtimer_clockevent *clkevt;
514 struct clock_event_device *dev;
515 struct dmtimer_systimer *t;
516 int error;
> 517 u32 pa;
518
519 clkevt = kzalloc(sizeof(*clkevt), GFP_KERNEL);
520 if (!clkevt)
521 return -ENOMEM;
522
523 t = &clkevt->t;
524 dev = &clkevt->dev;
525
526 /*
527 * We mostly use cpuidle_coupled with ARM local timers for runtime,
528 * so there's probably no use for CLOCK_EVT_FEAT_DYNIRQ here.
529 */
530 dev->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT;
531 dev->rating = 300;
532 dev->set_next_event = dmtimer_set_next_event;
533 dev->set_state_shutdown = dmtimer_clockevent_shutdown;
534 dev->set_state_periodic = dmtimer_set_periodic;
535 dev->set_state_oneshot = dmtimer_clockevent_shutdown;
536 dev->tick_resume = dmtimer_clockevent_shutdown;
537 dev->cpumask = cpu_possible_mask;
538
539 dev->irq = irq_of_parse_and_map(np, 0);
540 if (!dev->irq) {
541 error = -ENXIO;
542 goto err_out_free;
543 }
544
545 error = dmtimer_systimer_setup(np, &clkevt->t);
546 if (error)
547 goto err_out_free;
548
549 clkevt->period = 0xffffffff - DIV_ROUND_CLOSEST(t->rate, HZ);
550
551 /*
552 * For clock-event timers we never read the timer counter and
553 * so we are not impacted by errata i103 and i767. Therefore,
554 * we can safely ignore this errata for clock-event timers.
555 */
556 writel_relaxed(OMAP_TIMER_CTRL_POSTED, t->base + t->ifctrl);
557
558 error = request_irq(dev->irq, dmtimer_clockevent_interrupt,
559 IRQF_TIMER, "clockevent", clkevt);
560 if (error)
561 goto err_out_unmap;
562
563 writel_relaxed(OMAP_TIMER_INT_OVERFLOW, t->base + t->irq_ena);
564 writel_relaxed(OMAP_TIMER_INT_OVERFLOW, t->base + t->wakeup);
565
566 pa = of_translate_address(np, of_get_address(np, 0, NULL, NULL));
567 pr_info("TI gptimer clockevent: %s%lu Hz at %pOF\n",
568 of_find_property(np, "ti,timer-alwon", NULL) ?
569 "always-on " : "", t->rate, np->parent);
570
571 clockevents_config_and_register(dev, t->rate,
572 3, /* Timer internal resynch latency */
573 0xffffffff);
574
575 if (of_device_is_compatible(np, "ti,am33xx") ||
576 of_device_is_compatible(np, "ti,am43")) {
577 dev->suspend = omap_clockevent_idle;
578 dev->resume = omap_clockevent_unidle;
579 }
580
581 return 0;
582
583 err_out_unmap:
584 iounmap(t->base);
585
586 err_out_free:
587 kfree(clkevt);
588
589 return error;
590 }
591
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41923 bytes --]
next reply other threads:[~2020-05-20 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 11:36 kbuild test robot [this message]
2020-05-20 15:33 ` [linux-next:master 10267/10701] drivers/clocksource/timer-ti-dm-systimer.c:517:6: warning: variable 'pa' set but not used Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202005201949.5koOb5uB%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.