From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 354A8C433E0 for ; Wed, 20 May 2020 21:00:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E64C720829 for ; Wed, 20 May 2020 20:59:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590008400; bh=6IM+pEQZvjfC0rYCgRnS/0xyuS/cB4PaMWcH0egNJvQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gULSmd0Z2HQml/CPrIkddDZUEy96Rh3sWDjfjlM4R+zxR+OptOnOESoJylQ6RffXM RWWOpKQrBb3wBd8muTHm5ufLqIG0aZU/oO0X4II2M3rbKN1DgCaPZaYdTHmTbI0/sP 7+osJsg9vFGb0c+fuMo79i21YUbld6THyeOzBNsQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728181AbgETU77 (ORCPT ); Wed, 20 May 2020 16:59:59 -0400 Received: from mail-il1-f195.google.com ([209.85.166.195]:36074 "EHLO mail-il1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727864AbgETU77 (ORCPT ); Wed, 20 May 2020 16:59:59 -0400 Received: by mail-il1-f195.google.com with SMTP id 17so4793070ilj.3; Wed, 20 May 2020 13:59:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UAntt9LZM4aXhtYbB5IsDq5XlgAc1476xVm09j70Cvc=; b=BCnLh7qdISOoNSsyP0mZFf208FmWrPt7enPnbMMGeccb9JUkk2cneIe9aHH0AUoKUL hhRAdMqVoHwKfSFPEt9Mn0rAinUhyoSNM8Gaw1nyPqbxYbltmQlm4gBLoo0lni1z1lUB 38n74WK8/T5XMr+zQpNhzEXNGuKmEQxEraFNhjL6P6O28r7Yw27+xaH+wWaOOL/ROCq1 3msfzsO/J7p9L6IdiUcOa2b0tIq1jPUZMTg/UYk8faHxiak9pRQijBQLOCaLArPwhCuV Vu/LUcPeyYVfMdevjZIO8DIxPL19BduVxIuEmH5D7r6Mdz/HVkn1qpFRL1oZPJwXFJP0 7n7Q== X-Gm-Message-State: AOAM533Bg8CAz5WBpy7+EdfC7yfw0uRhnQE/PM+dkCZ+G0KtumIqzGbY gAkold9zCeXz06GUXUcB0A== X-Google-Smtp-Source: ABdhPJzPaTCpz4Tn8plu0LlLEYCHFebPD9zDcz7rBBGbnzlj8cCSRMP2lemNIxHg9WTA5zFlXjkBKg== X-Received: by 2002:a92:afc6:: with SMTP id v67mr5758075ill.292.1590008397663; Wed, 20 May 2020 13:59:57 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id o70sm1993204ild.3.2020.05.20.13.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 13:59:57 -0700 (PDT) Received: (nullmailer pid 568868 invoked by uid 1000); Wed, 20 May 2020 20:59:56 -0000 Date: Wed, 20 May 2020 14:59:56 -0600 From: Rob Herring To: Kishon Vijay Abraham I Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tom Joseph , Arnd Bergmann , Bjorn Helgaas , Greg Kroah-Hartman , linux-omap@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 01/14] PCI: cadence: Fix cdns_pcie_{host|ep}_setup() error path Message-ID: <20200520205956.GA568767@bogus> References: <20200506151429.12255-1-kishon@ti.com> <20200506151429.12255-2-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200506151429.12255-2-kishon@ti.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Wed, 6 May 2020 20:44:16 +0530, Kishon Vijay Abraham I wrote: > commit bd22885aa188 ("PCI: cadence: Refactor driver to use as a core > library") while refactoring the Cadence PCIe driver to be used as > library, removed pm_runtime_get_sync() from cdns_pcie_ep_setup() > and cdns_pcie_host_setup() but missed to remove the corresponding > pm_runtime_put_sync() in the error path. Fix it here. > > Fixes: bd22885aa188 ("PCI: cadence: Refactor driver to use as a core library") > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/pci/controller/cadence/pcie-cadence-ep.c | 9 ++------- > drivers/pci/controller/cadence/pcie-cadence-host.c | 6 +----- > 2 files changed, 3 insertions(+), 12 deletions(-) > Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E528BC433DF for ; Wed, 20 May 2020 21:00:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B14C02084C for ; Wed, 20 May 2020 21:00:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MtAxER6G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B14C02084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VZ2pKSBGkiGrQTKAklCu23tI2G68Z4jxaz5yIDnip6o=; b=MtAxER6GPG9VuD spbvsWGrpSSSUVhhy+2S802kZ6PHvbSuissWEg5ilhZJLv9dRlJg99AxTVoYgyjp91V8KFqToRbX0 xNU2NsLlmkqmVUM95xlQUNCeB4szPGY5xxacnzRlhXUVb7vlLIOFtYjyl4zUPu4fJcg4cW/pAM5dr fRPeJbKwUepPg+2hI1TKSc1kOPtZCzoNC3Jr/8TMYAP32oiwXCte8+aDqXj2XaZ7D1yodcrj47W8t jiKEdCn1LfGzjYu/k+md589eGO6iwR/2QAEFEumVdv7c1DbuhOiNazmW3GMpQ6FGNZzyyHZuhU/CH VENaQ/QZ5R00NvTfLeQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbVon-0004Qg-My; Wed, 20 May 2020 21:00:01 +0000 Received: from mail-il1-f196.google.com ([209.85.166.196]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbVok-0004Om-O7 for linux-arm-kernel@lists.infradead.org; Wed, 20 May 2020 20:59:59 +0000 Received: by mail-il1-f196.google.com with SMTP id n11so4795847ilj.4 for ; Wed, 20 May 2020 13:59:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UAntt9LZM4aXhtYbB5IsDq5XlgAc1476xVm09j70Cvc=; b=IzaLoZJJPCwrtWV2puVg3+L+UhqhVBLBRIZow7Z2vMnJz2GcslhhXl+tAD29gli0d9 dFTPCXt6eF5DqHmztlRvR1uduJZ70MyyaMiaoVgE9SoxSKz5iarbs6tCRkRiLS0PMRw8 vyC//65AonvpxxP6PNKlQnM6Lnr5GQRJjP+RTv7UkBItBUEkiMexGH3J3JnLsSLYgdRV ae6Z4uFi//XRgWCzuclNwF7J3B51iDLrPSiCahm6H63F1RaJMZk0O92qRNC84YzFfpfs TNx/fSlzjKidWoV3EjafWC6jM/IuNrI3LXOPflSm2nWH9qhUl5uFRgVuaJ87xMI5Rjeu s6Wg== X-Gm-Message-State: AOAM531PX7OmY0w2exiPZmkQ72Xwk0bktEqJRjzA/XyudmnVxONKN1Bj U2bLZrki9fTpOoO84lvOJg== X-Google-Smtp-Source: ABdhPJzPaTCpz4Tn8plu0LlLEYCHFebPD9zDcz7rBBGbnzlj8cCSRMP2lemNIxHg9WTA5zFlXjkBKg== X-Received: by 2002:a92:afc6:: with SMTP id v67mr5758075ill.292.1590008397663; Wed, 20 May 2020 13:59:57 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id o70sm1993204ild.3.2020.05.20.13.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 13:59:57 -0700 (PDT) Received: (nullmailer pid 568868 invoked by uid 1000); Wed, 20 May 2020 20:59:56 -0000 Date: Wed, 20 May 2020 14:59:56 -0600 From: Rob Herring To: Kishon Vijay Abraham I Subject: Re: [PATCH v4 01/14] PCI: cadence: Fix cdns_pcie_{host|ep}_setup() error path Message-ID: <20200520205956.GA568767@bogus> References: <20200506151429.12255-1-kishon@ti.com> <20200506151429.12255-2-kishon@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200506151429.12255-2-kishon@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200520_135958_792014_E983E6AC X-CRM114-Status: GOOD ( 12.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tom Joseph , Rob Herring , linux-pci@vger.kernel.org, Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 6 May 2020 20:44:16 +0530, Kishon Vijay Abraham I wrote: > commit bd22885aa188 ("PCI: cadence: Refactor driver to use as a core > library") while refactoring the Cadence PCIe driver to be used as > library, removed pm_runtime_get_sync() from cdns_pcie_ep_setup() > and cdns_pcie_host_setup() but missed to remove the corresponding > pm_runtime_put_sync() in the error path. Fix it here. > > Fixes: bd22885aa188 ("PCI: cadence: Refactor driver to use as a core library") > Signed-off-by: Kishon Vijay Abraham I > --- > drivers/pci/controller/cadence/pcie-cadence-ep.c | 9 ++------- > drivers/pci/controller/cadence/pcie-cadence-host.c | 6 +----- > 2 files changed, 3 insertions(+), 12 deletions(-) > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel