From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay Date: Wed, 20 May 2020 20:39:13 -0300 Message-ID: <20200520233913.GV2491@localhost.localdomain> References: <20200520195509.2215098-1-hch@lst.de> <20200520195509.2215098-32-hch@lst.de> <20200520231001.GU2491@localhost.localdomain> <20200520.162355.2212209708127373208.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200520.162355.2212209708127373208.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Miller Cc: hch-jcswGhMUV9g@public.gmane.org, kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org, yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org, vyasevich-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, jmaloy-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ying.xue-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ocfs2-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sctp-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ceph-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: ceph-devel.vger.kernel.org On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 20 May 2020 20:10:01 -0300 > > > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > > API could be a bit more complete than that. > > The APIs are being designed based upon what in-tree users actually > make use of. We can expand things later if necessary. Sometimes expanding things later can be though, thus why the worry. But ok, I get it. Thanks. The comment still applies, though. (re the duplication) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Date: Wed, 20 May 2020 20:39:13 -0300 Subject: [Cluster-devel] [PATCH 31/33] sctp: add sctp_sock_set_nodelay In-Reply-To: <20200520.162355.2212209708127373208.davem@davemloft.net> References: <20200520195509.2215098-1-hch@lst.de> <20200520195509.2215098-32-hch@lst.de> <20200520231001.GU2491@localhost.localdomain> <20200520.162355.2212209708127373208.davem@davemloft.net> Message-ID: <20200520233913.GV2491@localhost.localdomain> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 20 May 2020 20:10:01 -0300 > > > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > > API could be a bit more complete than that. > > The APIs are being designed based upon what in-tree users actually > make use of. We can expand things later if necessary. Sometimes expanding things later can be though, thus why the worry. But ok, I get it. Thanks. The comment still applies, though. (re the duplication) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BDB7C433E0 for ; Wed, 20 May 2020 23:39:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A4EF20748 for ; Wed, 20 May 2020 23:39:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FsipvN1G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727040AbgETXjT (ORCPT ); Wed, 20 May 2020 19:39:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726697AbgETXjS (ORCPT ); Wed, 20 May 2020 19:39:18 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B934C061A0E; Wed, 20 May 2020 16:39:17 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id m44so4094210qtm.8; Wed, 20 May 2020 16:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=usgVE9wGsTmR3Ul4KmzuJXmMmNEoxcCV+K4pKCDDnEw=; b=FsipvN1GuGM9UbR7VsW4XkubLiUqC8Dqtu7L937s2qadx/bxbgPsMl9fWYiJlizujH c9qxkVWOxpVMlAT7nNkHzdOL6XRXbCOpar1C4DQC47Sws3swXaaqI9YAuQyLubSZ0OK0 rRko/wzRAKCkIy15w/nWQBRVBLwMvtGjJCE2gisIPTfPY2zdgnpj1FMzVNCnVI10QH79 YBAX7tezDRj2K0TOr70GJg9yP9kYgu14VxvOjzih8uvep1FVSB5EojcU0QtKwd0T+IdB hjRKTNxmgJ9liw0vUGr1peJpzaW/R/f+lsktCjxXTndLxOoBi3/frCJqvNi3QaPXR6GX kpaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=usgVE9wGsTmR3Ul4KmzuJXmMmNEoxcCV+K4pKCDDnEw=; b=NX+9uVe/yO0GL9KKvOXOHz5GefBwZRpFfy0UuHRq/9fs+d7Q54crmTq+eztKuFh4KV mrzbWrwiEF2044382M3G9Q8ipjtasHXxaTgrRfrg1RYxTHCm7fS2H2ArcoYXKnToO3dE Om5GFMxY/+u7KqgCb9kq2W2sZVymiitDmKy4DA3wEseC06UIt+1E1DK+wY4U3jydrwmv LXqXEbW0BXFdo6Bm0kQ6Ryvi6DPK/2qKTmhxkiPfs4/05L4icxx3gP9RTEARQkq0U2pn RQMMLV+aRGJoxOYKx6cq2unZSbgeV9mINAar97dF/XXoKCwgN0KU5W5FXpfdXXnNWSQd Y8fw== X-Gm-Message-State: AOAM530kitqhp7j8IZQRRpzIFXJBDZpaIJprNSrFUZrdCEHBVWeplmTB C59Pm4gBUHx/XTUg8i+HSa8= X-Google-Smtp-Source: ABdhPJzb0RQavdlFPdZ2esbonBQnAnxuJh+Wdn80ZrxdL0NcIMXKvb5xhinFWySzKcTGVqX7yVkgxA== X-Received: by 2002:ac8:1af3:: with SMTP id h48mr7625941qtk.371.1590017956516; Wed, 20 May 2020 16:39:16 -0700 (PDT) Received: from localhost.localdomain ([168.181.48.225]) by smtp.gmail.com with ESMTPSA id z10sm3685208qtu.22.2020.05.20.16.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 16:39:15 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 43E1FC0DAC; Wed, 20 May 2020 20:39:13 -0300 (-03) Date: Wed, 20 May 2020 20:39:13 -0300 From: Marcelo Ricardo Leitner To: David Miller Cc: hch@lst.de, kuba@kernel.org, edumazet@google.com, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, vyasevich@gmail.com, nhorman@tuxdriver.com, jmaloy@redhat.com, ying.xue@windriver.com, drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, ceph-devel@vger.kernel.org, rds-devel@oss.oracle.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay Message-ID: <20200520233913.GV2491@localhost.localdomain> References: <20200520195509.2215098-1-hch@lst.de> <20200520195509.2215098-32-hch@lst.de> <20200520231001.GU2491@localhost.localdomain> <20200520.162355.2212209708127373208.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520.162355.2212209708127373208.davem@davemloft.net> Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 20 May 2020 20:10:01 -0300 > > > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > > API could be a bit more complete than that. > > The APIs are being designed based upon what in-tree users actually > make use of. We can expand things later if necessary. Sometimes expanding things later can be though, thus why the worry. But ok, I get it. Thanks. The comment still applies, though. (re the duplication) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58E5FC433DF for ; Wed, 20 May 2020 23:39:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19FAA2072C for ; Wed, 20 May 2020 23:39:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XoYPJnlM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FsipvN1G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19FAA2072C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j+I+Ls3c6yVYDLwpbSRJgxemggVJSzN8vBi0Oc6P2JE=; b=XoYPJnlMuUtdPU Yyful9DauH9U7wlOmsHbDOBkYgz7TZycTEPu5Utic1djXZd7lfNYsJcbG9y56zVJkqCiSY6xUTiFJ GBJcQYyQytN4LRrYs+AcK5VCbGqKQc+cZEbqIWMiaFhOmIBkiDcdzH6U3UrlVxZoIaoVREsS4bI4f aO+G7qBjxLZiv8Kt2v/bMaLwrCYRyu64m68DKtGYHaeqgPjwxtxIvSG73+KhhZcpwFDPcxi5gAXUK i6cVXnozkSOuVf7P2WUTTN//Nv/wT+sXSLZsIeck/cTnOMS5qt9MigzOJ0wwUOSH1sWp4kpu3jl+A y9u7MUxOkRXG09cMdedw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbYIz-0007dZ-DL; Wed, 20 May 2020 23:39:21 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbYIw-0007cf-Cf; Wed, 20 May 2020 23:39:19 +0000 Received: by mail-qt1-x841.google.com with SMTP id o19so4081482qtr.10; Wed, 20 May 2020 16:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=usgVE9wGsTmR3Ul4KmzuJXmMmNEoxcCV+K4pKCDDnEw=; b=FsipvN1GuGM9UbR7VsW4XkubLiUqC8Dqtu7L937s2qadx/bxbgPsMl9fWYiJlizujH c9qxkVWOxpVMlAT7nNkHzdOL6XRXbCOpar1C4DQC47Sws3swXaaqI9YAuQyLubSZ0OK0 rRko/wzRAKCkIy15w/nWQBRVBLwMvtGjJCE2gisIPTfPY2zdgnpj1FMzVNCnVI10QH79 YBAX7tezDRj2K0TOr70GJg9yP9kYgu14VxvOjzih8uvep1FVSB5EojcU0QtKwd0T+IdB hjRKTNxmgJ9liw0vUGr1peJpzaW/R/f+lsktCjxXTndLxOoBi3/frCJqvNi3QaPXR6GX kpaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=usgVE9wGsTmR3Ul4KmzuJXmMmNEoxcCV+K4pKCDDnEw=; b=Zag0grC5Yb9ko1JUuSINyXvdAXNFsK8FOWawLUx4atU1VY5tFZvVWynnXmHPvH6RLq 7qlsUqmJDEEpBAsMh2A6osamygGsq6c2ASDZbnDL1k2EpQLZ2qN8tcTNudpyxJmT4DhU jLKuag5+LDeetIRCu0YP6rScm2lIUnUDP+nNo9ZMEI9sdUrsogzdqAOUzVF9pJBW/wc1 btQYZxHEomw3G0v/dtWZyU2DCjgPteFTWCAfs0dtNH4AO8EToFLIXBf2RQ0+Rp5xN9G5 uDreItfwyEuiUl0m/RweCGrvoi8/MaXtPOH5Ek+yKs+lnTPoZFLYoTQ6IWyI/mveLO5Y A1Ww== X-Gm-Message-State: AOAM533x+EGuxsFJDHZSrxwopLvFjHDl8rgssoAMo3Nf0U7EAo1xx/am Ds6/VNrF4JQhTBYBo8rvNPk= X-Google-Smtp-Source: ABdhPJzb0RQavdlFPdZ2esbonBQnAnxuJh+Wdn80ZrxdL0NcIMXKvb5xhinFWySzKcTGVqX7yVkgxA== X-Received: by 2002:ac8:1af3:: with SMTP id h48mr7625941qtk.371.1590017956516; Wed, 20 May 2020 16:39:16 -0700 (PDT) Received: from localhost.localdomain ([168.181.48.225]) by smtp.gmail.com with ESMTPSA id z10sm3685208qtu.22.2020.05.20.16.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 16:39:15 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 43E1FC0DAC; Wed, 20 May 2020 20:39:13 -0300 (-03) Date: Wed, 20 May 2020 20:39:13 -0300 From: Marcelo Ricardo Leitner To: David Miller Subject: Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay Message-ID: <20200520233913.GV2491@localhost.localdomain> References: <20200520195509.2215098-1-hch@lst.de> <20200520195509.2215098-32-hch@lst.de> <20200520231001.GU2491@localhost.localdomain> <20200520.162355.2212209708127373208.davem@davemloft.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200520.162355.2212209708127373208.davem@davemloft.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200520_163918_446361_D4A08281 X-CRM114-Status: UNSURE ( 9.31 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edumazet@google.com, linux-nvme@lists.infradead.org, linux-sctp@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, hch@lst.de, cluster-devel@redhat.com, kuznet@ms2.inr.ac.ru, kuba@kernel.org, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, nhorman@tuxdriver.com, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, vyasevich@gmail.com, linux-kernel@vger.kernel.org, jmaloy@redhat.com, ying.xue@windriver.com, ocfs2-devel@oss.oracle.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 20 May 2020 20:10:01 -0300 > > > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > > API could be a bit more complete than that. > > The APIs are being designed based upon what in-tree users actually > make use of. We can expand things later if necessary. Sometimes expanding things later can be though, thus why the worry. But ok, I get it. Thanks. The comment still applies, though. (re the duplication) _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Date: Wed, 20 May 2020 23:39:13 +0000 Subject: Re: [PATCH 31/33] sctp: add sctp_sock_set_nodelay Message-Id: <20200520233913.GV2491@localhost.localdomain> List-Id: References: <20200520195509.2215098-1-hch@lst.de> <20200520195509.2215098-32-hch@lst.de> <20200520231001.GU2491@localhost.localdomain> <20200520.162355.2212209708127373208.davem@davemloft.net> In-Reply-To: <20200520.162355.2212209708127373208.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: hch-jcswGhMUV9g@public.gmane.org, kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org, yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org, vyasevich-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, jmaloy-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ying.xue-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ocfs2-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sctp-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ceph-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 20 May 2020 20:10:01 -0300 > > > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > > API could be a bit more complete than that. > > The APIs are being designed based upon what in-tree users actually > make use of. We can expand things later if necessary. Sometimes expanding things later can be though, thus why the worry. But ok, I get it. Thanks. The comment still applies, though. (re the duplication) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Date: Wed, 20 May 2020 20:39:13 -0300 Subject: [Ocfs2-devel] [PATCH 31/33] sctp: add sctp_sock_set_nodelay In-Reply-To: <20200520.162355.2212209708127373208.davem@davemloft.net> References: <20200520195509.2215098-1-hch@lst.de> <20200520195509.2215098-32-hch@lst.de> <20200520231001.GU2491@localhost.localdomain> <20200520.162355.2212209708127373208.davem@davemloft.net> Message-ID: <20200520233913.GV2491@localhost.localdomain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: hch-jcswGhMUV9g@public.gmane.org, kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org, yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org, vyasevich-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, jmaloy-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ying.xue-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ocfs2-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sctp-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ceph-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rds-devel-N0ozoZBvEnrZJqsBc5GL+g@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 20 May 2020 20:10:01 -0300 > > > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > > API could be a bit more complete than that. > > The APIs are being designed based upon what in-tree users actually > make use of. We can expand things later if necessary. Sometimes expanding things later can be though, thus why the worry. But ok, I get it. Thanks. The comment still applies, though. (re the duplication) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 5992742041F for ; Sat, 13 Jun 2020 11:58:16 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id l10so12263371wrr.10 for ; Sat, 13 Jun 2020 02:58:16 -0700 (PDT) Received: from soda.linbit (62-99-137-214.static.upcbusiness.at. [62.99.137.214]) by smtp.gmail.com with ESMTPSA id b132sm12742537wmh.3.2020.06.13.02.58.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 13 Jun 2020 02:58:15 -0700 (PDT) Resent-Message-ID: <20200613095813.GO4222@soda.linbit> Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 8714D420309 for ; Thu, 21 May 2020 01:39:17 +0200 (CEST) Received: by mail-qt1-f194.google.com with SMTP id v4so4126621qte.3 for ; Wed, 20 May 2020 16:39:17 -0700 (PDT) From: Marcelo Ricardo Leitner To: David Miller Message-ID: <20200520233913.GV2491@localhost.localdomain> References: <20200520195509.2215098-1-hch@lst.de> <20200520195509.2215098-32-hch@lst.de> <20200520231001.GU2491@localhost.localdomain> <20200520.162355.2212209708127373208.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200520.162355.2212209708127373208.davem@davemloft.net> Cc: edumazet@google.com, linux-nvme@lists.infradead.org, linux-sctp@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, hch@lst.de, cluster-devel@redhat.com, kuznet@ms2.inr.ac.ru, kuba@kernel.org, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, nhorman@tuxdriver.com, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, vyasevich@gmail.com, linux-kernel@vger.kernel.org, jmaloy@redhat.com, ying.xue@windriver.com, ocfs2-devel@oss.oracle.com Subject: Re: [Drbd-dev] [PATCH 31/33] sctp: add sctp_sock_set_nodelay List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sat, 13 Jun 2020 10:15:17 -0000 On Wed, May 20, 2020 at 04:23:55PM -0700, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 20 May 2020 20:10:01 -0300 > > > The duplication with sctp_setsockopt_nodelay() is quite silly/bad. > > Also, why have the 'true' hardcoded? It's what dlm uses, yes, but the > > API could be a bit more complete than that. > > The APIs are being designed based upon what in-tree users actually > make use of. We can expand things later if necessary. Sometimes expanding things later can be though, thus why the worry. But ok, I get it. Thanks. The comment still applies, though. (re the duplication)