From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Makarand Sonare <makarandsonare@google.com>
Cc: kvm@vger.kernel.org, pshier@google.com, jmattson@google.com
Subject: Re: [PATCH 0/2 v3] Fix VMX preemption timer migration
Date: Wed, 20 May 2020 19:51:06 -0700 [thread overview]
Message-ID: <20200521025106.GL18102@linux.intel.com> (raw)
In-Reply-To: <20200520232228.55084-1-makarandsonare@google.com>
On Wed, May 20, 2020 at 04:22:26PM -0700, Makarand Sonare wrote:
> Fix VMX preemption timer migration. Add a selftest to ensure post migration
> both L1 and L2 VM observe the VMX preemption timer exit close to the original
> expiration deadline.
For versions > 1, please put a brief blurb in the cover letter (or in the
ignored part of each patch) explaining what changed. It's also helpful to
give attribution, not so much for the sake of giving credit, but to give
other reviewers context.
Something like:
v3: Moved timer deadline to kvm_vmx_nested_state_hdr. [Paolo]
v2: Fixed xyz.
That helps reviewers understand what has changed and what feedback has been
addressed (or to remind them of what feedback they gave :-D), and helps you
avoid getting conflicting feedback.
> Makarand Sonare (1):
> KVM: selftests: VMX preemption timer migration test
>
> Peter Shier (1):
> KVM: nVMX: Fix VMX preemption timer migration
>
> Documentation/virt/kvm/api.rst | 4 +
> arch/x86/include/uapi/asm/kvm.h | 3 +
> arch/x86/kvm/vmx/nested.c | 45 +++-
> arch/x86/kvm/vmx/vmx.h | 2 +
> arch/x86/kvm/x86.c | 3 +-
> include/uapi/linux/kvm.h | 1 +
> tools/arch/x86/include/uapi/asm/kvm.h | 1 +
> tools/testing/selftests/kvm/.gitignore | 1 +
> tools/testing/selftests/kvm/Makefile | 1 +
> .../testing/selftests/kvm/include/kvm_util.h | 2 +
> .../selftests/kvm/include/x86_64/processor.h | 11 +-
> .../selftests/kvm/include/x86_64/vmx.h | 27 ++
> .../kvm/x86_64/vmx_preemption_timer_test.c | 255 ++++++++++++++++++
> 13 files changed, 344 insertions(+), 12 deletions(-)
> create mode 100644 tools/testing/selftests/kvm/x86_64/vmx_preemption_timer_test.c
>
> --
> 2.26.2.761.g0e0b3e54be-goog
>
prev parent reply other threads:[~2020-05-21 2:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 23:22 [PATCH 0/2 v3] Fix VMX preemption timer migration Makarand Sonare
2020-05-20 23:22 ` [PATCH 1/2 v3] KVM: nVMX: " Makarand Sonare
2020-05-21 2:44 ` Sean Christopherson
2020-05-20 23:22 ` [PATCH 2/2 v3] KVM: selftests: VMX preemption timer migration test Makarand Sonare
2020-05-21 2:51 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521025106.GL18102@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=makarandsonare@google.com \
--cc=pshier@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.