From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB2CC433DF for ; Thu, 21 May 2020 12:33:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C47E2070A for ; Thu, 21 May 2020 12:33:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HOBH8aac" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C47E2070A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6sK++mkBYNo5bnjG+gmyorns1UprouhKKOZUjBO7Tdk=; b=HOBH8aacPi/DOB HdvGnOj/vKZKta7gtVmNHOodTqJP/cm3R9GX2A8pAwgSFoSJZNewEJZWpkGJ8k/IDZi9SCI3Y70BJ xKJbiFDTiXCpnIct/feBw4uyuuCjTVVrES7CJRt6ciMyyT3jIeIHy3JqDC+Uk4TxFNMC4zCJk/aCR reKe3CW/Czm6WSmUSa4th1SNl0TpHkMeW3kM1pPaAYrbuPhKZ+3RW/oQFEUWu1J+mEPyTR8TS2Z4d w2R6YYueU62rwmhIwues8CTzOkmhxi0uTsQgKAe9hTvz/SmOrYCOq+iKTaFYsodG2qJSt6knAPTTS tXze8Jr4VrWtOyfRMmBg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbkOU-00052t-Uz; Thu, 21 May 2020 12:33:50 +0000 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbkOQ-00052H-S4 for linux-arm-kernel@lists.infradead.org; Thu, 21 May 2020 12:33:48 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04LCVeVs032255; Thu, 21 May 2020 08:33:38 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 315km8u6k9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 May 2020 08:33:38 -0400 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 04LCWHK4033585; Thu, 21 May 2020 08:33:38 -0400 Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com with ESMTP id 315km8u6j6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 May 2020 08:33:37 -0400 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 04LCV3Se002802; Thu, 21 May 2020 12:33:35 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma02fra.de.ibm.com with ESMTP id 313x2j2bps-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 May 2020 12:33:35 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 04LCXUFe58589394 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 May 2020 12:33:30 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EF99F5205A; Thu, 21 May 2020 12:33:29 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.204.51]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id 18A9C5204F; Thu, 21 May 2020 12:33:29 +0000 (GMT) Date: Thu, 21 May 2020 15:33:27 +0300 From: Mike Rapoport To: Russell King - ARM Linux admin Subject: Re: [PATCH 0/2] ARM: Allow either FLATMEM or SPARSEMEM on the multiplatform build Message-ID: <20200521123327.GQ1059226@linux.ibm.com> References: <20200521081825.1348844-1-rppt@linux.ibm.com> <20200521120308.GR1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200521120308.GR1551@shell.armlinux.org.uk> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676 definitions=2020-05-21_05:2020-05-21, 2020-05-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 cotscore=-2147483648 impostorscore=0 phishscore=0 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 suspectscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005210091 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200521_053346_913118_72F1356A X-CRM114-Status: GOOD ( 23.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Arnd Bergmann , Stephen Boyd , Kevin Cernekee , Doug Berger , Gregory Fong , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 21, 2020 at 01:03:08PM +0100, Russell King - ARM Linux admin wrote: > On Thu, May 21, 2020 at 11:18:23AM +0300, Mike Rapoport wrote: > > (resendig for the correct address and with mailing list cc'ed, sorry for > > the noise) > > > > Hi, > > > > Following the discussion at [1], I'm resending the patches that enable > > memory model selection in menuconfig and such. > > > > These patches do not change the way the configuration is generated from the > > defconfigs and they do not change explicit selection of SPARSEMEM for > > platforms that have "select ARCH_ENABLE_SPARSEMEM". > > > > The mere change is that when a user runs an interactive configuration they > > will be allowed to select between FLATMEM and SPARSMEM, which is not the > > case today. > > > > There is indeed some awkwardness in, e.g. removal of > > ARCH_SPARSEMEM_DEFAULT, but this is what memory model selection logic in > > mm/Kconfig imposes. > > > > For example, below is the diffs of the configurations generated with > > 'make rpc_defconfig' and 'make defconfig': > > > > $ diff -s old/rpc_defconfig new/rpc_defconfig > > Files old/rpc_defconfig and new/rpc_defconfig are identical > > > > $ diff -u old/defconfig new/defconfig > > --- old/defconfig 2020-05-20 17:51:01.832649705 +0300 > > +++ new/defconfig 2020-05-20 18:15:21.084385880 +0300 > > @@ -674,6 +674,9 @@ > > CONFIG_AEABI=y > > # CONFIG_OABI_COMPAT is not set > > CONFIG_ARCH_HAS_HOLES_MEMORYMODEL=y > > +CONFIG_ARCH_SELECT_MEMORY_MODEL=y > > +CONFIG_ARCH_FLATMEM_ENABLE=y > > +CONFIG_ARCH_SPARSEMEM_ENABLE=y > > CONFIG_HAVE_ARCH_PFN_VALID=y > > CONFIG_HIGHMEM=y > > CONFIG_HIGHPTE=y > > @@ -1061,6 +1064,9 @@ > > # > > # Memory Management options > > # > > +CONFIG_SELECT_MEMORY_MODEL=y > > +CONFIG_FLATMEM_MANUAL=y > > +# CONFIG_SPARSEMEM_MANUAL is not set > > CONFIG_FLATMEM=y > > CONFIG_FLAT_NODE_MEM_MAP=y > > CONFIG_ARCH_KEEP_MEMBLOCK=y > > Right, but the question is whether we want to offer flatmem for rpc. > It isn't allowed today, and so far no one has said why it's a > desirable change to make. With ARCH_RPC=y (or ARCH_SA1100 or ARCH_EP93XX for that matter) ARCH_MULTIPLATFORM=n which prevents ARCH_SELECT_MEMORY_MODEL from being enabled and since any of these machines explicitly selects ARCH_SPARSEMEM_ENABLE, the only available memory model would be SPARSEMEM. I played a bit with menuconfig and if any of the platforms requiring sparsemem is selected, the menu allowing the user to choose the memory model disappears. > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel