All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giuliano Procida <gprocida@google.com>
To: greg@kroah.com
Cc: stable@vger.kernel.org, Giuliano Procida <gprocida@google.com>
Subject: [PATCH 0/4] [backports] fix l2tp use-after-free in pppol2tp_sendmsg
Date: Thu, 21 May 2020 14:57:00 +0100	[thread overview]
Message-ID: <20200521135704.109812-1-gprocida@google.com> (raw)

Hi Greg.

This is for 4.14.

We received a PoC (code to run as root with a KASAN kernel)
demonstrating the existence of a use-after-free in pppol2tp_sendmsg.
This was accompanied by a patch to resolve it, consisting mostly of
parts of patch 3 plus a little of 4.

The following patches all apply cleanly and compile with allmodconfig.
However, I lack the hardware to test them.

The changes are already in 4.19. I'll post the changes for 4.9 next.

Regards,
Giuliano.

Guillaume Nault (4):
  l2tp: don't register sessions in l2tp_session_create()
  l2tp: initialise l2tp_eth sessions before registering them
  l2tp: protect sock pointer of struct pppol2tp_session with RCU
  l2tp: initialise PPP sessions before registering them

 net/l2tp/l2tp_core.c |  21 ++--
 net/l2tp/l2tp_core.h |   3 +
 net/l2tp/l2tp_eth.c  |  99 +++++++++++++-----
 net/l2tp/l2tp_ppp.c  | 238 +++++++++++++++++++++++++++----------------
 4 files changed, 238 insertions(+), 123 deletions(-)

-- 
2.26.2.761.g0e0b3e54be-goog


             reply	other threads:[~2020-05-21 13:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21 13:57 Giuliano Procida [this message]
2020-05-21 13:57 ` [PATCH 1/4] l2tp: don't register sessions in l2tp_session_create() Giuliano Procida
2020-05-21 13:57 ` [PATCH 2/4] l2tp: initialise l2tp_eth sessions before registering them Giuliano Procida
2020-05-21 13:57 ` [PATCH 3/4] l2tp: protect sock pointer of struct pppol2tp_session with RCU Giuliano Procida
2020-05-21 13:57 ` [PATCH 4/4] l2tp: initialise PPP sessions before registering them Giuliano Procida
2020-05-22 12:07 ` [PATCH 0/4] [backports] fix l2tp use-after-free in pppol2tp_sendmsg Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200521135704.109812-1-gprocida@google.com \
    --to=gprocida@google.com \
    --cc=greg@kroah.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.