Re: [PATCH for-next v2 1/2] RDMA/efa: Fix setting of wrong bit in get/set_feature commands

[Jason Gunthorpe <jgg@ziepe.ca>]

On Wed, May 20, 2020 at 11:03:00AM +0300, Gal Pressman wrote:
> On 20/05/2020 3:04, Jason Gunthorpe wrote:
> > On Tue, May 12, 2020 at 06:22:03PM +0300, Gal Pressman wrote:
> >> When using a control buffer the ctrl_data bit should be set in order to
> >> indicate the control buffer address is valid, not ctrl_data_indirect
> >> which is used when the control buffer itself is indirect.
> >>
> >> Reviewed-by: Firas JahJah <firasj@amazon.com>
> >> Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
> >> Signed-off-by: Gal Pressman <galpress@amazon.com>
> >>  drivers/infiniband/hw/efa/efa_com_cmd.c | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > No fixes line??
> 
> The reason I didn't add a fixes line (and sent it to for-next) is that it turns
> out this is the first set feature command to use a control buffer so nothing was
> broken, but this is necessary for patch #2 to work.

It should probably still have a fixes line in case someone decided to
backport the 2nd patch. But applied without

Jason