From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 655A5C433DF for ; Thu, 21 May 2020 21:14:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43D7D20759 for ; Thu, 21 May 2020 21:14:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TlYSTVO/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730608AbgEUVOi (ORCPT ); Thu, 21 May 2020 17:14:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730607AbgEUVOg (ORCPT ); Thu, 21 May 2020 17:14:36 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34770C08C5C0 for ; Thu, 21 May 2020 14:14:35 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id e14so6828135ybh.16 for ; Thu, 21 May 2020 14:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=semgcmJd0ZZ9q+OBcE/cjzRQcM4RABCN/d9XODlBjRA=; b=TlYSTVO/Y8u4XRBQIPQXsEu5jGML3Ds00FRBHt//Mxa9a2AaScCsqVRxFRWHdU2drB Oc3DmuiIsF0NWvZfGexbksIlGcw3bTNLnB7Dm2vDAvLHR0EzpVD44ZglXDaidxyyv29c imLD0eJU1+IZelhBUQDzp6FhQKefWoXPsjeRjoVeWZMYpuTceYBZXqwe1usyba7Mo5fd lxPYQMiD5umdUV8hOrVNEke3LLE++/LulrbW2iidAoyzCqUm37kUbnc4WgFvpmV98zoy lJZHfQ5EpPOmS9n4KMjq3spWJA07pHcS/UJ6p83Krdx6oi+LWBGpfxXoxwUURqVeV0T5 SBKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=semgcmJd0ZZ9q+OBcE/cjzRQcM4RABCN/d9XODlBjRA=; b=oLGRLdJgYRIjFDbyu9E7LqgRmSGmyqv69oy2oqhHfjW09+NHWpcMX4+j5G3dBbE4c6 PlLbgBvcNV0nB6h3+SzrzJDCJQArnLDDRCGhndxNsk/8E1GRDzO8fma/xhNc7kADyCDF 295d8abudZOahG3953BJucNUmwf4SMascACFzCdK6A/TQZdS3r5FDfW2syfKv1cJ++g9 BxBrms160HZHd624MUFr4ekBv1L+QXQX3wnNsCfGlxgAiftEAhYXeGAGG8HMh9O2Ogh5 gIGGV9j7AiYMLYvNatdOqmdfoT1VolADtNMq2PYysCo7+i9fbsdEQb27MVCzlxPD5Oms 1+4Q== X-Gm-Message-State: AOAM533WVLhSSLTZwAS8ZnnWSzWnZuTZshqVYepqXQnnEhw3YxFJSN5a PrdynnJAmEMuOBPHkY/Rgf2bwn0= X-Google-Smtp-Source: ABdhPJw5CN2ei/ClgLNdsSzrKVS4Hgzwn2pYl2BgA0+O1BHrOE25xjmCCA7f/kCtzSd2kWGb8repg8I= X-Received: by 2002:a25:cbc9:: with SMTP id b192mr18457440ybg.132.1590095674239; Thu, 21 May 2020 14:14:34 -0700 (PDT) Date: Thu, 21 May 2020 14:14:32 -0700 In-Reply-To: <20200521125247.30178-1-fejes@inf.elte.hu> Message-Id: <20200521211432.GC49942@google.com> Mime-Version: 1.0 References: <20200521125247.30178-1-fejes@inf.elte.hu> Subject: Re: [PATCH net-next] Extending bpf_setsockopt with SO_BINDTODEVICE sockopt From: sdf@google.com To: Ferenc Fejes Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Martin KaFai Lau , Lawrence Brakmo , "David S . Miller" Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 05/21, Ferenc Fejes wrote: > This option makes possible to programatically bind sockets to netdevices. > With the help of this option sockets of VRF unaware applications > could be distributed between multiple VRFs with eBPF sock_ops program. > This let the applications benefit from the multiple possible routes. > Signed-off-by: Ferenc Fejes > --- > net/core/filter.c | 39 ++++++++++++++++++++++++++++++++++++++- > 1 file changed, 38 insertions(+), 1 deletion(-) > diff --git a/net/core/filter.c b/net/core/filter.c > index 822d662f97ef..25dac75bfc5d 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -4248,6 +4248,9 @@ static const struct bpf_func_proto > bpf_get_socket_uid_proto = { > static int _bpf_setsockopt(struct sock *sk, int level, int optname, > char *optval, int optlen, u32 flags) > { > + char devname[IFNAMSIZ]; > + struct net *net; > + int ifindex; > int ret = 0; > int val; > @@ -4257,7 +4260,7 @@ static int _bpf_setsockopt(struct sock *sk, int > level, int optname, > sock_owned_by_me(sk); > if (level == SOL_SOCKET) { > - if (optlen != sizeof(int)) > + if (optlen != sizeof(int) && optname != SO_BINDTODEVICE) > return -EINVAL; > val = *((int *)optval); > @@ -4298,6 +4301,40 @@ static int _bpf_setsockopt(struct sock *sk, int > level, int optname, > sk_dst_reset(sk); > } > break; > + case SO_BINDTODEVICE: > + ret = -ENOPROTOOPT; > +#ifdef CONFIG_NETDEVICES Any specific reason you're not reusing sock_setbindtodevice or at least sock_setbindtodevice_locked here? I think, historically, we've reimplemented some of the sockopts because they were 'easy' (i.e. were just setting a flag in the socket), this one looks more involved. I'd suggest, add an optional 'lock_sk' argument to sock_setbindtodevice, call it with 'true' from real setsockopt, and call it with 'false' here. And, as Andrii pointed out, it would be nice to have a selftest that exercises this new option.