All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manasi Navare <manasi.d.navare@intel.com>
To: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v9 0/7] Consider DBuf bandwidth when calculating CDCLK
Date: Thu, 21 May 2020 14:28:42 -0700	[thread overview]
Message-ID: <20200521212841.GA19471@intel.com> (raw)
In-Reply-To: <20200519131117.17190-1-stanislav.lisovskiy@intel.com>

Pushed the series to dinq, thank you for patches and reviews

Regards
Manasi

On Tue, May 19, 2020 at 04:11:10PM +0300, Stanislav Lisovskiy wrote:
> We need to calculate cdclk after watermarks/ddb has been calculated
> as with recent hw CDCLK needs to be adjusted accordingly to DBuf
> requirements, which is not possible with current code organization.
> 
> Setting CDCLK according to DBuf BW requirements and not just rejecting
> if it doesn't satisfy BW requirements, will allow us to save power when
> it is possible and gain additional bandwidth when it's needed - i.e
> boosting both our power management and perfomance capabilities.
> 
> This patch is preparation for that, first we now extract modeset
> calculation from modeset checks, in order to call it after wm/ddb
> has been calculated.
> 
> Stanislav Lisovskiy (7):
>   drm/i915: Decouple cdclk calculation from modeset checks
>   drm/i915: Extract cdclk requirements checking to separate function
>   drm/i915: Check plane configuration properly
>   drm/i915: Plane configuration affects CDCLK in Gen11+
>   drm/i915: Introduce for_each_dbuf_slice_in_mask macro
>   drm/i915: Adjust CDCLK accordingly to our DBuf bw needs
>   drm/i915: Remove unneeded hack now for CDCLK
> 
>  drivers/gpu/drm/i915/display/intel_bw.c       | 118 +++++++++++++++++-
>  drivers/gpu/drm/i915/display/intel_bw.h       |  10 ++
>  drivers/gpu/drm/i915/display/intel_cdclk.c    |  40 +++---
>  drivers/gpu/drm/i915/display/intel_cdclk.h    |   1 -
>  drivers/gpu/drm/i915/display/intel_display.c  |  89 ++++++++++---
>  drivers/gpu/drm/i915/display/intel_display.h  |   7 ++
>  .../drm/i915/display/intel_display_power.h    |   1 +
>  drivers/gpu/drm/i915/i915_drv.h               |   1 +
>  drivers/gpu/drm/i915/intel_pm.c               |  31 ++++-
>  drivers/gpu/drm/i915/intel_pm.h               |   3 +
>  10 files changed, 261 insertions(+), 40 deletions(-)
> 
> -- 
> 2.24.1.485.gad05a3d8e5
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-05-21 21:27 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 13:11 [Intel-gfx] [PATCH v9 0/7] Consider DBuf bandwidth when calculating CDCLK Stanislav Lisovskiy
2020-05-19 13:11 ` [Intel-gfx] [PATCH v9 1/7] drm/i915: Decouple cdclk calculation from modeset checks Stanislav Lisovskiy
2020-05-19 13:11 ` [Intel-gfx] [PATCH v9 2/7] drm/i915: Extract cdclk requirements checking to separate function Stanislav Lisovskiy
2020-05-19 13:11 ` [Intel-gfx] [PATCH v9 3/7] drm/i915: Check plane configuration properly Stanislav Lisovskiy
2020-05-20 14:58   ` Stanislav Lisovskiy
2020-05-19 13:11 ` [Intel-gfx] [PATCH v9 4/7] drm/i915: Plane configuration affects CDCLK in Gen11+ Stanislav Lisovskiy
2020-05-20 14:59   ` Stanislav Lisovskiy
2020-05-19 13:11 ` [Intel-gfx] [PATCH v9 5/7] drm/i915: Introduce for_each_dbuf_slice_in_mask macro Stanislav Lisovskiy
2020-05-19 13:11 ` [Intel-gfx] [PATCH v9 6/7] drm/i915: Adjust CDCLK accordingly to our DBuf bw needs Stanislav Lisovskiy
2020-05-19 21:25   ` Stanislav Lisovskiy
2020-05-19 23:55     ` Manasi Navare
2020-05-20 15:00     ` Stanislav Lisovskiy
2020-05-19 13:11 ` [Intel-gfx] [PATCH v9 7/7] drm/i915: Remove unneeded hack now for CDCLK Stanislav Lisovskiy
2020-05-19 17:22 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Consider DBuf bandwidth when calculating CDCLK (rev14) Patchwork
2020-05-19 23:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Consider DBuf bandwidth when calculating CDCLK (rev15) Patchwork
2020-05-19 23:33 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-05-19 23:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-05-20  6:22   ` Lisovskiy, Stanislav
2020-05-20  8:43     ` Vudum, Lakshminarayana
2020-05-20  8:44       ` Lisovskiy, Stanislav
2020-05-20  8:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-05-20 15:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Consider DBuf bandwidth when calculating CDCLK (rev18) Patchwork
2020-05-20 15:29 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-05-20 15:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-05-20 19:57 ` [Intel-gfx] ✓ Fi.CI.IGT: success for Consider DBuf bandwidth when calculating CDCLK (rev15) Patchwork
2020-05-21  6:55 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for Consider DBuf bandwidth when calculating CDCLK (rev18) Patchwork
2020-05-21  9:35   ` Lisovskiy, Stanislav
2020-05-21 21:02     ` Vudum, Lakshminarayana
2020-05-22 22:00     ` Chris Wilson
2020-05-22 23:18       ` Chris Wilson
2020-05-25  8:00         ` Lisovskiy, Stanislav
2020-05-25  8:03           ` Chris Wilson
2020-05-25  8:07             ` Lisovskiy, Stanislav
2020-05-25  8:09               ` Chris Wilson
2020-05-25  8:14                 ` Lisovskiy, Stanislav
2020-05-21 21:01 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2020-05-21 21:28 ` Manasi Navare [this message]
2020-05-21 22:17   ` [Intel-gfx] [PATCH v9 0/7] Consider DBuf bandwidth when calculating CDCLK Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200521212841.GA19471@intel.com \
    --to=manasi.d.navare@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stanislav.lisovskiy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.