From: Kalle Valo <kvalo@codeaurora.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <nbd@nbd.name>, <lorenzo.bianconi83@gmail.com>,
<ryder.lee@mediatek.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <matthias.bgg@gmail.com>,
<shayne.chen@mediatek.com>, <chih-min.chen@mediatek.com>,
<yf.luo@mediatek.com>, <yiwei.chung@mediatek.com>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
YueHaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH -next] mt76: mt7915: Fix build error
Date: Fri, 22 May 2020 12:40:52 +0000 (UTC) [thread overview]
Message-ID: <20200522124052.D1B5FC4339C@smtp.codeaurora.org> (raw)
In-Reply-To: <20200522034533.61716-1-yuehaibing@huawei.com>
YueHaibing <yuehaibing@huawei.com> wrote:
> In file included from ./include/linux/firmware.h:6:0,
> from drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:4:
> In function ‘__mt7915_mcu_msg_send’,
> inlined from ‘mt7915_mcu_send_message’ at drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:370:6:
> ./include/linux/compiler.h:396:38: error: call to ‘__compiletime_assert_545’ declared with attribute error: BUILD_BUG_ON failed: cmd == MCU_EXT_CMD_EFUSE_ACCESS && mcu_txd->set_query != MCU_Q_QUERY
> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> ^
> ./include/linux/compiler.h:377:4: note: in definition of macro ‘__compiletime_assert’
> prefix ## suffix(); \
> ^~~~~~
> ./include/linux/compiler.h:396:2: note: in expansion of macro ‘_compiletime_assert’
> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> ^~~~~~~~~~~~~~~~~~~
> ./include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’
> #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
> ^~~~~~~~~~~~~~~~~~
> ./include/linux/build_bug.h:50:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
> BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
> ^~~~~~~~~~~~~~~~
> drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:280:2: note: in expansion of macro ‘BUILD_BUG_ON’
> BUILD_BUG_ON(cmd == MCU_EXT_CMD_EFUSE_ACCESS &&
> ^~~~~~~~~~~~
>
> BUILD_BUG_ON is meaningless here, chang it to WARN_ON.
>
> Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
472f0a240250 mt76: mt7915: Fix build error
--
https://patchwork.kernel.org/patch/11564595/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-05-22 12:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 3:45 [PATCH -next] mt76: mt7915: Fix build error YueHaibing
2020-05-22 3:45 ` YueHaibing
2020-05-22 3:45 ` YueHaibing
2020-05-22 10:11 ` Kalle Valo
2020-05-22 10:11 ` Kalle Valo
2020-05-22 10:11 ` Kalle Valo
2020-05-22 11:34 ` Yuehaibing
2020-05-22 11:34 ` Yuehaibing
2020-05-25 10:37 ` Kalle Valo
2020-05-25 10:37 ` Kalle Valo
2020-05-25 10:37 ` Kalle Valo
2020-05-22 12:40 ` Kalle Valo
2020-05-22 12:40 ` Kalle Valo
2020-05-22 12:40 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522124052.D1B5FC4339C@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=chih-min.chen@mediatek.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=yf.luo@mediatek.com \
--cc=yiwei.chung@mediatek.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.