From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83B96C433E0 for ; Fri, 22 May 2020 13:17:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 546222065F for ; Fri, 22 May 2020 13:17:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 546222065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C30576E0CB; Fri, 22 May 2020 13:17:06 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 744616E0CB for ; Fri, 22 May 2020 13:17:05 +0000 (UTC) IronPort-SDR: 3GQKh5YvudysOL2ZFStQ28XOns7HWM/igImchEUlHcqaF9CKZyEwCVtK0wTTA7upVpgYd8PcOs NKlyZ8OkVSuQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2020 06:17:05 -0700 IronPort-SDR: 87ApscBEKchhAod9aBceMOlBPFcuaoUY/zGfFwgL7DVKfCHSomy2yskl60WnFpyAWCVgKS287p /x0nOLtwLgrw== X-IronPort-AV: E=Sophos;i="5.73,421,1583222400"; d="scan'208";a="412754701" Received: from unknown (HELO intel.com) ([10.237.72.89]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2020 06:17:03 -0700 Date: Fri, 22 May 2020 16:13:02 +0300 From: "Lisovskiy, Stanislav" To: Chris Wilson Message-ID: <20200522131302.GA20068@intel.com> References: <20200522125534.19935-1-stanislav.lisovskiy@intel.com> <159015272616.32320.7673829907075394808@build.alporthouse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <159015272616.32320.7673829907075394808@build.alporthouse.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH v1] drm/i915: Fix includes and local vars order X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, May 22, 2020 at 02:05:26PM +0100, Chris Wilson wrote: > Quoting Stanislav Lisovskiy (2020-05-22 13:55:34) > > Removed duplicate include and fixed comment > 80 chars. > > > > Signed-off-by: Stanislav Lisovskiy > > --- > > drivers/gpu/drm/i915/display/intel_bw.c | 43 ++++++++++++---------- > > drivers/gpu/drm/i915/display/intel_bw.h | 2 +- > > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +- > > drivers/gpu/drm/i915/display/intel_cdclk.h | 1 + > > drivers/gpu/drm/i915/intel_pm.c | 3 +- > > drivers/gpu/drm/i915/intel_pm.h | 2 +- > > 6 files changed, 29 insertions(+), 24 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c > > index 8d2f58e39595..db9ba8f922bd 100644 > > --- a/drivers/gpu/drm/i915/display/intel_bw.c > > +++ b/drivers/gpu/drm/i915/display/intel_bw.c > > @@ -5,13 +5,12 @@ > > > > #include > > > > +#include "intel_atomic.h" > > #include "intel_bw.h" > > -#include "intel_pm.h" > > +#include "intel_cdclk.h" > > #include "intel_display_types.h" > > -#include "intel_sideband.h" > > -#include "intel_atomic.h" > > #include "intel_pm.h" > > -#include "intel_cdclk.h" > > +#include "intel_sideband.h" > > There was also the accidental remove of a '\n' before > intel_bw_crtc_update() Weird..how didn't I spot this. > > > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c > > index dda9bae02a86..643701cca6ba 100644 > > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c > > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c > > @@ -23,10 +23,10 @@ > > > > #include > > \n between system and local includes > > > #include "intel_atomic.h" > > +#include "intel_bw.h" > > #include "intel_cdclk.h" > > #include "intel_display_types.h" > > #include "intel_sideband.h" > > -#include "intel_bw.h" > > 2 more nits then > Reviewed-by: Chris Wilson > s/Reviewed/Critiqued/ > -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx