From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E8D6C433DF for ; Fri, 22 May 2020 17:33:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 006E6206C3 for ; Fri, 22 May 2020 17:33:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xM7/kxVn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730636AbgEVRdu (ORCPT ); Fri, 22 May 2020 13:33:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730701AbgEVRdu (ORCPT ); Fri, 22 May 2020 13:33:50 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B80BC08C5C0 for ; Fri, 22 May 2020 10:33:50 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id ci21so5224015pjb.3 for ; Fri, 22 May 2020 10:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=2tZSSQp+Q6NkFkvGgoTM41d8a2brRtjrb60yXEtR4oc=; b=xM7/kxVnNd5tkM3aD88kh404nBLGZ0PykMDKj1PajSxvbZKv5gN1DQN4908oXvpFkT D5j4s7pQVcv3lluXjL5hsxnA5VxVZtG0VkOtyF+z/kqlbmj4mJwBQsl5vSglfKkcR8nn hCubMPJ6ImS9MjzxWO29RgINWtO+wzHImrvVO8bqT+EgexwI4z0GvFjyJSQuvA0RU0kK XlRnMSnPgLf+iGmebcMZntq3a8e1GSzPZl1G1vlmX5mofuMANElZbQzYDpVk5myzPSTI AGp8GUBRrS5t+JdFrWN109JV1COJz5flF4tptKa4cikXYJEW3rP9B8NjoLN/dHAbj2yd l8DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2tZSSQp+Q6NkFkvGgoTM41d8a2brRtjrb60yXEtR4oc=; b=nQowCpoSqpfUurFCB8Zpr4ZZCwohfj/a18psWCZITW2JwgUykHahAqFRgi4RNsWNup 5f98jgr5DEL3j6YnHEwCg2zmKtIoWzZZGJjD/y5ReYELoU1Er9RIZvcIHBgSszXMUabA IzDOceMGKlt+VKmPddp6mrZpgjXwE6C6P7oZ0feD2Ehvi0VQ5yV9FWulmruOxrDergCr jpdpNco0tb5qCqEO5RuY7W4mJs7b4jxS+ksf9R6p7pMz2haHqY2aa60KNcJq+dDA5GWv pfDOYSjaBHWJJs1CcCT/3ikkawNb2XpxkUmCTmCLNprJb9uLCMHvmGn1ilLuNN2ODfjz ZI7Q== X-Gm-Message-State: AOAM5327AD8j3SZU5fp8exEhSumwQ6u+K6f+RoZSaHAT6g/Qh+YU77qa ckukfQnA4reL5N8Gj00K/ZoyiQ== X-Google-Smtp-Source: ABdhPJxs9ytct9W3l8jqHigChSN52KDjrcdPVZee/8dxkQn+Y6KW9FWnWmyEjZpnERt5Wp6T0UgISg== X-Received: by 2002:a17:902:8509:: with SMTP id bj9mr15699226plb.151.1590168829712; Fri, 22 May 2020 10:33:49 -0700 (PDT) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id t23sm7426330pji.32.2020.05.22.10.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 10:33:49 -0700 (PDT) Date: Fri, 22 May 2020 10:33:46 -0700 From: Bjorn Andersson To: Suman Anna Cc: Rob Herring , Mathieu Poirier , Clement Leger , Loic Pallardy , Arnaud Pouliquen , Lokesh Vutla , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] remoteproc: add support for a new 64-bit trace version Message-ID: <20200522173346.GJ11847@yoga> References: <20200325204701.16862-1-s-anna@ti.com> <20200325204701.16862-4-s-anna@ti.com> <20200521180417.GJ408178@builder.lan> <997d6f9a-64ba-7a89-e909-9a5a474120b0@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Fri 22 May 09:54 PDT 2020, Suman Anna wrote: > On 5/21/20 2:42 PM, Suman Anna wrote: > > Hi Bjorn, > > > > On 5/21/20 1:04 PM, Bjorn Andersson wrote: > > > On Wed 25 Mar 13:47 PDT 2020, Suman Anna wrote: [..] > > > > diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h [..] > > > > +struct fw_rsc_trace2 { > > > > > > Sounds more like fw_rsc_trace64 to me - in particular since the version > > > of trace2 is 1... > > > > Yeah, will rename this. > > > > > > > > > +    u32 padding; > > > > +    u64 da; > > > > +    u32 len; > > > > +    u32 reserved; > > > > > > What's the purpose of this reserved field? > > > > Partly to make sure the entire resource is aligned on an 8-byte, and > > partly copied over from fw_rsc_trace entry. I guess 32-bits is already > > large enough of a size for trace entries irrespective of 32-bit or > > 64-bit traces, so I doubt if we want to make the len field also a u64. > > Looking at this again, I can drop both padding and reserved fields, if I > move the len field before da. Any preferences/comments? > Sounds good to me. Thanks, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 733F0C433E0 for ; Fri, 22 May 2020 17:33:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C11F206C3 for ; Fri, 22 May 2020 17:33:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mez5KMwc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xM7/kxVn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C11F206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0sedcqsUiGx/vRzXaKbLYpJxmDkTWDPcBv7UFDgaFjc=; b=mez5KMwcUgB2PJ tY2irRW0JIlaQQOqaQO1Y/fOng/MCMnMr6XbngH8fcQ6vyvvpQpVlUNLjNbMgLcVedYdUcbUjFPe7 OfYG7OmzygOaMuXvX/aOc5bjDTpxIeB7uEEXbuOLDHK9+3q2Xlor66OpVSu/y5Ox9BZnBU/V0Cru3 30ArnEvxUNHA/oIL0nBg5bieLgzkRH9wPWJfB07H6uZ1TFdPUJbdAu3uhiOars+sb9wis6V/LqH+Y 5E4XoeP7SORrzg7bjog7BW2z2UvpF7G7Ow53m6gnSbHatpW5Gmp8bnALVC9h9DQhxRxOpqKZF1cbG n++CsljcZFx41PE8RuKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jcBYQ-0005kr-6x; Fri, 22 May 2020 17:33:54 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jcBYM-0005k0-ME for linux-arm-kernel@lists.infradead.org; Fri, 22 May 2020 17:33:52 +0000 Received: by mail-pl1-x641.google.com with SMTP id a13so4655379pls.8 for ; Fri, 22 May 2020 10:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=2tZSSQp+Q6NkFkvGgoTM41d8a2brRtjrb60yXEtR4oc=; b=xM7/kxVnNd5tkM3aD88kh404nBLGZ0PykMDKj1PajSxvbZKv5gN1DQN4908oXvpFkT D5j4s7pQVcv3lluXjL5hsxnA5VxVZtG0VkOtyF+z/kqlbmj4mJwBQsl5vSglfKkcR8nn hCubMPJ6ImS9MjzxWO29RgINWtO+wzHImrvVO8bqT+EgexwI4z0GvFjyJSQuvA0RU0kK XlRnMSnPgLf+iGmebcMZntq3a8e1GSzPZl1G1vlmX5mofuMANElZbQzYDpVk5myzPSTI AGp8GUBRrS5t+JdFrWN109JV1COJz5flF4tptKa4cikXYJEW3rP9B8NjoLN/dHAbj2yd l8DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2tZSSQp+Q6NkFkvGgoTM41d8a2brRtjrb60yXEtR4oc=; b=mntXfbJediVvPeep00m0zVUOaHkJOXHQNNFmANysfVgJOTkdBT5J6fBr5XBCnCS4v9 9Fj66F62JfmnIlG0DE2ozyHxAdyhHhQk/T7Bmfwi6Ih/lgMOtqMtFR2KV+7ZREp7PEmS jkeNJdt4MmADhFWu5OJTtSylgZXr4oUjkzpoX23YOukkvwIFTFuZc3rbFUy3wKJhHCgH wFsceQTyuVRHawYKsZAFxMKYFDXpaiGhvhqog51prK9B7u4+w2KHdI60q8TBFxYzxdfY k/KKptxiRumCLc71XGU4gxkPmnh8fPNFJ5pHB7GQqLzp4IMI5EzN1tpyfUCY2fFIihUL DkMg== X-Gm-Message-State: AOAM532uLTcd1JhqKTu0wK8fXRmX4FpS7AUeVOJJzKHOVde+0w2NkalI Wl/Fe6tjeybEwbUI4A0e+ie2xQ== X-Google-Smtp-Source: ABdhPJxs9ytct9W3l8jqHigChSN52KDjrcdPVZee/8dxkQn+Y6KW9FWnWmyEjZpnERt5Wp6T0UgISg== X-Received: by 2002:a17:902:8509:: with SMTP id bj9mr15699226plb.151.1590168829712; Fri, 22 May 2020 10:33:49 -0700 (PDT) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id t23sm7426330pji.32.2020.05.22.10.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 10:33:49 -0700 (PDT) Date: Fri, 22 May 2020 10:33:46 -0700 From: Bjorn Andersson To: Suman Anna Subject: Re: [PATCH 3/4] remoteproc: add support for a new 64-bit trace version Message-ID: <20200522173346.GJ11847@yoga> References: <20200325204701.16862-1-s-anna@ti.com> <20200325204701.16862-4-s-anna@ti.com> <20200521180417.GJ408178@builder.lan> <997d6f9a-64ba-7a89-e909-9a5a474120b0@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200522_103350_721469_9D681CC8 X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mathieu Poirier , Loic Pallardy , Lokesh Vutla , linux-remoteproc@vger.kernel.org, Arnaud Pouliquen , linux-kernel@vger.kernel.org, Clement Leger , Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri 22 May 09:54 PDT 2020, Suman Anna wrote: > On 5/21/20 2:42 PM, Suman Anna wrote: > > Hi Bjorn, > > = > > On 5/21/20 1:04 PM, Bjorn Andersson wrote: > > > On Wed 25 Mar 13:47 PDT 2020, Suman Anna wrote: [..] > > > > diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h [..] > > > > +struct fw_rsc_trace2 { > > > = > > > Sounds more like fw_rsc_trace64 to me - in particular since the versi= on > > > of trace2 is 1... > > = > > Yeah, will rename this. > > = > > > = > > > > +=A0=A0=A0 u32 padding; > > > > +=A0=A0=A0 u64 da; > > > > +=A0=A0=A0 u32 len; > > > > +=A0=A0=A0 u32 reserved; > > > = > > > What's the purpose of this reserved field? > > = > > Partly to make sure the entire resource is aligned on an 8-byte, and > > partly copied over from fw_rsc_trace entry. I guess 32-bits is already > > large enough of a size for trace entries irrespective of 32-bit or > > 64-bit traces, so I doubt if we want to make the len field also a u64. > = > Looking at this again, I can drop both padding and reserved fields, if I > move the len field before da. Any preferences/comments? > = Sounds good to me. Thanks, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel