From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 2/4] xfs: measure all contiguous previous extents for prealloc size
Date: Sat, 23 May 2020 00:09:33 -0700 [thread overview]
Message-ID: <20200523070933.GA8693@infradead.org> (raw)
In-Reply-To: <20200522112722.GA50656@bfoster>
On Fri, May 22, 2020 at 07:27:22AM -0400, Brian Foster wrote:
> Why do we replace the bit shifts with division/multiplication? I'd
> prefer to see the former for obvious power of 2 operations, even if this
> happens to be 32-bit arithmetic. I don't see any particular reason to
> change it in this patch.
Because it is the natural way to express the operation and matches what
is said in the comments.
next prev parent reply other threads:[~2020-05-23 7:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 2:52 [PATCH v3 0/4] xfs: fix stale disk exposure after crash Darrick J. Wong
2020-05-22 2:53 ` [PATCH 1/4] xfs: don't fail unwritten extent conversion on writeback due to edquot Darrick J. Wong
2020-05-22 2:53 ` [PATCH 2/4] xfs: measure all contiguous previous extents for prealloc size Darrick J. Wong
2020-05-22 6:56 ` Christoph Hellwig
2020-05-23 0:25 ` Darrick J. Wong
2020-05-22 11:27 ` Brian Foster
2020-05-23 0:27 ` Darrick J. Wong
2020-05-23 7:09 ` Christoph Hellwig [this message]
2020-05-22 2:53 ` [PATCH 3/4] xfs: refactor xfs_iomap_prealloc_size Darrick J. Wong
2020-05-22 6:57 ` Christoph Hellwig
2020-05-22 2:53 ` [PATCH 4/4] xfs: force writes to delalloc regions to unwritten Darrick J. Wong
2020-05-22 3:31 ` Dave Chinner
2020-05-22 3:56 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2020-05-23 16:49 [PATCH v4 0/4] xfs: fix stale disk exposure after crash Darrick J. Wong
2020-05-23 16:49 ` [PATCH 2/4] xfs: measure all contiguous previous extents for prealloc size Darrick J. Wong
2020-05-24 9:14 ` Christoph Hellwig
2020-05-24 17:16 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523070933.GA8693@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.