From: Greg KH <gregkh@linuxfoundation.org>
To: Sultan Alsawaf <sultan@kerneltoast.com>
Cc: colin.king@canonical.com, stable@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] ext4: lock the xattr block before checksuming it
Date: Sat, 23 May 2020 13:11:12 +0200 [thread overview]
Message-ID: <20200523111112.GA3632470@kroah.com> (raw)
In-Reply-To: <20200523031821.501455-1-sultan@kerneltoast.com>
On Fri, May 22, 2020 at 08:18:21PM -0700, Sultan Alsawaf wrote:
> From: Theodore Ts'o <tytso@mit.edu>
>
> commit dac7a4b4b1f664934e8b713f529b629f67db313c upstream.
>
> We must lock the xattr block before calculating or verifying the
> checksum in order to avoid spurious checksum failures.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=193661
>
> Reported-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Cc: stable@vger.kernel.org
> Signed-off-by: Sultan Alsawaf <sultan@kerneltoast.com>
> ---
> Hi,
>
> I've been experiencing spurious ext4 checksum failures on 4.4 because
> this patch is missing (which is quite painful with panic-on-error
> enabled). This backport fixes the issue for me.
> fs/ext4/xattr.c | 66 ++++++++++++++++++++++++-------------------------
> 1 file changed, 32 insertions(+), 34 deletions(-)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2020-05-23 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 16:56 FAILED: patch "[PATCH] ext4: lock the xattr block before checksuming it" failed to apply to 4.4-stable tree gregkh
2020-05-23 3:18 ` [PATCH] ext4: lock the xattr block before checksuming it Sultan Alsawaf
2020-05-23 11:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523111112.GA3632470@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=colin.king@canonical.com \
--cc=stable@vger.kernel.org \
--cc=sultan@kerneltoast.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.