From: Stephen Hemminger <stephen@networkplumber.org>
To: Armin Wolf <W_Armin@gmx.de>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix various coding-style issues and improve printk() usage
Date: Sat, 23 May 2020 12:57:55 -0700 [thread overview]
Message-ID: <20200523125755.65457014@hermes.lan> (raw)
In-Reply-To: <20200523160644.GA17787@mx-linux-amd>
On Sat, 23 May 2020 18:06:44 +0200
Armin Wolf <W_Armin@gmx.de> wrote:
> /* These identify the driver base version and may not be removed. */
> static const char version[] =
> - KERN_INFO DRV_NAME ".c:v" DRV_VERSION " " DRV_RELDATE
> - " D. Becker/P. Gortmaker\n";
> + "Version " DRV_VERSION " " DRV_RELDATE " D. Becker/P. Gortmaker\n";
This is how Linux drivers behaved years ago, it is bad practice now.
prev parent reply other threads:[~2020-05-23 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-23 16:06 [PATCH] Fix various coding-style issues and improve printk() usage Armin Wolf
2020-05-23 19:57 ` Stephen Hemminger
2020-05-23 19:57 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523125755.65457014@hermes.lan \
--to=stephen@networkplumber.org \
--cc=W_Armin@gmx.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.