From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Disseldorp Date: Sat, 23 May 2020 13:03:03 +0000 Subject: Re: [PATCH] scsi: target: tcmu: Fix a use after free in tcmu_check_expired_queue_cmd() Message-Id: <20200523150303.5bd1d24a@suse.de> List-Id: References: <20200523101129.GB98132@mwanda> In-Reply-To: <20200523101129.GB98132@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: "Martin K. Petersen" , Bodo Stroesser , Mike Christie , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kernel-janitors@vger.kernel.org On Sat, 23 May 2020 13:11:29 +0300, Dan Carpenter wrote: > The pr_debug() dereferences "cmd" after we already freed it by calling > tcmu_free_cmd(cmd). The debug printk needs to be done earlier. > > Fixes: 61fb24822166 ("scsi: target: tcmu: Userspace must not complete queued commands") > Signed-off-by: Dan Carpenter Reviewed-by: David Disseldorp Looks like this could be squashed in with the change that it fixes, given that 5.8/scsi-queue hasn't gone out yet. Cheers, David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCAC4C433E0 for ; Sat, 23 May 2020 13:03:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDDB62071C for ; Sat, 23 May 2020 13:03:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731328AbgEWNDH (ORCPT ); Sat, 23 May 2020 09:03:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:50564 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731227AbgEWNDH (ORCPT ); Sat, 23 May 2020 09:03:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id DA3DCAC2C; Sat, 23 May 2020 13:03:08 +0000 (UTC) Date: Sat, 23 May 2020 15:03:03 +0200 From: David Disseldorp To: Dan Carpenter Cc: "Martin K. Petersen" , Bodo Stroesser , Mike Christie , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] scsi: target: tcmu: Fix a use after free in tcmu_check_expired_queue_cmd() Message-ID: <20200523150303.5bd1d24a@suse.de> In-Reply-To: <20200523101129.GB98132@mwanda> References: <20200523101129.GB98132@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Sat, 23 May 2020 13:11:29 +0300, Dan Carpenter wrote: > The pr_debug() dereferences "cmd" after we already freed it by calling > tcmu_free_cmd(cmd). The debug printk needs to be done earlier. > > Fixes: 61fb24822166 ("scsi: target: tcmu: Userspace must not complete queued commands") > Signed-off-by: Dan Carpenter Reviewed-by: David Disseldorp Looks like this could be squashed in with the change that it fixes, given that 5.8/scsi-queue hasn't gone out yet. Cheers, David