From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Sun, 24 May 2020 14:23:35 -0400 Subject: [PATCH 0/6] checkpatch.pl: Add features to help improve U-Boot code In-Reply-To: <20200522223240.187032-1-sjg@chromium.org> References: <20200522223240.187032-1-sjg@chromium.org> Message-ID: <20200524182335.GI26741@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, May 22, 2020 at 04:32:34PM -0600, Simon Glass wrote: > U-Boot mostly follows linux for coding style, but it has some of its own > features. These come up again and again in code review. We should try to > reduce the load of reviewers. > > This series adds a little U-Boot function to the checkpatch script and an > option to enable it. Hopefully it is easy enough to maintain this as the > script is updated, even if it is not accepted upstream. > > Some initial checks are included as examples of what we can do. > > > Simon Glass (6): > checkpatch.pl: Update to v5.7-rc6 > checkpatch.pl: Add a U-Boot option > checkpatch.pl: Add a check for tests needed for uclasses > checkpatch.pl: Warn if the flattree API is used > checkpatch.pl: Request a test when a new command is added > checkpatch.pl: Request if() instead #ifdef > > .checkpatch.conf | 3 + > doc/README.commands | 50 +++++++++ > scripts/checkpatch.pl | 252 +++++++++++++++--------------------------- > 3 files changed, 144 insertions(+), 161 deletions(-) I'm not reviewing the changes as I am not a pearl person but I think this is a great idea and will help keep us from dropping our changes in the future too. I'll rebase my CONFIG_CMD_xxx check on top of your series before applying. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: