From: Al Viro <viro@zeniv.linux.org.uk>
To: Sargun Dhillon <sargun@sargun.me>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.linux-foundation.org>,
Linux API <linux-api@vger.kernel.org>,
Christian Brauner <christian.brauner@ubuntu.com>,
Tycho Andersen <tycho@tycho.ws>,
Kees Cook <keescook@chromium.org>,
Aleksa Sarai <cyphar@cyphar.com>,
Jeffrey Vander Stoep <jeffv@google.com>,
Jann Horn <jannh@google.com>, Robert Sesek <rsesek@google.com>,
Chris Palmer <palmer@google.com>,
Matt Denton <mpdenton@google.com>,
Kees Cook <keescook@google.com>
Subject: Re: [PATCH 2/5] seccomp: Introduce addfd ioctl to seccomp user notifier
Date: Mon, 25 May 2020 01:39:19 +0100 [thread overview]
Message-ID: <20200525003919.GC23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAMp4zn-F3b8Z4ZDjgnJM1Fbban2oVtCm_rZkhBhDKs6fw2_=rg@mail.gmail.com>
On Sun, May 24, 2020 at 05:27:58PM -0700, Sargun Dhillon wrote:
> > if (addfd->fd >= 0) {
> > ret = replace_fd(addfd->fd, addfd->file, addfd->flags);
> > } else {
> > ret = get_unused_fd_flags(addfd->flags);
> > if (ret >= 0)
> > fd_install(ret, get_file(addfd->file));
^^^^^^^^
> Wouldn't this result in consumption of reference in one case (fd_install),
> and the fd still having a reference in the replace_fd case?
next prev parent reply other threads:[~2020-05-25 0:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 23:39 [PATCH 0/5] Add seccomp notifier ioctl that enables adding fds Sargun Dhillon
2020-05-24 23:39 ` [PATCH 1/5] seccomp: Add find_notification helper Sargun Dhillon
2020-05-24 23:55 ` Tycho Andersen
2020-05-25 13:26 ` Christian Brauner
2020-05-24 23:39 ` [PATCH 2/5] seccomp: Introduce addfd ioctl to seccomp user notifier Sargun Dhillon
2020-05-24 23:57 ` Tycho Andersen
2020-05-24 23:58 ` Tycho Andersen
2020-05-25 0:05 ` Al Viro
2020-05-25 0:27 ` Sargun Dhillon
2020-05-25 0:39 ` Al Viro [this message]
2020-05-25 13:50 ` Christian Brauner
2020-05-26 6:59 ` Sargun Dhillon
2020-05-26 8:22 ` Christian Brauner
2020-05-24 23:39 ` [PATCH 3/5] selftests/seccomp: Test SECCOMP_IOCTL_NOTIF_ADDFD Sargun Dhillon
2020-05-24 23:39 ` [PATCH 4/5] seccomp: Add SECCOMP_ADDFD_FLAG_MOVE flag to add fd ioctl Sargun Dhillon
2020-05-25 14:20 ` Christian Brauner
2020-05-26 6:08 ` Sargun Dhillon
2020-05-24 23:39 ` [PATCH 5/5] selftests/seccomp: Add test for addfd move semantics Sargun Dhillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525003919.GC23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=christian.brauner@ubuntu.com \
--cc=containers@lists.linux-foundation.org \
--cc=cyphar@cyphar.com \
--cc=jannh@google.com \
--cc=jeffv@google.com \
--cc=keescook@chromium.org \
--cc=keescook@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpdenton@google.com \
--cc=palmer@google.com \
--cc=rsesek@google.com \
--cc=sargun@sargun.me \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.