From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDDABC433E0 for ; Mon, 25 May 2020 06:19:39 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 576DC2071A for ; Mon, 25 May 2020 06:19:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="XASw3k2S"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sgLbL5BC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 576DC2071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B2E3516F2; Mon, 25 May 2020 08:18:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B2E3516F2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1590387577; bh=JASidayBW8v8c4a1G+F4808rKv2FutCxzdkc1kcE/TM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XASw3k2SSmpuEnhUeR7lTL5/+7g6xvqmvTKLg2R/qQinjPX66+PTJtOHnvzrtx1LV LWD/aECq62J1HwBOlnJf6cSdXO9BkxlVMm0r3J7M/X0K0qX7kUQIKzINZPHZS1W42F jlWDxwJklZW4vnR544VUCPh/vIsBi2HUsWHy7u5A= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 48417F8014E; Mon, 25 May 2020 08:18:47 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0F472F8021E; Mon, 25 May 2020 08:18:46 +0200 (CEST) Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 05376F8014E for ; Mon, 25 May 2020 08:18:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 05376F8014E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sgLbL5BC" Received: by mail-pf1-x442.google.com with SMTP id 23so8424589pfy.8 for ; Sun, 24 May 2020 23:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qkQKxQdGGgWdvEooTQeXfQ5Uv6xFbcDpVhOQuc16oUc=; b=sgLbL5BCVGnsptyzLFvhBHakHWNFyE7cXapL55cgodXb2vOhXm56MOdyIhCbvyn+V6 N5SpUnMqMfQTxpDC1oxfNr3O0Z5D9Q+P35dmFRYpwkUHzM7HUXzNKDIN4y3Q/pt4yOOj nJ79hm3sG+vkBgfUoOUM7+9/7ASYFUIelrkTzM+sj4p7iYvQyMjNUzbnGcY/2i3fO8x8 78Xsdeo6b0CdlwlRBVjX9uib/uaYHpQkXdll055UGUGElf7mLUzQphtdpc4wZyA7j5eV FgMRfBBTXcDDFYydBzTMFJxhjryo7u9v5GiERnJ6QEtJl9DvihXJrH+0ZCeDrKJ9dyYr NrPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qkQKxQdGGgWdvEooTQeXfQ5Uv6xFbcDpVhOQuc16oUc=; b=H1kGtscnY7efzDpWkJWRX3JUrJaPtoIy649/d33gjqonxVYbu6cPvrhTdi61RYEvt8 Dl1G4GnYywxUbwF/kJTuXy8Wwml4IzF5C7JCumCf1H7sx0j2sBhR1r/+W+9pxD2Xevwa wztEGn9su9iDWbSm4wgNyzBF7bBDaHf5LjuDr+Xwpmdh5SbxTQEIT3MY/fnzBQ6HXv/m x2D6Hqk+wpqEjGZhd4n1YPkNagE/Z8x1kJLtJfJkoBQosrCHdV3YHTnYtUiW+LGdv7K1 O0D5isrqb6/gSe03VUtMSAeBHYozAq5sNbejJ7bc6hS93oatNKvtXvAOjV2BP1GcPRDH TXbQ== X-Gm-Message-State: AOAM531u7tkcVz7eXSuEH11NGfVVZy4STYKVYm5sR2L+qprvbx6ciZDx qq9zwJr1IjwzMO5jhe/sTgA= X-Google-Smtp-Source: ABdhPJxg1bg01cddhbRJZVYfWekQ2aQNsAE8dMBcRjN0GaOgL4XmmTFhE2NzLEqiY8iUckwGGjP/VA== X-Received: by 2002:a65:52cd:: with SMTP id z13mr10751049pgp.259.1590387512418; Sun, 24 May 2020 23:18:32 -0700 (PDT) Received: from Asurada (c-73-162-191-63.hsd1.ca.comcast.net. [73.162.191.63]) by smtp.gmail.com with ESMTPSA id i197sm24018pfe.30.2020.05.24.23.18.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 May 2020 23:18:32 -0700 (PDT) Date: Sun, 24 May 2020 23:18:27 -0700 From: Nicolin Chen To: Shengjiu Wang Subject: Re: [PATCH] ASoC: fsl_asrc: Merge suspend/resume function to runtime_suspend/resume Message-ID: <20200525061827.GB12112@Asurada> References: <1590141444-28668-1-git-send-email-shengjiu.wang@nxp.com> <20200525050950.GA1244@Asurada> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Cc: Linux-ALSA , Timur Tabi , Xiubo Li , Fabio Estevam , Shengjiu Wang , Takashi Iwai , Liam Girdwood , Mark Brown , linuxppc-dev@lists.ozlabs.org, linux-kernel X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, May 25, 2020 at 02:11:18PM +0800, Shengjiu Wang wrote: > > > @@ -1135,6 +1137,24 @@ static int fsl_asrc_runtime_resume(struct device *dev) > > > goto disable_asrck_clk; > > > } > > > > > > + /* Stop all pairs provisionally */ > > > + regmap_read(asrc->regmap, REG_ASRCTR, &asrctr); > > > + regmap_update_bits(asrc->regmap, REG_ASRCTR, > > > + ASRCTR_ASRCEi_ALL_MASK, 0); > > > + > > > + /* Restore all registers */ > > > + regcache_cache_only(asrc->regmap, false); > > > + regcache_mark_dirty(asrc->regmap); > > > > > > I see you doing regcache_mark_dirty() in the resume() now, > > being different from previously doing in suspend()? > Which is for probe -> runtime_resume case. > After probe, the power may be disabled, so move mark_dirtry > to runtime_resume, then regcache can re-write all the registers. I see. Just noticed that you add a regcache_cache_only in probe(). Acked already. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63EDEC433E0 for ; Mon, 25 May 2020 06:18:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 411452071A for ; Mon, 25 May 2020 06:18:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sgLbL5BC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730565AbgEYGSd (ORCPT ); Mon, 25 May 2020 02:18:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729690AbgEYGSc (ORCPT ); Mon, 25 May 2020 02:18:32 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5D1AC061A0E for ; Sun, 24 May 2020 23:18:32 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id u5so8285616pgn.5 for ; Sun, 24 May 2020 23:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qkQKxQdGGgWdvEooTQeXfQ5Uv6xFbcDpVhOQuc16oUc=; b=sgLbL5BCVGnsptyzLFvhBHakHWNFyE7cXapL55cgodXb2vOhXm56MOdyIhCbvyn+V6 N5SpUnMqMfQTxpDC1oxfNr3O0Z5D9Q+P35dmFRYpwkUHzM7HUXzNKDIN4y3Q/pt4yOOj nJ79hm3sG+vkBgfUoOUM7+9/7ASYFUIelrkTzM+sj4p7iYvQyMjNUzbnGcY/2i3fO8x8 78Xsdeo6b0CdlwlRBVjX9uib/uaYHpQkXdll055UGUGElf7mLUzQphtdpc4wZyA7j5eV FgMRfBBTXcDDFYydBzTMFJxhjryo7u9v5GiERnJ6QEtJl9DvihXJrH+0ZCeDrKJ9dyYr NrPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qkQKxQdGGgWdvEooTQeXfQ5Uv6xFbcDpVhOQuc16oUc=; b=j+enOJ8RGQDhc+xN1TkOpyU8tw/5uprMU9BRw8/QUktlupmxGPKfGnl/fZM9OB6kKo aI1MCgY4w/cvSLf+eE6q3mLqKS5Vmb2qRrZUm6VLcfgMwDeaBqaey1iJGSs+e6/TXU8e F8P8zGAnWYrRXNOxwerc0JMJdONxWGTT5oFgOzVpN8jfxb83lNg47vi1xIRgl+ddMHf1 fi6RSoSvw/ZCEtIG7Dx7EqoD17UvUO0p2O27l742sWgAB5jFNKnhy3aQ03IcjDyJ3tPt /IjQK5vCo2p0dgGVyKlYL8z4gyoyqDzXNOauG1s7gKZndENjTU1IZ+9zjpP3ilMQ1IGT xlXA== X-Gm-Message-State: AOAM532o/PQS1s3YBN41jTeKHyKNIdfTP2CXOzYqbo+LjsRWoQ4YB5Wj C2Wp+9qE+966gAiGz7mZofs= X-Google-Smtp-Source: ABdhPJxg1bg01cddhbRJZVYfWekQ2aQNsAE8dMBcRjN0GaOgL4XmmTFhE2NzLEqiY8iUckwGGjP/VA== X-Received: by 2002:a65:52cd:: with SMTP id z13mr10751049pgp.259.1590387512418; Sun, 24 May 2020 23:18:32 -0700 (PDT) Received: from Asurada (c-73-162-191-63.hsd1.ca.comcast.net. [73.162.191.63]) by smtp.gmail.com with ESMTPSA id i197sm24018pfe.30.2020.05.24.23.18.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 May 2020 23:18:32 -0700 (PDT) Date: Sun, 24 May 2020 23:18:27 -0700 From: Nicolin Chen To: Shengjiu Wang Cc: Shengjiu Wang , Linux-ALSA , Timur Tabi , Xiubo Li , linuxppc-dev@lists.ozlabs.org, Takashi Iwai , Liam Girdwood , Mark Brown , Fabio Estevam , linux-kernel Subject: Re: [PATCH] ASoC: fsl_asrc: Merge suspend/resume function to runtime_suspend/resume Message-ID: <20200525061827.GB12112@Asurada> References: <1590141444-28668-1-git-send-email-shengjiu.wang@nxp.com> <20200525050950.GA1244@Asurada> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2020 at 02:11:18PM +0800, Shengjiu Wang wrote: > > > @@ -1135,6 +1137,24 @@ static int fsl_asrc_runtime_resume(struct device *dev) > > > goto disable_asrck_clk; > > > } > > > > > > + /* Stop all pairs provisionally */ > > > + regmap_read(asrc->regmap, REG_ASRCTR, &asrctr); > > > + regmap_update_bits(asrc->regmap, REG_ASRCTR, > > > + ASRCTR_ASRCEi_ALL_MASK, 0); > > > + > > > + /* Restore all registers */ > > > + regcache_cache_only(asrc->regmap, false); > > > + regcache_mark_dirty(asrc->regmap); > > > > > > I see you doing regcache_mark_dirty() in the resume() now, > > being different from previously doing in suspend()? > Which is for probe -> runtime_resume case. > After probe, the power may be disabled, so move mark_dirtry > to runtime_resume, then regcache can re-write all the registers. I see. Just noticed that you add a regcache_cache_only in probe(). Acked already. Thanks.