From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87FD5C433DF for ; Mon, 25 May 2020 08:19:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63A332071A for ; Mon, 25 May 2020 08:19:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63A332071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E1FD589AAD; Mon, 25 May 2020 08:19:29 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id E14F789AAD for ; Mon, 25 May 2020 08:19:28 +0000 (UTC) IronPort-SDR: 76mRYA5qR68/tEh8XkKNvXQR5nn2/NJPrc4wPtTKhBNknrbE566/CHqPZuN8RsiE0blbM5w5lA 42DJGPEWpK7A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2020 01:19:28 -0700 IronPort-SDR: ZfHucAD5Y/tf+kTjyz0mcsvVqD2A2ZZPSHQZITzeAlUI/NZHZYR+ZPRQTlPnjqMvQ+psGt8aDk B33fcoFsqq4w== X-IronPort-AV: E=Sophos;i="5.73,432,1583222400"; d="scan'208";a="256174399" Received: from unknown (HELO intel.com) ([10.237.72.89]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2020 01:19:27 -0700 Date: Mon, 25 May 2020 11:15:31 +0300 From: "Lisovskiy, Stanislav" To: Chris Wilson Message-ID: <20200525081530.GA32239@intel.com> References: <20200525080731.2244-1-chris@chris-wilson.co.uk> <20200525080754.GA32204@intel.com> <159039461424.30979.17871163129232770512@build.alporthouse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <159039461424.30979.17871163129232770512@build.alporthouse.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH] drm/i915: Revert CDCLK changes to unbreak geminilake X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, May 25, 2020 at 09:16:54AM +0100, Chris Wilson wrote: > Quoting Lisovskiy, Stanislav (2020-05-25 09:07:54) > > On Mon, May 25, 2020 at 09:07:31AM +0100, Chris Wilson wrote: > > > This reverts > > > cac91e671ad5 ("drm/i915: Fix includes and local vars order") > > > 82ea174dc542 ("drm/i915: Remove unneeded hack now for CDCLK") > > > cd1915460861 ("drm/i915: Adjust CDCLK accordingly to our DBuf bw need= s") > > > = > > > Cc: Stanislav Lisovskiy > > > Cc: Manasi Navare > > > Cc: "Ville Syrj=E4l=E4" > > = > > = > > I guess we still need to check more precisely if this patch caused > > this - or have you already bisected that? > = > This was found by unwinding the patches on CI. > = > > It is rather strange that it breaks only a GLK and only single test. > = > Bug detection is purely serendipitous. > -Chris Ok then lets rewind those - then it will become clear at least. Reviewed-by: Stanislav Lisovskiy _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx