From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: kvalo@codeaurora.org, Larry.Finger@lwfinger.net,
linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH] rt2800lib: unconditionally enable MFP
Date: Mon, 25 May 2020 10:17:33 +0200 [thread overview]
Message-ID: <20200525081733.GA919245@wp.pl> (raw)
In-Reply-To: <CALjTZvbHbMEWTmZk4Li5ZNAETdVd3Q_kHUS6KQw+WDS6ayE9vA@mail.gmail.com>
Hello
On Sun, May 24, 2020 at 04:07:23PM +0100, Rui Salvaterra wrote:
> Hi, Stanislaw,
>
> On Sun, 24 May 2020 at 12:18, Stanislaw Gruszka <stf_xl@wp.pl> wrote:
> >
> > AFICT more work need to be done to support MFP by HW encryption properly
> > on rt2x00. See this message and whole thread:
> > https://lore.kernel.org/linux-wireless/977a3cf4-3ec5-4aaa-b3d4-eea2e8593652@nbd.name/
> >
> > Stanislaw
>
> This RT2790 has been working just fine with my patch for hours. No
> hangs at all. What additional bad behaviour should I expect?
If you use new cipher like WLAN_CIPHER_SUITE_AES_CMAC (what I think is
default for MFP setups) things will work just fine, because all
encryption will be done by software.
For older ciphers that are offloaded to hardware, namely
WLAN_CIPHER_SUITE_CCMP, management frames like Disassociate, Deauthenticate,
Action, will not be sent properly encrypted.
On quoted thread described visible problem was lag and performance drop
due to failed A-MPDU aggregation session setup.
Stanislaw
prev parent reply other threads:[~2020-05-25 8:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 9:47 [RFC PATCH] rt2800lib: unconditionally enable MFP Rui Salvaterra
2020-05-24 11:17 ` Stanislaw Gruszka
2020-05-24 11:42 ` Julian Calaby
2020-05-24 12:39 ` Stanislaw Gruszka
2020-05-25 9:15 ` Johannes Berg
2020-05-25 9:31 ` Stanislaw Gruszka
2020-05-25 9:49 ` Johannes Berg
2020-05-25 10:58 ` Stanislaw Gruszka
2020-05-25 11:14 ` Rui Salvaterra
2020-05-25 12:25 ` Stanislaw Gruszka
2020-05-25 12:33 ` Rui Salvaterra
2020-05-25 13:13 ` Rui Salvaterra
2020-05-25 13:14 ` Johannes Berg
2020-05-25 13:28 ` Rui Salvaterra
2020-05-24 15:07 ` Rui Salvaterra
2020-05-25 0:02 ` Larry Finger
2020-05-25 9:17 ` Johannes Berg
2020-05-25 8:17 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525081733.GA919245@wp.pl \
--to=stf_xl@wp.pl \
--cc=Larry.Finger@lwfinger.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rsalvaterra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.