All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <Tudor.Ambarus@microchip.com>,
	<linux-mtd@lists.infradead.org>
Cc: Boris Brezillon <boris.brezillon@collabora.com>
Subject: Re: [PATCH v2 00/17] Clean nandsim error path
Date: Mon, 25 May 2020 10:55:02 +0200	[thread overview]
Message-ID: <20200525105502.287ecac5@xps13> (raw)
In-Reply-To: <20200525085329.17259-1-miquel.raynal@bootlin.com>


Miquel Raynal <miquel.raynal@bootlin.com> wrote on Mon, 25 May 2020
10:52:10 +0200:

> Hello,
> 
> As part of a bigger cleanup I realized the error path of nandsim.c was
> horribly wrong. There are a few additional changes, like having a
> consistent naming for a given object, but moreover this is an error
> path cleanup, driver-wide.

Wrong operation on my side, I was about to send 90 patches so I
canceled the operation.

I will resend, sorry for the noise.

> 
> Cheers,
> Miquèl
> 
> Changes in v2:
> * Reordered the kfree() and the list_del() to avoid a use after free
>   issue that I introduced in v1.
> * Used debugfs_remove_recursive() instead of just debugfs_remove().
> 
> Miquel Raynal (17):
>   mtd: rawnand: nandsim: Consistent use of 'ns' instead of 'dev'
>   mtd: rawnand: nandsim: Use octal permissions
>   mtd: rawnand: nandsim: Use a consistent ns_ prefix for all functions
>   mtd: rawnand: nandsim: Clean error handling
>   mtd: rawnand: nandsim: Keep track of the created debugfs entries
>   mtd: rawnand: nandsim: Remove debugfs entries at unload time
>   mtd: rawnand: nandsim: Fix the two ns_alloc_device() error paths
>   mtd: rawnand: nandsim: Free partition names on error in ns_init()
>   mtd: rawnand: nandsim: Free the allocated device on error in ns_init()
>   mtd: rawnand: nandsim: Free the partition names in ns_free()
>   mtd: rawnand: nandsim: Stop using nand_release()
>   mtd: rawnand: nandsim: Use an additional label when freeing the
>     nandsim object
>   mtd: rawnand: nandsim: Free erase_block_wear on error
>   mtd: rawnand: nandsim: Fix the label pointing on nand_cleanup()
>   mtd: rawnand: nandsim: Manage lists on error in ns_init_module()
>   mtd: rawnand: nandsim: Rename a label in ns_init_module()
>   mtd: rawnand: nandsim: Reorganize ns_cleanup_module()
> 
>  drivers/mtd/nand/raw/nandsim.c | 437 +++++++++++++++++++--------------
>  1 file changed, 253 insertions(+), 184 deletions(-)
> 


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2020-05-25  8:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25  8:52 [PATCH v2 00/17] Clean nandsim error path Miquel Raynal
2020-05-25  8:52 ` [PATCH v2 01/62] mtd: rawnand: ams-delta: Stop using nand_release() Miquel Raynal
2020-05-25  8:52 ` [PATCH v2 01/17] mtd: rawnand: nandsim: Consistent use of 'ns' instead of 'dev' Miquel Raynal
2020-05-25  8:55 ` Miquel Raynal [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-05-25  8:58 [PATCH v2 00/17] Clean nandsim error path Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200525105502.287ecac5@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=boris.brezillon@collabora.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.