From: Greg Kurz <groug@kaod.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: anthony.perard@citrix.com, qemu_oss@crudebyte.com,
qemu-devel@nongnu.org, paul@xen.org
Subject: Re: [PATCH v2 0/3] revert 9pfs reply truncation, wait for free room to reply
Date: Mon, 25 May 2020 15:48:47 +0200 [thread overview]
Message-ID: <20200525154847.3e862973@bahia.lan> (raw)
In-Reply-To: <alpine.DEB.2.21.2005211225030.27502@sstabellini-ThinkPad-T480s>
On Thu, 21 May 2020 12:26:18 -0700 (PDT)
Stefano Stabellini <sstabellini@kernel.org> wrote:
> Hi all,
>
> This short series reverts commit 16724a173049ac29c7b5ade741da93a0f46edff
> becauses it is the cause for https://bugs.launchpad.net/bugs/1877688.
>
> The original issue addressed by 16724a173049ac29c7b5ade741da93a0f46edff
> is solved differently in this series by using qemu_coroutine_yield() to
> wait for the client to free more data from the ring before sending the
> reply.
>
> Cheers,
>
> Stefano
>
I wasn't really involved in the review of these patches, but I've
done some testing with virtio-9p which show no regression. I
assume you have done some testing on the Xen side as well. So
I've pushed the series to 9p-next. I shall send a PR in a day
or so.
Cheers,
--
Greg
> Changes in v2:
> - add comments on barriers
> - add patch to increase ring size to the max allowed
prev parent reply other threads:[~2020-05-25 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 19:26 [PATCH v2 0/3] revert 9pfs reply truncation, wait for free room to reply Stefano Stabellini
2020-05-21 19:26 ` [PATCH v2 1/3] Revert "9p: init_in_iov_from_pdu can truncate the size" Stefano Stabellini
2020-05-22 12:34 ` Christian Schoenebeck
2020-05-21 19:26 ` [PATCH v2 2/3] xen/9pfs: yield when there isn't enough room on the ring Stefano Stabellini
2020-05-21 19:26 ` [PATCH v2 3/3] xen/9pfs: increase max ring order to 9 Stefano Stabellini
2020-05-22 12:35 ` Christian Schoenebeck
2020-05-25 13:48 ` Greg Kurz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525154847.3e862973@bahia.lan \
--to=groug@kaod.org \
--cc=anthony.perard@citrix.com \
--cc=paul@xen.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.